From a0b42e6f964d1a983f43cc085456e09a1f44b836 Mon Sep 17 00:00:00 2001 From: Arran Cudbard-Bell Date: Fri, 13 Jun 2014 16:37:54 +0100 Subject: [PATCH] The fewer magic numbers the better... --- src/lib/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/misc.c b/src/lib/misc.c index 2bf11c2..abe5c90 100644 --- a/src/lib/misc.c +++ b/src/lib/misc.c @@ -1015,8 +1015,8 @@ size_t fr_hex2bin(uint8_t *bin, size_t outlen, char const *hex, size_t inlen) if (len > outlen) len = outlen; for (i = 0; i < len; i++) { - if(!(c1 = memchr(hextab, tolower((int) hex[i << 1]), 16)) || - !(c2 = memchr(hextab, tolower((int) hex[(i << 1) + 1]), 16))) + if(!(c1 = memchr(hextab, tolower((int) hex[i << 1]), sizeof(hextab))) || + !(c2 = memchr(hextab, tolower((int) hex[(i << 1) + 1]), sizeof(hextab)))) break; bin[i] = ((c1-hextab)<<4) + (c2-hextab); } -- 2.1.4