- Submitting patches or diff's to the FreeRADIUS project
+Submitting patches or diff's to the FreeRADIUS project
+======================================================
For a person or company wishing to submit a change to the
FreeRADIUS project, the process can sometimes be daunting if you're
being accepted.
SECTION 1 - CREATING AND SENDING YOUR CHANGE
+--------------------------------------------
1. "diff -u"
When in doubt, re-submit.
SECTION 2 - HINTS, TIPS, AND TRICKS
+-----------------------------------
This section lists many of the common "rules" associated with code
submitted to the project. There are always exceptions... but you must
1. Read the Documentation and follow the CodingStyle
The FreeRADIUS server has a common coding style. Use real tabs
- to indent. There is whitespace in variable assignments.
+ to indent. There is whitespace in variable assignments.
(i = 1, NOT i=1).
When in doubt, format your code to look the same as code already
are used in the code. Let the compiler optimize away the "no-op"
case.
- Simple example, of poor code:
+ Simple example, of poor code::
#ifdef CONFIG_MY_FUNKINESS
init_my_stuff(foo);
Cleaned-up example:
- (in header)
+ (in header)::
#ifndef CONFIG_MY_FUNKINESS
static inline void init_my_stuff(char *foo) {}
#endif
- (in the code itself)
+ (in the code itself)::
- ...
init_my_stuff(dev);
- ...
3. 'static inline' is better than a macro