Ensure we leave room for the trailing NUL

[freeradius.git] / src / main / conffile.c

diff --git a/src/main/conffile.c b/src/main/conffile.c
index 4feed80..ee47afb 100644 (file)
--- a/src/main/conffile.c
+++ b/src/main/conffile.c
@@ -2589,7 +2589,7 @@ int cf_pair2xml(FILE *fp, const CONF_PAIR *cp)
                char *p = buffer;
                const char *q = cp->value;
 
-               while (*q && (p < (buffer + sizeof(buffer)))) {
+               while (*q && (p < (buffer + sizeof(buffer) - 1))) {
                        if (q[0] == '&') {
                                memcpy(p, "&amp;", 4);
                                p += 5;