From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Sun, 4 Oct 2015 22:41:38 +0000 (-0400)
Subject: Fix off by one error in rlm_mschap that sometimes meant correctly formatted MS-CHAP... 
X-Git-Tag: release_3_0_10~10
X-Git-Url: http://www.project-moonshot.org/gitweb/?p=freeradius.git;a=commitdiff_plain;h=28dea83521f3013e67f8296806f0790a20b2948d

Fix off by one error in rlm_mschap that sometimes meant correctly formatted MS-CHAP-Error messages were not returned

(sometimes is that the behaviour depended on an uninitialised byte)
---

diff --git a/src/modules/rlm_mschap/rlm_mschap.c b/src/modules/rlm_mschap/rlm_mschap.c
index 9c2d34c..d6fe3d6 100644
--- a/src/modules/rlm_mschap/rlm_mschap.c
+++ b/src/modules/rlm_mschap/rlm_mschap.c
@@ -1870,7 +1870,8 @@ static rlm_rcode_t CC_HINT(nonnull) mod_authenticate(void * instance, REQUEST *r
 						 sizeof(buffer) - 12 - (i * 2), "%02x",
 						 fr_rand() & 0xff);
 				}
-				snprintf(buffer + 45, sizeof(buffer) - 45, " V=3 M=%s", inst->retry_msg);
+				/* E=691 R=d (9) + " C=" (3) + 32 hexits = 44 */
+				snprintf(buffer + 44, sizeof(buffer) - 44, " V=3 M=%s", inst->retry_msg);
 			}
 			mschap_add_reply(request, *response->vp_octets, "MS-CHAP-Error", buffer, strlen(buffer));
 			return RLM_MODULE_REJECT;