freeradius.git
9 years agoCleanup IKEv2 code so it builds again
Arran Cudbard-Bell [Fri, 20 Jun 2014 15:53:44 +0000 (16:53 +0100)]
Cleanup IKEv2 code so it builds again

9 years agoSimilar fix for EAP-MSCHAPV2
Arran Cudbard-Bell [Fri, 20 Jun 2014 11:33:15 +0000 (12:33 +0100)]
Similar fix for EAP-MSCHAPV2

9 years agoSimilar fix for EAP-PWD
Arran Cudbard-Bell [Fri, 20 Jun 2014 11:32:21 +0000 (12:32 +0100)]
Similar fix for EAP-PWD

9 years agoSimilar fix for EAP-TNC
Arran Cudbard-Bell [Fri, 20 Jun 2014 11:32:03 +0000 (12:32 +0100)]
Similar fix for EAP-TNC

9 years agoSimilar fix for EAP-TTLS
Arran Cudbard-Bell [Fri, 20 Jun 2014 11:28:31 +0000 (12:28 +0100)]
Similar fix for EAP-TTLS

9 years agoPEAP tunnel data should be parented by the tls_session not the handler
Arran Cudbard-Bell [Fri, 20 Jun 2014 11:23:32 +0000 (12:23 +0100)]
PEAP tunnel data should be parented by the tls_session not the handler

9 years agoSame fix for EAP-TTLS
Arran Cudbard-Bell [Fri, 20 Jun 2014 11:28:31 +0000 (12:28 +0100)]
Same fix for EAP-TTLS

9 years agoPEAP tunnel data should be parented by the tls_session not the handler
Arran Cudbard-Bell [Fri, 20 Jun 2014 11:23:32 +0000 (12:23 +0100)]
PEAP tunnel data should be parented by the tls_session not the handler

There's no need for explicit free functions

9 years agoFixup talloc destructors
Arran Cudbard-Bell [Fri, 20 Jun 2014 09:14:45 +0000 (10:14 +0100)]
Fixup talloc destructors

9 years agoName destructors correctly, remove unused/useless request_opaque_free destructor
Arran Cudbard-Bell [Fri, 20 Jun 2014 09:03:04 +0000 (10:03 +0100)]
Name destructors correctly, remove unused/useless request_opaque_free destructor

9 years agoAdd function for allocing fr_tls_server_conf_t
Arran Cudbard-Bell [Fri, 20 Jun 2014 08:17:39 +0000 (09:17 +0100)]
Add function for allocing fr_tls_server_conf_t

9 years agoFormatting
Arran Cudbard-Bell [Fri, 20 Jun 2014 08:17:26 +0000 (09:17 +0100)]
Formatting

9 years agoSession serialiser's buffer should not be talloced (alloced and freed in the same...
Arran Cudbard-Bell [Fri, 20 Jun 2014 08:17:15 +0000 (09:17 +0100)]
Session serialiser's buffer should not be talloced (alloced and freed in the same call)

9 years agoFreeing the handler must be synchronised too
Arran Cudbard-Bell [Fri, 20 Jun 2014 08:15:16 +0000 (09:15 +0100)]
Freeing the handler must be synchronised too

9 years agoFormatting
Arran Cudbard-Bell [Fri, 20 Jun 2014 07:41:41 +0000 (08:41 +0100)]
Formatting

9 years agoShould write config value to server_raw first in rlm_couchbase
Arran Cudbard-Bell [Fri, 20 Jun 2014 06:14:51 +0000 (07:14 +0100)]
Should write config value to server_raw first in rlm_couchbase

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Fri, 20 Jun 2014 06:11:39 +0000 (07:11 +0100)]
Update ChangeLog

9 years agoMake client_cert bool everywhere
Arran Cudbard-Bell [Fri, 20 Jun 2014 06:03:16 +0000 (07:03 +0100)]
Make client_cert bool everywhere

9 years agoCan't use "ok = 1" outside of a module call.
Alan T. DeKok [Fri, 20 Jun 2014 02:13:45 +0000 (22:13 -0400)]
Can't use "ok = 1" outside of a module call.

Only modules can have their return codes updated.  Sections can't.

9 years agoAllocate SSL session ctx memory under the handler to avoid thread safety issues
Arran Cudbard-Bell [Thu, 19 Jun 2014 18:24:02 +0000 (19:24 +0100)]
Allocate SSL session ctx memory under the handler to avoid thread safety issues

9 years agoShould always set the pointer to NULL to avoid corner case on malloc failure
Arran Cudbard-Bell [Thu, 19 Jun 2014 15:44:51 +0000 (16:44 +0100)]
Should always set the pointer to NULL to avoid corner case on malloc failure

9 years agoFix invalid assert
Arran Cudbard-Bell [Thu, 19 Jun 2014 12:02:01 +0000 (13:02 +0100)]
Fix invalid assert

9 years agoFix bug where when using a response filter, requests where the response failed the...
Arran Cudbard-Bell [Thu, 19 Jun 2014 10:44:42 +0000 (11:44 +0100)]
Fix bug where when using a response filter, requests where the response failed the filter were still written to the capture file

9 years agoRemove built radtest (accidentally unignored)
Arran Cudbard-Bell [Thu, 19 Jun 2014 10:39:59 +0000 (11:39 +0100)]
Remove built radtest (accidentally unignored)

9 years agoRemoved some obsolete parentheses in TTLS and PEAP modules
Herwin Weststrate [Thu, 19 Jun 2014 08:15:51 +0000 (10:15 +0200)]
Removed some obsolete parentheses in TTLS and PEAP modules

This makes the code a little bit cleaner, but doesn't change any functionality.

9 years agoStub rad_virtual_server for radeapclient
Sam Hartman [Wed, 18 Jun 2014 19:40:05 +0000 (15:40 -0400)]
Stub rad_virtual_server for radeapclient

9 years agoMerge tag 'release_3_0_4_rc1' into tr-upgrade
Sam Hartman [Wed, 18 Jun 2014 19:36:13 +0000 (15:36 -0400)]
Merge tag 'release_3_0_4_rc1' into tr-upgrade

Conflicts:
share/dictionary.freeradius.internal
src/main/listen.c
src/main/realms.c
src/main/tls.c
src/main/tls_listen.c
src/modules/rlm_realm/rlm_realm.c

9 years agoFixed the argument of a talloc_free call
Herwin Weststrate [Wed, 18 Jun 2014 18:47:29 +0000 (20:47 +0200)]
Fixed the argument of a talloc_free call

9 years agoTalloc don't export this macro
Arran Cudbard-Bell [Wed, 18 Jun 2014 17:09:36 +0000 (18:09 +0100)]
Talloc don't export this macro

9 years agoOnly set M_PERTURB if TALLOC_FREE_FILL is unset
Arran Cudbard-Bell [Wed, 18 Jun 2014 16:59:55 +0000 (17:59 +0100)]
Only set M_PERTURB if TALLOC_FREE_FILL is unset

9 years agoDoxygen
Arran Cudbard-Bell [Wed, 18 Jun 2014 13:40:26 +0000 (14:40 +0100)]
Doxygen

9 years agoError out on NULL pointers before doing talloc_get_type_abort in verify functions
Arran Cudbard-Bell [Wed, 18 Jun 2014 13:29:50 +0000 (14:29 +0100)]
Error out on NULL pointers before doing talloc_get_type_abort in verify functions

9 years agoFix VALUE_PAIR parenting in rlm_rest when decoding JSON responses
Arran Cudbard-Bell [Wed, 18 Jun 2014 13:25:44 +0000 (14:25 +0100)]
Fix VALUE_PAIR parenting in rlm_rest when decoding JSON responses

9 years agoFree previous accept VPS. Closes #693
Alan T. DeKok [Wed, 18 Jun 2014 13:09:43 +0000 (09:09 -0400)]
Free previous accept VPS.  Closes #693

9 years agoFix merge error
Arran Cudbard-Bell [Wed, 18 Jun 2014 11:40:13 +0000 (12:40 +0100)]
Fix merge error

9 years agoAlloc from the passed context
Arran Cudbard-Bell [Wed, 18 Jun 2014 11:39:14 +0000 (12:39 +0100)]
Alloc from the passed context

9 years agoParent from the packet, not head of the VP list
Arran Cudbard-Bell [Wed, 18 Jun 2014 11:35:23 +0000 (12:35 +0100)]
Parent from the packet, not head of the VP list

9 years agoParent rbtrees correctly
Arran Cudbard-Bell [Wed, 18 Jun 2014 11:28:35 +0000 (12:28 +0100)]
Parent rbtrees correctly

9 years agoOnly print Talloc chunk lineage if the ctx is not null
Arran Cudbard-Bell [Wed, 18 Jun 2014 11:27:52 +0000 (12:27 +0100)]
Only print Talloc chunk lineage if the ctx is not null

9 years agoHave a suspicion that enabling null context tracking causes talloc functions to SEGV...
Arran Cudbard-Bell [Wed, 18 Jun 2014 11:06:03 +0000 (12:06 +0100)]
Have a suspicion that enabling null context tracking causes talloc functions to SEGV if you pass NULL context pointers

9 years agoFix parenting issues in rlm_file
Arran Cudbard-Bell [Wed, 18 Jun 2014 11:00:10 +0000 (12:00 +0100)]
Fix parenting issues in rlm_file

9 years agoFix/Enhance fr_log_talloc_report
Arran Cudbard-Bell [Wed, 18 Jun 2014 10:35:59 +0000 (11:35 +0100)]
Fix/Enhance fr_log_talloc_report

9 years agoAllow setting the filter code from the request
Arran Cudbard-Bell [Wed, 18 Jun 2014 10:13:23 +0000 (11:13 +0100)]
Allow setting the filter code from the request

9 years agoTypo
Arran Cudbard-Bell [Wed, 18 Jun 2014 07:49:32 +0000 (08:49 +0100)]
Typo

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 17 Jun 2014 23:20:48 +0000 (00:20 +0100)]
Update ChangeLog

9 years agotypo
Arran Cudbard-Bell [Tue, 17 Jun 2014 23:17:58 +0000 (00:17 +0100)]
typo

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Tue, 17 Jun 2014 23:17:21 +0000 (00:17 +0100)]
Update ChangeLog

9 years agoAdd pairdatacpy to fix value parenting issues
Arran Cudbard-Bell [Tue, 17 Jun 2014 22:40:37 +0000 (23:40 +0100)]
Add pairdatacpy to fix value parenting issues

9 years agoMore tweaks for CONSISTENCY CHECK readability
Arran Cudbard-Bell [Tue, 17 Jun 2014 22:23:12 +0000 (23:23 +0100)]
More tweaks for CONSISTENCY CHECK readability

9 years agoBetter checks for DEBUG_PACKET
Alan T. DeKok [Tue, 17 Jun 2014 19:37:09 +0000 (15:37 -0400)]
Better checks for DEBUG_PACKET

9 years agoTypo
Arran Cudbard-Bell [Tue, 17 Jun 2014 19:04:16 +0000 (20:04 +0100)]
Typo

9 years agoProbably want to free the VPs we remove from the control list, oops.
Arran Cudbard-Bell [Tue, 17 Jun 2014 19:00:33 +0000 (20:00 +0100)]
Probably want to free the VPs we remove from the control list, oops.

9 years agoMake CONSISTENCY CHECK messages clearer, add checks for string/octet buffer parenting
Arran Cudbard-Bell [Tue, 17 Jun 2014 18:55:24 +0000 (19:55 +0100)]
Make CONSISTENCY CHECK messages clearer, add checks for string/octet buffer parenting

9 years agoFixed permit_only_eap policy
Herwin Weststrate [Tue, 17 Jun 2014 15:40:07 +0000 (17:40 +0200)]
Fixed permit_only_eap policy

9 years agoUse correct test for debugging
Alan T. DeKok [Tue, 17 Jun 2014 15:27:42 +0000 (11:27 -0400)]
Use correct test for debugging

9 years agoPrint tunneled data in the right place
Alan T. DeKok [Tue, 17 Jun 2014 15:27:21 +0000 (11:27 -0400)]
Print tunneled data in the right place

9 years agoTypo
Arran Cudbard-Bell [Tue, 17 Jun 2014 14:52:22 +0000 (15:52 +0100)]
Typo

9 years agoRemove old text about not proxying CoA. It now works
Alan T. DeKok [Tue, 17 Jun 2014 13:47:06 +0000 (09:47 -0400)]
Remove old text about not proxying CoA.  It now works

9 years agostatus check packets don't have a client. Closes #691
Alan T. DeKok [Tue, 17 Jun 2014 13:40:36 +0000 (09:40 -0400)]
status check packets don't have a client.  Closes #691

9 years agoParent attributes correctly when pulling them out of the TLS session cache
Arran Cudbard-Bell [Tue, 17 Jun 2014 13:35:27 +0000 (14:35 +0100)]
Parent attributes correctly when pulling them out of the TLS session cache

9 years agoAdd newlines to CONSISTENCY CHECK errors
Arran Cudbard-Bell [Tue, 17 Jun 2014 13:27:43 +0000 (14:27 +0100)]
Add newlines to CONSISTENCY CHECK errors

9 years agoPrint file and line number in VERIFY_* messages
Arran Cudbard-Bell [Tue, 17 Jun 2014 12:49:54 +0000 (13:49 +0100)]
Print file and line number in VERIFY_* messages

9 years agoDon't use fr_perror in the verify functions (outputs spurious errors)
Arran Cudbard-Bell [Tue, 17 Jun 2014 12:25:55 +0000 (13:25 +0100)]
Don't use fr_perror in the verify functions (outputs spurious errors)

9 years agoNot sure if talloc_get_name() is legal
Arran Cudbard-Bell [Tue, 17 Jun 2014 12:15:21 +0000 (13:15 +0100)]
Not sure if talloc_get_name() is legal

9 years agoChange ADSL-Agent-Circuit-ID and ADSL-Agent-Remote-ID to octets types as per RFC...
Arran Cudbard-Bell [Tue, 17 Jun 2014 11:19:04 +0000 (12:19 +0100)]
Change ADSL-Agent-Circuit-ID and ADSL-Agent-Remote-ID to octets types as per RFC 4679

9 years agoUse the proper verify_request function instead of talloc_get_type_abort
Arran Cudbard-Bell [Tue, 17 Jun 2014 10:29:44 +0000 (11:29 +0100)]
Use the proper verify_request function instead of talloc_get_type_abort

9 years agoSprinkle VERIFY_REQUEST throughout the state machine
Arran Cudbard-Bell [Tue, 17 Jun 2014 10:26:08 +0000 (11:26 +0100)]
Sprinkle VERIFY_REQUEST throughout the state machine

9 years agoColourise should no be true by default
Arran Cudbard-Bell [Tue, 17 Jun 2014 10:18:18 +0000 (11:18 +0100)]
Colourise should no be true by default

9 years agoMore radclient formatting and minor fixes
Arran Cudbard-Bell [Tue, 17 Jun 2014 09:05:15 +0000 (10:05 +0100)]
More radclient formatting and minor fixes

9 years agoRelax libssl checks
Arran Cudbard-Bell [Tue, 17 Jun 2014 09:04:59 +0000 (10:04 +0100)]
Relax libssl checks

9 years agoMissed break
Arran Cudbard-Bell [Mon, 16 Jun 2014 20:56:21 +0000 (21:56 +0100)]
Missed break

9 years agoMissed type
Arran Cudbard-Bell [Mon, 16 Jun 2014 17:58:30 +0000 (18:58 +0100)]
Missed type

9 years agoshow encoded packet before TLS encryption
Alan T. DeKok [Sat, 14 Jun 2014 14:53:00 +0000 (10:53 -0400)]
show encoded packet before TLS encryption

9 years agoFix indent
Arran Cudbard-Bell [Mon, 16 Jun 2014 14:39:44 +0000 (15:39 +0100)]
Fix indent

9 years agoUse sane macro names for codes. PW_CODE_AUTHENTICATION_ACK, PW_CODE_AUTHENTICATION_RE...
Arran Cudbard-Bell [Mon, 16 Jun 2014 14:37:22 +0000 (15:37 +0100)]
Use sane macro names for codes. PW_CODE_AUTHENTICATION_ACK, PW_CODE_AUTHENTICATION_REJECT? Really?

9 years agoTry harder in radclient to figure out request/response codes and ports from informati...
Arran Cudbard-Bell [Mon, 16 Jun 2014 14:35:00 +0000 (15:35 +0100)]
Try harder in radclient to figure out request/response codes and ports from information we were provided with

9 years agoGah, double negatives
Arran Cudbard-Bell [Mon, 16 Jun 2014 13:19:30 +0000 (14:19 +0100)]
Gah, double negatives

9 years agoFix for backtrace deadlock and GLIBC
Arran Cudbard-Bell [Mon, 16 Jun 2014 11:55:25 +0000 (12:55 +0100)]
Fix for backtrace deadlock and GLIBC

9 years agoBetter ldap version fixes
Arran Cudbard-Bell [Sun, 15 Jun 2014 07:31:51 +0000 (08:31 +0100)]
Better ldap version fixes

9 years agoPrint error if we can't get libldap version
Arran Cudbard-Bell [Sat, 14 Jun 2014 21:02:38 +0000 (22:02 +0100)]
Print error if we can't get libldap version

9 years agoAdd more version checks for modules
Arran Cudbard-Bell [Sat, 14 Jun 2014 20:37:05 +0000 (21:37 +0100)]
Add more version checks for modules

9 years agoWhat's a Boyan?
Arran Cudbard-Bell [Sat, 14 Jun 2014 13:16:03 +0000 (14:16 +0100)]
What's a Boyan?

9 years agosizeof(array_arg) doesn't work as expected so use digest length macros
Arran Cudbard-Bell [Fri, 13 Jun 2014 16:47:08 +0000 (17:47 +0100)]
sizeof(array_arg) doesn't work as expected so use digest length macros

9 years agoFix fall-through behaviour in rlm_sql Closes #622
Arran Cudbard-Bell [Fri, 13 Jun 2014 18:28:53 +0000 (19:28 +0100)]
Fix fall-through behaviour in rlm_sql Closes #622

9 years agoWhitespace
Alan T. DeKok [Fri, 13 Jun 2014 19:36:05 +0000 (15:36 -0400)]
Whitespace

9 years agoAs found in a PPT by Klass Wierenga
Alan T. DeKok [Fri, 13 Jun 2014 19:14:59 +0000 (15:14 -0400)]
As found in a PPT by Klass Wierenga

9 years agoNote correct names for data types
Alan T. DeKok [Fri, 13 Jun 2014 19:14:46 +0000 (15:14 -0400)]
Note correct names for data types

9 years agoDeclare more things as arrays
Arran Cudbard-Bell [Fri, 13 Jun 2014 16:57:16 +0000 (17:57 +0100)]
Declare more things as arrays

9 years agoDeclare hextab as an array
Arran Cudbard-Bell [Fri, 13 Jun 2014 16:52:21 +0000 (17:52 +0100)]
Declare hextab as an array

9 years agoMerge pull request #688 from philmayers/fix-nthash
Arran Cudbard-Bell [Fri, 13 Jun 2014 16:05:12 +0000 (17:05 +0100)]
Merge pull request #688 from philmayers/fix-nthash

pass length of nthashhash as argument

9 years agopass length of nthashhash as argument, since sizeof() does not work on array arguments
Phil Mayers [Fri, 13 Jun 2014 15:54:01 +0000 (16:54 +0100)]
pass length of nthashhash as argument, since sizeof() does not work on array arguments

9 years agoThe fewer magic numbers the better...
Arran Cudbard-Bell [Fri, 13 Jun 2014 15:37:54 +0000 (16:37 +0100)]
The fewer magic numbers the better...

9 years agoBetter debug output from rlm_mschap
Arran Cudbard-Bell [Fri, 13 Jun 2014 15:37:24 +0000 (16:37 +0100)]
Better debug output from rlm_mschap

9 years agoExtraneous comma
Arran Cudbard-Bell [Fri, 13 Jun 2014 14:07:17 +0000 (15:07 +0100)]
Extraneous comma

9 years agoReplaced references to MS-CHAP-Success with MS2-CHAP-Success
Herwin Weststrate [Wed, 11 Jun 2014 14:45:14 +0000 (16:45 +0200)]
Replaced references to MS-CHAP-Success with MS2-CHAP-Success

The first attribute doesn't exist.

9 years agoReintroduced a comma to make sentence readable
Herwin Weststrate [Mon, 2 Jun 2014 09:06:59 +0000 (11:06 +0200)]
Reintroduced a comma to make sentence readable

Accidentally removed in 8430d8fa618140bafe289142626061fdc5419d58

9 years agoFixed some capitalization in mods-available/eap
Herwin Weststrate [Fri, 30 May 2014 08:13:05 +0000 (10:13 +0200)]
Fixed some capitalization in mods-available/eap

9 years agoFixed some whitespace in mods-available/eap
Herwin Weststrate [Fri, 30 May 2014 08:10:14 +0000 (10:10 +0200)]
Fixed some whitespace in mods-available/eap

Make consistently use of tabs, instead of mostly tabs and sometimes spaces.

9 years agoFix and document check_timeout which helps with check_interval
Alan T. DeKok [Fri, 13 Jun 2014 13:37:22 +0000 (09:37 -0400)]
Fix and document check_timeout which helps with check_interval

9 years agoRemove re-defined attributes
Alan T. DeKok [Fri, 13 Jun 2014 12:44:31 +0000 (08:44 -0400)]
Remove re-defined attributes