freeradius.git
8 years agodon't segfault when asked for help
Matthew Newton [Thu, 17 Sep 2015 23:36:41 +0000 (00:36 +0100)]
don't segfault when asked for help

print the help for the current command if there are no subcommands
to list

8 years agoMerge pull request #1245 from jpereira/debian/logrotate1
Arran Cudbard-Bell [Thu, 17 Sep 2015 17:56:35 +0000 (18:56 +0100)]
Merge pull request #1245 from jpereira/debian/logrotate1

Fix logrotate debian

8 years agoFix logrotate debian
Jorge Pereira [Thu, 17 Sep 2015 17:29:45 +0000 (14:29 -0300)]
Fix logrotate debian

8 years agoNo breaking changes in stable versions
Arran Cudbard-Bell [Thu, 17 Sep 2015 16:51:11 +0000 (17:51 +0100)]
No breaking changes in stable versions

8 years agoRevert "if try to load a wrong client from SQL, don't start"
Arran Cudbard-Bell [Thu, 17 Sep 2015 16:50:02 +0000 (17:50 +0100)]
Revert "if try to load a wrong client from SQL, don't start"

This is wrong, we don't introduce behaviour changes that will break people's deployments in stable versions of the server

8 years agoRevert "logrotate: send a HUP after rotation"
Arran Cudbard-Bell [Thu, 17 Sep 2015 16:49:22 +0000 (17:49 +0100)]
Revert "logrotate: send a HUP after rotation"

This is wrong, copyrotate is the correct command to use

8 years agonote recent changes
Alan T. DeKok [Thu, 17 Sep 2015 15:02:50 +0000 (11:02 -0400)]
note recent changes

8 years agoMerge pull request #1243 from jpereira/bug/debian-logrotate
Alan DeKok [Thu, 17 Sep 2015 15:02:35 +0000 (11:02 -0400)]
Merge pull request #1243 from jpereira/bug/debian-logrotate

debian: Fixing logrotate script

8 years agodebian: Fixing logrotate script
Jorge Pereira [Thu, 17 Sep 2015 14:27:21 +0000 (11:27 -0300)]
debian: Fixing logrotate script

8 years agologrotate: send a HUP after rotation
Jorge Pereira [Thu, 17 Sep 2015 14:19:59 +0000 (11:19 -0300)]
logrotate: send a HUP after rotation

8 years agoMore RFCs
Alan T. DeKok [Thu, 17 Sep 2015 14:17:01 +0000 (10:17 -0400)]
More RFCs

8 years agoMerge pull request #1242 from jpereira/fix/wrong-client-sql
Alan DeKok [Thu, 17 Sep 2015 13:09:07 +0000 (09:09 -0400)]
Merge pull request #1242 from jpereira/fix/wrong-client-sql

if has a wrong client-settings, don't rise!

8 years agoif try to load a wrong client from SQL, don't start
Jorge Pereira [Thu, 17 Sep 2015 12:45:47 +0000 (09:45 -0300)]
if try to load a wrong client from SQL, don't start

8 years agoAccidentally committed
Alan T. DeKok [Wed, 16 Sep 2015 19:17:34 +0000 (15:17 -0400)]
Accidentally committed

8 years agonote recent changes
Alan T. DeKok [Wed, 16 Sep 2015 18:09:09 +0000 (14:09 -0400)]
note recent changes

8 years agoMerge pull request #1241 from jpereira/fix/xlat-space
Alan DeKok [Wed, 16 Sep 2015 18:36:14 +0000 (14:36 -0400)]
Merge pull request #1241 from jpereira/fix/xlat-space

xlat_explode: trim white space

8 years agoxlat_explode: trim white space
Jorge Pereira [Wed, 16 Sep 2015 18:06:48 +0000 (15:06 -0300)]
xlat_explode: trim white space

8 years agonote recent changes
Alan T. DeKok [Wed, 16 Sep 2015 17:15:40 +0000 (13:15 -0400)]
note recent changes

8 years agoAllow virtual attrs in switch. Fixes #1240
Alan T. DeKok [Wed, 16 Sep 2015 17:15:00 +0000 (13:15 -0400)]
Allow virtual attrs in switch.  Fixes #1240

8 years agoForgot a return...
Alan T. DeKok [Wed, 16 Sep 2015 17:07:09 +0000 (13:07 -0400)]
Forgot a return...

8 years agoBe a bit more careful about thread transitions
Alan T. DeKok [Wed, 16 Sep 2015 16:47:37 +0000 (12:47 -0400)]
Be a bit more careful about thread transitions

8 years agonote recent changes
Alan T. DeKok [Wed, 16 Sep 2015 00:58:46 +0000 (20:58 -0400)]
note recent changes

8 years agoProxying to a bad destination is a failure.
Alan T. DeKok [Wed, 16 Sep 2015 00:54:38 +0000 (20:54 -0400)]
Proxying to a bad destination is a failure.

8 years agoMissed slash
Arran Cudbard-Bell [Tue, 15 Sep 2015 21:04:26 +0000 (22:04 +0100)]
Missed slash

8 years agoRemove extraneous debug
Alan T. DeKok [Tue, 15 Sep 2015 16:01:17 +0000 (12:01 -0400)]
Remove extraneous debug

8 years agoPackage memcached
Arran Cudbard-Bell [Tue, 15 Sep 2015 14:06:43 +0000 (15:06 +0100)]
Package memcached

8 years agoRevert "Include rlm_cache_memcached in spec file"
Arran Cudbard-Bell [Tue, 15 Sep 2015 13:53:52 +0000 (14:53 +0100)]
Revert "Include rlm_cache_memcached in spec file"

libmemcached on Centos is too old for this to work

8 years agoDocument and fix args
Arran Cudbard-Bell [Tue, 15 Sep 2015 13:43:56 +0000 (14:43 +0100)]
Document and fix args

8 years agoAllow dots in policy / module names. Fixes #1237
Alan T. DeKok [Tue, 15 Sep 2015 13:22:38 +0000 (09:22 -0400)]
Allow dots in policy / module names.  Fixes #1237

8 years agoLower the default pool size
Alan T. DeKok [Tue, 15 Sep 2015 13:09:37 +0000 (09:09 -0400)]
Lower the default pool size

8 years agoInclude rlm_cache_memcached in spec file
Arran Cudbard-Bell [Mon, 14 Sep 2015 20:32:52 +0000 (21:32 +0100)]
Include rlm_cache_memcached in spec file

8 years agoMerge pull request #1235 from FreeRADIUS/revert-1204-patch-1
Arran Cudbard-Bell [Mon, 14 Sep 2015 20:29:50 +0000 (21:29 +0100)]
Merge pull request #1235 from FreeRADIUS/revert-1204-patch-1

Revert "Fix libs" - Only memcached will actually be built

8 years agoRevert "Fix libs"
Arran Cudbard-Bell [Mon, 14 Sep 2015 20:29:20 +0000 (21:29 +0100)]
Revert "Fix libs"

8 years agoThis was never backported
Arran Cudbard-Bell [Mon, 14 Sep 2015 17:27:36 +0000 (18:27 +0100)]
This was never backported

8 years agoUpdate ChangeLog
Arran Cudbard-Bell [Mon, 14 Sep 2015 17:20:03 +0000 (18:20 +0100)]
Update ChangeLog

8 years agoNo ocsp_ok label either
Arran Cudbard-Bell [Mon, 14 Sep 2015 16:22:56 +0000 (17:22 +0100)]
No ocsp_ok label either

8 years agoNo skipped label in v3.0.x
Arran Cudbard-Bell [Mon, 14 Sep 2015 16:21:21 +0000 (17:21 +0100)]
No skipped label in v3.0.x

8 years agoTry to open client socket in fr_server_domain_socket_perm()
Alan T. DeKok [Mon, 14 Sep 2015 16:02:37 +0000 (12:02 -0400)]
Try to open client socket in fr_server_domain_socket_perm()

Just like in fr_server_domain_socket_peercred()

8 years agoShould skip the OCSP check
Arran Cudbard-Bell [Mon, 14 Sep 2015 16:18:02 +0000 (17:18 +0100)]
Should skip the OCSP check

8 years agoTypo
Arran Cudbard-Bell [Mon, 14 Sep 2015 16:13:41 +0000 (17:13 +0100)]
Typo

8 years agoDon't unlink socket if we can't open it
Alan T. DeKok [Mon, 14 Sep 2015 15:48:10 +0000 (11:48 -0400)]
Don't unlink socket if we can't open it

8 years agoTruncate to actual length, not by trailing zeros
Alan T. DeKok [Mon, 14 Sep 2015 14:48:08 +0000 (10:48 -0400)]
Truncate to actual length, not by trailing zeros

8 years agoIf there's no OCSP URLs in the certificates, and we have a configured OCSP URL, we...
Arran Cudbard-Bell [Sun, 13 Sep 2015 17:43:23 +0000 (18:43 +0100)]
If there's no OCSP URLs in the certificates, and we have a configured OCSP URL, we should fall back to that URL

8 years agoFor encrypted attributes, set explicit length if given
Alan T. DeKok [Mon, 14 Sep 2015 12:51:09 +0000 (08:51 -0400)]
For encrypted attributes, set explicit length if given

for MS-CHAP-MPPE-Keys

8 years agoSet explicit length for MS-CHAP-MPPE-Key
Alan T. DeKok [Mon, 14 Sep 2015 12:50:00 +0000 (08:50 -0400)]
Set explicit length for MS-CHAP-MPPE-Key

Because it's encrypted with the same method as User-Password,
BUT it contains binary data.  So it may have embedded zeros.
Which means the decoder needs to make it a fixed length,
instead of looking for zeros

8 years agoEnforce more restraints, and allow "octets[24] encrypt=1"
Alan T. DeKok [Mon, 14 Sep 2015 12:47:56 +0000 (08:47 -0400)]
Enforce more restraints, and allow "octets[24] encrypt=1"

dict_addattr() can be called from places other than process_attribute()
so we move some of the checks to process_attribute()

This lets us do more checks on the "length" flag.

And to allow "octets[24] encrypt=1" for MS-CHAP-MPPE-Key.

8 years agoThe MS-CHAP-MPPE-Keys attribute has 24 octets of data, not 32
Alan T. DeKok [Mon, 14 Sep 2015 12:21:40 +0000 (08:21 -0400)]
The MS-CHAP-MPPE-Keys attribute has 24 octets of data, not 32

This makes no difference to anyone, as the receiver will always
truncate it at 24 octets, and ignore the trailing zeros

8 years agoupdate explanation of what we're doing
Alan T. DeKok [Sun, 13 Sep 2015 14:30:32 +0000 (10:30 -0400)]
update explanation of what we're doing

8 years agoMore debugging around session-state
Alan T. DeKok [Sun, 13 Sep 2015 14:30:11 +0000 (10:30 -0400)]
More debugging around session-state

8 years agoUpdate ChangeLog
Arran Cudbard-Bell [Sat, 12 Sep 2015 19:07:45 +0000 (20:07 +0100)]
Update ChangeLog

8 years agonote recent changes
Alan T. DeKok [Sat, 12 Sep 2015 01:58:42 +0000 (21:58 -0400)]
note recent changes

8 years agoMerge pull request #1231 from mcnewton/v3.0.x
Arran Cudbard-Bell [Fri, 11 Sep 2015 22:11:05 +0000 (23:11 +0100)]
Merge pull request #1231 from mcnewton/v3.0.x

small documentation fix/cleanups [ci skip]

8 years agosmall documentation fix/cleanups
Matthew Newton [Fri, 11 Sep 2015 22:07:27 +0000 (23:07 +0100)]
small documentation fix/cleanups

8 years agoNo need for if
Arran Cudbard-Bell [Fri, 11 Sep 2015 17:04:31 +0000 (18:04 +0100)]
No need for if

Confusing because the rest of the frees don't use a condition

8 years agoDoxygen
Alan T. DeKok [Fri, 11 Sep 2015 16:52:32 +0000 (12:52 -0400)]
Doxygen

8 years agoDon't leak client_fd on error
Arran Cudbard-Bell [Fri, 11 Sep 2015 16:18:58 +0000 (17:18 +0100)]
Don't leak client_fd on error

8 years agoFormatting
Arran Cudbard-Bell [Fri, 11 Sep 2015 16:17:30 +0000 (17:17 +0100)]
Formatting

8 years agoUse fr_pair_list_mcopy... instead of fr_pair_list_move...
Alan T. DeKok [Fri, 11 Sep 2015 16:16:53 +0000 (12:16 -0400)]
Use fr_pair_list_mcopy... instead of fr_pair_list_move...

8 years agoAdd fr_pair_list_mcopy_by_num()
Alan T. DeKok [Fri, 11 Sep 2015 16:10:35 +0000 (12:10 -0400)]
Add fr_pair_list_mcopy_by_num()

Which is like fr_pair_list_move(), but does copy / delete
instead of talloc_steal.

The problem is that talloc_steal() keeps the original parent
context around for the lifetime of the VP being stolen.  Which is
bad when the VP comes from a REQUEST, and is put into another
context, which lives for multiple seconds.

8 years agoRevert "Copy VPs instead of talloc_stealing them"
Alan T. DeKok [Fri, 11 Sep 2015 16:09:39 +0000 (12:09 -0400)]
Revert "Copy VPs instead of talloc_stealing them"

This reverts commit a529c2d9bdef0f635fa10b2ab7e05527f95551b2.

There's a better fix

8 years agoCopy VPs instead of talloc_stealing them
Alan T. DeKok [Fri, 11 Sep 2015 15:56:46 +0000 (11:56 -0400)]
Copy VPs instead of talloc_stealing them

8 years agoCheck if the socket is in use before unlinking it
Alan T. DeKok [Fri, 11 Sep 2015 14:33:17 +0000 (10:33 -0400)]
Check if the socket is in use before unlinking it

8 years agoAdd __packed__ to structs which cast over packet buffers
Arran Cudbard-Bell [Fri, 11 Sep 2015 14:13:03 +0000 (15:13 +0100)]
Add __packed__ to structs which cast over packet buffers

8 years agonote recent changes
Alan T. DeKok [Fri, 11 Sep 2015 13:39:29 +0000 (09:39 -0400)]
note recent changes

8 years agoSyntax errors are errors, not assertions
Alan T. DeKok [Fri, 11 Sep 2015 13:18:33 +0000 (09:18 -0400)]
Syntax errors are errors, not assertions

8 years agoShould be AF_UNSPEC, because we don't *know* what type of client IP we'll be parsing
Arran Cudbard-Bell [Fri, 11 Sep 2015 12:58:26 +0000 (13:58 +0100)]
Should be AF_UNSPEC, because we don't *know* what type of client IP we'll be parsing

Length should be -1.

8 years agoRemove second entry of Error-Cause in Access-Reject filter
Herwin Weststrate [Fri, 11 Sep 2015 06:06:10 +0000 (08:06 +0200)]
Remove second entry of Error-Cause in Access-Reject filter

This is effectively a revert of commit caaca8da2eede537270a711742cc99f0ba854eb1.

8 years agoAdd support for "old" style clients back. This shouldn't be removed until v3.1.x.
Arran Cudbard-Bell [Fri, 11 Sep 2015 12:10:12 +0000 (13:10 +0100)]
Add support for "old" style clients back.  This shouldn't be removed until v3.1.x.

8 years agoPrevent possible memleak in regex
Herwin Weststrate [Fri, 11 Sep 2015 07:28:39 +0000 (09:28 +0200)]
Prevent possible memleak in regex

There was a very small chance that preg was allocated but not freed. This is kind of a sequel to PR #1207.

8 years agoOptionally send rejects without a delay
Herwin Weststrate [Wed, 9 Sep 2015 13:12:20 +0000 (15:12 +0200)]
Optionally send rejects without a delay

Currently there is only one global option to set a delay to every Access-Reject packet: reject_delay. There are use cases where you want certain rejects to have no delay, while others should have a delay. An example might be using 802.1X on Cisco LAN Devices: If a client tries MAC authentication an Access-Reject can force it to switch to 802.1X, this is a reject you want to send without any delay. On the other hand, if the client tries 802.1X with a wrong password, you still want the reject to be delayed.

By setting a value to FreeRADIUS-Response-Delay(-USec) in reply, we overwrite the global delay. The maximum supported value is 10, larger values result in a delay of 10 seconds. A value of 0 removes the delay. Not having this attribute in control results in using the global delay. If both FreeRADIUS-Response-Delay and FreeRADIUS-Response-Delay-USec are set, the second one is ignored.

8 years agoAllow response_delay to be microseconds, too
Herwin Weststrate [Thu, 10 Sep 2015 05:50:01 +0000 (07:50 +0200)]
Allow response_delay to be microseconds, too

This was already done with commit 1d1c50bb0c6f5f013b9680def4b7184ecb63f64b, but there was a second assertion that assumed the delay was at least 1 second.

8 years agoUpdate radiusd-example.txt
Alan Buxey [Thu, 10 Sep 2015 19:26:28 +0000 (20:26 +0100)]
Update radiusd-example.txt

8 years agoUpdate xlat.c
Alan Buxey [Thu, 10 Sep 2015 19:25:27 +0000 (20:25 +0100)]
Update xlat.c

8 years agoUpdate rlm_sqlippool
Alan Buxey [Thu, 10 Sep 2015 19:24:30 +0000 (20:24 +0100)]
Update rlm_sqlippool

8 years agoUpdate vmpsd.conf.in
Alan Buxey [Thu, 10 Sep 2015 19:24:07 +0000 (20:24 +0100)]
Update vmpsd.conf.in

8 years agoUpdate expr
Alan Buxey [Thu, 10 Sep 2015 09:15:34 +0000 (10:15 +0100)]
Update expr

8 years agoCheck we're building with GLIBC before assuming the GNU version of strerror_r is...
Arran Cudbard-Bell [Thu, 10 Sep 2015 08:46:15 +0000 (09:46 +0100)]
Check we're building with GLIBC before assuming the GNU version of strerror_r is present Closes #1222

8 years agoUpdate radiusd-example.txt
Alan Buxey [Wed, 9 Sep 2015 19:42:01 +0000 (20:42 +0100)]
Update radiusd-example.txt

8 years agoUpdate xlat.c
Alan Buxey [Wed, 9 Sep 2015 19:40:55 +0000 (20:40 +0100)]
Update xlat.c

8 years agoUpdate vmpsd.conf.in
Alan Buxey [Wed, 9 Sep 2015 19:39:46 +0000 (20:39 +0100)]
Update vmpsd.conf.in

8 years agoUpdate rlm_sqlippool
Alan Buxey [Wed, 9 Sep 2015 19:37:42 +0000 (20:37 +0100)]
Update rlm_sqlippool

8 years agocompile warnings
Alan T. DeKok [Wed, 9 Sep 2015 19:42:44 +0000 (15:42 -0400)]
compile warnings

8 years agoDon't allow %{rand} is we require %{rand:...}
Alan T. DeKok [Wed, 9 Sep 2015 19:16:28 +0000 (15:16 -0400)]
Don't allow %{rand} is we require %{rand:...}

8 years agoCount backslash - CHAR in node->len
Alan T. DeKok [Wed, 9 Sep 2015 17:40:31 +0000 (13:40 -0400)]
Count backslash - CHAR in node->len

8 years agoTypo
Alan T. DeKok [Wed, 9 Sep 2015 17:26:55 +0000 (13:26 -0400)]
Typo

8 years agoMerge pull request #1218 from mcnewton/v3.0.x
Arran Cudbard-Bell [Wed, 9 Sep 2015 16:20:46 +0000 (17:20 +0100)]
Merge pull request #1218 from mcnewton/v3.0.x

minor doc tweak from file move

8 years agominor doc tweak from file move
Matthew Newton [Wed, 9 Sep 2015 16:17:12 +0000 (17:17 +0100)]
minor doc tweak from file move

8 years agoMerge pull request #1217 from mcnewton/v3.0.x
Arran Cudbard-Bell [Wed, 9 Sep 2015 14:50:35 +0000 (15:50 +0100)]
Merge pull request #1217 from mcnewton/v3.0.x

add documentation for xlats in the expr module

8 years agoadd documentation for xlats in the expr module
Matthew Newton [Wed, 9 Sep 2015 14:47:30 +0000 (15:47 +0100)]
add documentation for xlats in the expr module

8 years agoAllow response delay in the response
Alan T. DeKok [Wed, 9 Sep 2015 14:32:12 +0000 (10:32 -0400)]
Allow response delay in the response

8 years agoAllow response_delay to be microseconds, too
Alan T. DeKok [Wed, 9 Sep 2015 14:16:20 +0000 (10:16 -0400)]
Allow response_delay to be microseconds, too

8 years agoifdef out unused functions
Alan T. DeKok [Wed, 9 Sep 2015 13:34:01 +0000 (09:34 -0400)]
ifdef out unused functions

8 years agotypo
Alan T. DeKok [Wed, 9 Sep 2015 13:21:55 +0000 (09:21 -0400)]
typo

8 years agoMore fixes to use SSL_export_keying_material
Alan T. DeKok [Wed, 9 Sep 2015 13:18:50 +0000 (09:18 -0400)]
More fixes to use SSL_export_keying_material

8 years agopacket->proto is int, not unsigned int
Alan T. DeKok [Tue, 8 Sep 2015 17:45:32 +0000 (13:45 -0400)]
packet->proto is int, not unsigned int

8 years agonote recent changes
Alan T. DeKok [Tue, 8 Sep 2015 17:30:03 +0000 (13:30 -0400)]
note recent changes

8 years agoParse hex Ascend-Data-Filter correctly
Alan T. DeKok [Tue, 8 Sep 2015 14:15:34 +0000 (10:15 -0400)]
Parse hex Ascend-Data-Filter correctly

8 years agoUse the input length for printing, not output length
Alan T. DeKok [Tue, 8 Sep 2015 14:13:58 +0000 (10:13 -0400)]
Use the input length for printing, not output length

8 years agotypos
Alan T. DeKok [Mon, 7 Sep 2015 00:44:24 +0000 (20:44 -0400)]
typos

8 years agoDebug TLVs when encoding, too
Alan T. DeKok [Sun, 6 Sep 2015 18:52:52 +0000 (14:52 -0400)]
Debug TLVs when encoding, too