From 26be8a680d2a6830e7be98bee10818dd8b6a426a Mon Sep 17 00:00:00 2001 From: "Alan T. DeKok" Date: Mon, 3 Jul 2017 12:35:45 -0400 Subject: [PATCH] FR-GV-207 - avoid zero-length malloc() in data2vp() --- src/lib/radius.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lib/radius.c b/src/lib/radius.c index ade05c5..7fdc863 100644 --- a/src/lib/radius.c +++ b/src/lib/radius.c @@ -2444,13 +2444,15 @@ static VALUE_PAIR *data2vp(const RADIUS_PACKET *packet, case PW_TYPE_TLV: vp->length = length; - vp->vp_tlv = malloc(length); + + vp->vp_tlv = malloc(length ? length : 1); if (!vp->vp_tlv) { pairfree(&vp); fr_strerror_printf("No memory"); return NULL; } - memcpy(vp->vp_tlv, data, length); + + if (length) memcpy(vp->vp_tlv, data, length); break; case PW_TYPE_COMBO_IP: -- 2.1.4