From: Linus Nordberg <linus@nordberg.se>
Date: Thu, 9 May 2013 06:59:00 +0000 (+0200)
Subject: Use malloc+memcpy rather than calloc+strcpy in rs_strdup.
X-Git-Tag: libradsec-0.0.4~19
X-Git-Url: http://www.project-moonshot.org/gitweb/?p=libradsec.git;a=commitdiff_plain;h=65a9a8786d5507e7f150567e4effd6e7409ac92c

Use malloc+memcpy rather than calloc+strcpy in rs_strdup.

For effiency (but triggered by calloc needing unistd.h on Darwin).
---

diff --git a/lib/util.c b/lib/util.c
index eceaec9..1142afa 100644
--- a/lib/util.c
+++ b/lib/util.c
@@ -1,4 +1,4 @@
-/* Copyright 2012 NORDUnet A/S. All rights reserved.
+/* Copyright 2012,2013 NORDUnet A/S. All rights reserved.
    See LICENSE for licensing information.  */
 
 #include <string.h>
@@ -9,11 +9,16 @@
 char *
 rs_strdup (struct rs_context *ctx, const char *s)
 {
-  char *buf = rs_calloc (ctx, 1, strlen (s) + 1);
+  size_t len;
+  char *buf;
+
+  len = strlen (s);
+  buf = rs_malloc (ctx, len + 1);
 
   if (buf != NULL)
-    return strcpy (buf, s);
+    memcpy (buf, s, len + 1);
+  else
+    rs_err_ctx_push (ctx, RSE_NOMEM, __func__);
 
-  rs_err_ctx_push (ctx, RSE_NOMEM, NULL);
-  return NULL;
+  return buf;
 }