cleanup unused parameter warnings

[mech_eap.git] / display_status.c

diff --git a/display_status.c b/display_status.c
index 3194ae3..8729a96 100644 (file)
--- a/display_status.c
+++ b/display_status.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010, JANET(UK)
+ * Copyright (c) 2011, JANET(UK)
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -30,6 +30,10 @@
  * SUCH DAMAGE.
  */
 
+/*
+ * Function for converting mechanism error codes to strings.
+ */
+
 #include "gssapiP_eap.h"
 
 static GSSEAP_THREAD_ONCE gssEapStatusInfoKeyOnce = GSSEAP_ONCE_INITIALIZER;
@@ -59,6 +63,13 @@ createStatusInfoKey(void)
     GSSEAP_KEY_CREATE(&gssEapStatusInfoKey, destroyStatusInfo);
 }
 
+/*
+ * Associate a message with a mechanism (minor) status code. This function
+ * takes ownership of the message regardless of success. The message must
+ * be explicitly cleared, if required, so it is suggested that a specific
+ * minor code is either always or never associated with a message, to avoid
+ * dangling (and potentially confusing) error messages.
+ */
 static void
 saveStatusInfoNoCopy(OM_uint32 minor, char *message)
 {
@@ -69,7 +80,9 @@ saveStatusInfoNoCopy(OM_uint32 minor, char *message)
     p = GSSEAP_GETSPECIFIC(gssEapStatusInfoKey);
     for (; p != NULL; p = p->next) {
         if (p->code == minor) {
-            GSSEAP_FREE(p->message);
+            /* Set message in-place */
+            if (p->message != NULL)
+                GSSEAP_FREE(p->message);
             p->message = message;
             return;
         }
@@ -78,14 +91,15 @@ saveStatusInfoNoCopy(OM_uint32 minor, char *message)
 
     p = GSSEAP_CALLOC(1, sizeof(*p));
     if (p == NULL) {
-        GSSEAP_FREE(message);
+        if (message != NULL)
+            GSSEAP_FREE(message);
         return;
     }
 
     p->code = minor;
     p->message = message;
 
-    if (p != NULL)
+    if (next != NULL)
         *next = p;
     else
         GSSEAP_SETSPECIFIC(gssEapStatusInfoKey, p);
@@ -131,7 +145,7 @@ gss_display_status(OM_uint32 *minor,
                    OM_uint32 *message_context,
                    gss_buffer_t status_string)
 {
-    OM_uint32 major = GSS_S_COMPLETE;
+    OM_uint32 major;
     krb5_context krbContext = NULL;
     const char *errMsg;
 
@@ -139,11 +153,14 @@ gss_display_status(OM_uint32 *minor,
     status_string->value = NULL;
 
     if (!gssEapIsMechanismOid(mech_type)) {
+        *minor = GSSEAP_WRONG_MECH;
         return GSS_S_BAD_MECH;
     }
 
-    if (status_type != GSS_C_MECH_CODE) {
+    if (status_type != GSS_C_MECH_CODE ||
+        *message_context != 0) {
         /* we rely on the mechglue for GSS_C_GSS_CODE */
+        *minor = 0;
         return GSS_S_BAD_STATUS;
     }
 
@@ -151,11 +168,16 @@ gss_display_status(OM_uint32 *minor,
     if (errMsg == NULL) {
         GSSEAP_KRB_INIT(&krbContext);
 
+        /* Try the com_err message */
         errMsg = krb5_get_error_message(krbContext, status_value);
     }
 
-    if (errMsg != NULL)
+    if (errMsg != NULL) {
         major = makeStringBuffer(minor, errMsg, status_string);
+    } else {
+        major = GSS_S_COMPLETE;
+        *minor = 0;
+    }
 
     if (krbContext != NULL)
         krb5_free_error_message(krbContext, errMsg);