Revert "nl80211: Remove duplicated check in nl80211_setup_ap()"
authorRafał Miłecki <rafal@milecki.pl>
Mon, 12 Sep 2016 17:28:22 +0000 (19:28 +0200)
committerJouni Malinen <j@w1.fi>
Sat, 17 Sep 2016 17:08:24 +0000 (20:08 +0300)
commitea19b39f60b60494e17171aae5556cca2addff47
tree47081be29e571745166cdf35b66323046ed0d90e
parent205d2d1ff5f224e21634e25fe2decc911fb1be45
Revert "nl80211: Remove duplicated check in nl80211_setup_ap()"

This reverts commit 647862eb60c324015ea31293cc052558b5185ca4.

The second check of device_ap_sme looks like duplicated, but it isn't
actually. The trick is nl80211_create_monitor_interface may change that
variable value and the second evaluation may give a different result.

This definitely isn't a very clear code, but that change caused a
regression for drivers that:
1) Don't report NL80211_ATTR_DEVICE_AP_SME
2) Don't support monitor mode
3) Don't support subscribing for PROBE_REQ and/or ACTION frames
like brcmfmac. With such drivers hostapd doesn't start anymore.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
src/drivers/driver_nl80211.c