Remove unused generation of Request Authenticator in Account-Request
authorNick Lowe <nick.lowe@lugatech.com>
Sun, 14 Aug 2016 14:40:11 +0000 (15:40 +0100)
committerJouni Malinen <j@w1.fi>
Wed, 21 Sep 2016 21:34:19 +0000 (00:34 +0300)
Do not generate an unused and invalid Request Authenticator (random
value) when constructing Accounting-Request packets. The correct Request
Authenticator is calculated subsequently in radius_msg_finish_acct()
using MD5(msg + shared secret).

Signed-off-by: Nick Lowe <nick.lowe@lugatech.com>
src/ap/accounting.c

index 854174e..0aacc3c 100644 (file)
@@ -50,11 +50,6 @@ static struct radius_msg * accounting_msg(struct hostapd_data *hapd,
                return NULL;
        }
 
-       if (radius_msg_make_authenticator(msg) < 0) {
-               wpa_printf(MSG_INFO, "Could not make Request Authenticator");
-               goto fail;
-       }
-
        if (!radius_msg_add_attr_int32(msg, RADIUS_ATTR_ACCT_STATUS_TYPE,
                                       status_type)) {
                wpa_printf(MSG_INFO, "Could not add Acct-Status-Type");