From: Luke Howard <lukeh@padl.com>
Date: Fri, 17 Sep 2010 10:41:54 +0000 (+0200)
Subject: cleanup, notes on composite names
X-Git-Tag: vm/20110310~309
X-Git-Url: http://www.project-moonshot.org/gitweb/?p=mech_eap.git;a=commitdiff_plain;h=899e578a598e3be50fdf3e7cc1ef033e60d4067a

cleanup, notes on composite names
---

diff --git a/export_name_composite.c b/export_name_composite.c
index 97e6dd5..2b80dba 100644
--- a/export_name_composite.c
+++ b/export_name_composite.c
@@ -32,6 +32,11 @@
 
 #include "gssapiP_eap.h"
 
+/*
+ * Not sure about this. If we have a generalised representation of composite
+ * names, it should be (a) defined in the naming extensions specification
+ * and (b) implemented by the mechanism glue.
+ */
 OM_uint32
 gss_export_name_composite(OM_uint32 *minor,
                           gss_name_t input_name,
diff --git a/util_name.c b/util_name.c
index 58919e1..be7f4cb 100644
--- a/util_name.c
+++ b/util_name.c
@@ -384,12 +384,6 @@ gssEapExportName(OM_uint32 *minor,
     GSSEAP_KRB_INIT(&krbContext);
     GSSEAP_MUTEX_LOCK(&name->mutex);
 
-    /*
-     * Don't export a composite name if we don't have any attributes.
-     */
-    if (composite && !NAME_HAS_ATTRIBUTES(name))
-        composite = 0;
-
     *minor = krb5_unparse_name(krbContext, name->krbPrincipal, &krbName);
     if (*minor != 0) {
         major = GSS_S_FAILURE;