Prevent potential null pointer dereference
authorJames Groffen <james.groffen@dsto.defence.gov.au>
Fri, 8 Jan 2016 04:13:14 +0000 (14:43 +1030)
committerSimo Sorce <simo@redhat.com>
Mon, 11 Jan 2016 18:48:44 +0000 (13:48 -0500)
This commit adds checks to ensure cfg->name_attributes is not null before
it is used in mag_get_name_attributes.

(Reworded commit message)

Reviewed-by: Simo Sorce <simo@redhat.com>
Close #64

src/environ.c

index 9ef010b..49b648c 100644 (file)
@@ -152,6 +152,10 @@ gss_buffer_desc empty_buffer = GSS_C_EMPTY_BUFFER;
 void mag_get_name_attributes(request_rec *req, struct mag_config *cfg,
                              gss_name_t name, struct mag_conn *mc)
 {
+    if (!cfg->name_attributes) {
+        return;
+    }
+
     uint32_t maj, min;
     gss_buffer_set_t attrs = GSS_C_NO_BUFFER_SET;
     struct name_attr attr;