From: Simo Sorce <simo@redhat.com>
Date: Tue, 10 Mar 2015 17:32:36 +0000 (-0400)
Subject: Fix random number generation
X-Git-Tag: v1.1.0~4
X-Git-Url: http://www.project-moonshot.org/gitweb/?p=mod_auth_gssapi.git;a=commitdiff_plain;h=2b95bf742f097b419b4e63ef74f33fc121c91bf0

Fix random number generation

Untested code is broken code :(
---

diff --git a/src/crypto.c b/src/crypto.c
index a902d63..a5dea45 100644
--- a/src/crypto.c
+++ b/src/crypto.c
@@ -58,13 +58,13 @@ apr_status_t SEAL_KEY_CREATE(apr_pool_t *p, struct seal_key **skey,
         memcpy(n->hkey, keys->value + keylen, keylen);
     } else {
         ret = apr_generate_random_bytes(n->ekey, keylen);
-        if (ret == 0) {
+        if (ret != 0) {
             ret = EFAULT;
             goto done;
         }
 
         ret = apr_generate_random_bytes(n->hkey, keylen);
-        if (ret == 0) {
+        if (ret != 0) {
             ret = EFAULT;
             goto done;
         }
@@ -99,7 +99,7 @@ apr_status_t SEAL_BUFFER(apr_pool_t *p, struct seal_key *skey,
     /* confounder to avoid exposing random numbers directly to clients
      * as IVs */
     ret = apr_generate_random_bytes(rbuf, sizeof(rbuf));
-    if (ret == 0) goto done;
+    if (ret != 0) goto done;
 
     if (cipher->length == 0) {
         /* add space for confounder and padding and MAC */