From: James Groffen <james.groffen@dsto.defence.gov.au>
Date: Fri, 8 Jan 2016 04:13:14 +0000 (+1030)
Subject: Prevent potential null pointer dereference
X-Git-Tag: v1.3.2~7
X-Git-Url: http://www.project-moonshot.org/gitweb/?p=mod_auth_gssapi.git;a=commitdiff_plain;h=ea848ec7ac001d2ea181e7f3e52c8c946cffd15c;hp=7f11db955b8440668fc806b4203f584bb44f58c1

Prevent potential null pointer dereference

This commit adds checks to ensure cfg->name_attributes is not null before
it is used in mag_get_name_attributes.

(Reworded commit message)

Reviewed-by: Simo Sorce <simo@redhat.com>

Close #64
---

diff --git a/src/environ.c b/src/environ.c
index 9ef010b..49b648c 100644
--- a/src/environ.c
+++ b/src/environ.c
@@ -152,6 +152,10 @@ gss_buffer_desc empty_buffer = GSS_C_EMPTY_BUFFER;
 void mag_get_name_attributes(request_rec *req, struct mag_config *cfg,
                              gss_name_t name, struct mag_conn *mc)
 {
+    if (!cfg->name_attributes) {
+        return;
+    }
+
     uint32_t maj, min;
     gss_buffer_set_t attrs = GSS_C_NO_BUFFER_SET;
     struct name_attr attr;