From 2b95bf742f097b419b4e63ef74f33fc121c91bf0 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Tue, 10 Mar 2015 13:32:36 -0400 Subject: [PATCH] Fix random number generation Untested code is broken code :( --- src/crypto.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/crypto.c b/src/crypto.c index a902d63..a5dea45 100644 --- a/src/crypto.c +++ b/src/crypto.c @@ -58,13 +58,13 @@ apr_status_t SEAL_KEY_CREATE(apr_pool_t *p, struct seal_key **skey, memcpy(n->hkey, keys->value + keylen, keylen); } else { ret = apr_generate_random_bytes(n->ekey, keylen); - if (ret == 0) { + if (ret != 0) { ret = EFAULT; goto done; } ret = apr_generate_random_bytes(n->hkey, keylen); - if (ret == 0) { + if (ret != 0) { ret = EFAULT; goto done; } @@ -99,7 +99,7 @@ apr_status_t SEAL_BUFFER(apr_pool_t *p, struct seal_key *skey, /* confounder to avoid exposing random numbers directly to clients * as IVs */ ret = apr_generate_random_bytes(rbuf, sizeof(rbuf)); - if (ret == 0) goto done; + if (ret != 0) goto done; if (cipher->length == 0) { /* add space for confounder and padding and MAC */ -- 2.1.4