From 8c089a89fae54236c7e05c8e153ecf1a75e27bbf Mon Sep 17 00:00:00 2001 From: Isaac Boukris Date: Sun, 14 Jun 2015 22:34:28 +0300 Subject: [PATCH 1/1] Use apr_pool_cleanup_register() to cleanup mc Instead of using apr_pool_userdata_set() since we don't use apr_pool_userdata_get() with the mag_conn_ptr apr_pool_cleanup_register() seem cleaner. Reviewed-by: Simo Sorce --- src/mod_auth_gssapi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mod_auth_gssapi.c b/src/mod_auth_gssapi.c index f0fa83f..39d63a5 100644 --- a/src/mod_auth_gssapi.c +++ b/src/mod_auth_gssapi.c @@ -424,8 +424,8 @@ static int mag_auth(request_rec *req) if (mc) { /* register the context in the memory pool, so it can be freed * when the connection/request is terminated */ - apr_pool_userdata_set(mc, "mag_conn_ptr", - mag_conn_destroy, mc->parent); + apr_pool_cleanup_register(mc->parent, (void *) mc, + mag_conn_destroy, apr_pool_cleanup_null); if (mc->established && !auth_header) { ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, req, -- 2.1.4