From ea848ec7ac001d2ea181e7f3e52c8c946cffd15c Mon Sep 17 00:00:00 2001 From: James Groffen Date: Fri, 8 Jan 2016 14:43:14 +1030 Subject: [PATCH 1/1] Prevent potential null pointer dereference This commit adds checks to ensure cfg->name_attributes is not null before it is used in mag_get_name_attributes. (Reworded commit message) Reviewed-by: Simo Sorce Close #64 --- src/environ.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/environ.c b/src/environ.c index 9ef010b..49b648c 100644 --- a/src/environ.c +++ b/src/environ.c @@ -152,6 +152,10 @@ gss_buffer_desc empty_buffer = GSS_C_EMPTY_BUFFER; void mag_get_name_attributes(request_rec *req, struct mag_config *cfg, gss_name_t name, struct mag_conn *mc) { + if (!cfg->name_attributes) { + return; + } + uint32_t maj, min; gss_buffer_set_t attrs = GSS_C_NO_BUFFER_SET; struct name_attr attr; -- 2.1.4