Cleaning up compilation warnings
[moonshot-ui.git] / src / moonshot-provisioning-common.vala
index b18cd8b..d780eeb 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2011-2014, JANET(UK)
+ * Copyright (c) 2011-2016, JANET(UK)
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
 
 
 namespace WebProvisioning
-{ 
+{
     bool check_stack(SList<string> stack, string[] reference) {
 
         if (stack.length() < reference.length)
             return false;
-    
+
         for (int i = 0; i < reference.length; i++)
         {
             if (stack.nth_data(i) != reference[i])
@@ -51,88 +51,92 @@ namespace WebProvisioning
     bool always_confirm_handler(SList<string> stack)
     {
         string[] always_confirm_path = {"always-confirm", "rule", "selection-rules", "identity", "identities"};
-    
+
         return check_stack(stack, always_confirm_path);
     }
-  
+
     bool
     pattern_handler(SList<string> stack)
     {
         string[] pattern_path = {"pattern", "rule", "selection-rules", "identity", "identities"};
-    
+
         return check_stack(stack, pattern_path);
     }
 
     bool server_cert_handler(SList<string> stack)
     {
         string[] server_cert_path = {"server-cert", "trust-anchor", "identity", "identities"};
-    
+
         return check_stack(stack, server_cert_path);
     }
 
     bool subject_alt_handler(SList<string> stack)
     {
         string[] subject_alt_path = {"subject-alt", "trust-anchor", "identity", "identities"};
-    
+
         return check_stack(stack, subject_alt_path);
     }
 
     bool subject_handler(SList<string> stack)
     {
         string[] subject_path = {"subject", "trust-anchor", "identity", "identities"};
-    
+
         return check_stack(stack, subject_path);
     }
-  
+
     bool ca_cert_handler(SList<string> stack)
     {
         string[] ca_path = {"ca-cert", "trust-anchor", "identity", "identities"};
-    
+
         return check_stack(stack, ca_path);
     }
 
     bool realm_handler(SList<string> stack)
     {
         string[] realm_path = {"realm", "identity", "identities"};
-    
+
         return check_stack(stack, realm_path);
     }
 
     bool password_handler(SList<string> stack)
     {
         string[] password_path = {"password", "identity", "identities"};
-    
+
         return check_stack(stack, password_path);
     }
 
     bool user_handler(SList<string> stack)
     {
         string[] user_path = {"user", "identity", "identities"};
-    
+
         return check_stack(stack, user_path);
     }
 
     bool display_name_handler(SList<string> stack)
     {
         string[] display_name_path = {"display-name", "identity", "identities"};
-    
+
         return check_stack(stack, display_name_path);
     }
-  
+
     public class Parser : Object
     {
-        private static MoonshotLogger logger = new MoonshotLogger("WebProvisioning");
+        // private static MoonshotLogger logger = new MoonshotLogger("WebProvisioning");
 
         private void start_element_func(MarkupParseContext context,
                                         string element_name,
                                         string[] attribute_names,
-                                        string[] attribute_values) throws MarkupError 
+                                        string[] attribute_values) throws MarkupError
             {
                 if (element_name == "identity")
                 {
-                    logger.trace("start_element_func (%p): Adding an identity".printf(this));
                     card = new IdCard();
                     _cards += card;
+
+                    ta_ca_cert = "";
+                    ta_server_cert = "";
+                    ta_subject = "";
+                    ta_subject_alt = "";
                 }
                 else if (element_name == "rule")
                 {
@@ -140,16 +144,30 @@ namespace WebProvisioning
                 }
             }
 
+            private void end_element_func(MarkupParseContext context,
+                                          string element_name) throws MarkupError
+            {
+                if (element_name == "identity")
+                {
+                    if (ta_ca_cert != "" || ta_server_cert != "") {
+                        var ta = new TrustAnchor(ta_ca_cert,
+                                                 ta_server_cert,
+                                                 ta_subject,
+                                                 ta_subject_alt,
+                                                 false);
+                        card.set_trust_anchor_from_store(ta);
+                    }
+                }
+            }
+
             private void
             text_element_func(MarkupParseContext context,
                               string             text,
                               size_t             text_len) throws MarkupError {
                 unowned SList<string> stack = context.get_element_stack();
-    
+
                 if (text_len < 1)
                     return;
-    
-                logger.trace("text_element_func (%p): text='%s'".printf(this, stack.nth_data(0)));
 
                 if (stack.nth_data(0) == "display-name" && display_name_handler(stack))
                 {
@@ -175,7 +193,7 @@ namespace WebProvisioning
                 /* Rules */
                 else if (stack.nth_data(0) == "pattern" && pattern_handler(stack))
                 {
-                    /* use temp array to workaround valac 0.10 bug accessing array property length */ 
+                    /* use temp array to workaround valac 0.10 bug accessing array property length */
                     var temp = card.rules;
                     card.rules[temp.length - 1].pattern = text;
                 }
@@ -187,29 +205,26 @@ namespace WebProvisioning
                         card.rules[temp.length - 1].always_confirm = text;
                     }
                 }
-                /*Trust anchor*/
                 else if (stack.nth_data(0) == "ca-cert" && ca_cert_handler(stack))
                 {
-                    card.trust_anchor.ca_cert = text;
+                    ta_ca_cert = text ?? "";
                 }
-                else if (stack.nth_data(0) == "subject" && subject_handler(stack))
+                else if (stack.nth_data(0) == "server-cert" && server_cert_handler(stack))
                 {
-                    card.trust_anchor.subject = text;
+                    ta_server_cert = text ?? "";
                 }
-                else if (stack.nth_data(0) == "subject-alt" && subject_alt_handler(stack))
+                else if (stack.nth_data(0) == "subject" && subject_handler(stack))
                 {
-                    card.trust_anchor.subject_alt = text;
+                    ta_subject = text;
                 }
-                else if (stack.nth_data(0) == "server-cert" && server_cert_handler(stack))
+                else if (stack.nth_data(0) == "subject-alt" && subject_alt_handler(stack))
                 {
-                    card.trust_anchor.server_cert = text;
+                    ta_subject_alt = text;
                 }
             }
 
-
-
         private const MarkupParser parser = {
-            start_element_func, null, text_element_func, null, null
+            start_element_func, end_element_func, text_element_func, null, null
         };
 
         private MarkupParseContext ctx;
@@ -217,6 +232,11 @@ namespace WebProvisioning
         private string       text;
         private string       path;
 
+        private string ta_ca_cert;
+        private string ta_server_cert;
+        private string ta_subject;
+        private string ta_subject_alt;
+
         private IdCard card;
         private IdCard[] _cards = {};
 
@@ -233,7 +253,7 @@ namespace WebProvisioning
             this.path = path;
 
             var file = File.new_for_path(path);
-    
+
             try
             {
                 var dis = new DataInputStream(file.read());
@@ -241,9 +261,8 @@ namespace WebProvisioning
                 while ((line = dis.read_line(null)) != null) {
                     text += line;
 
-                    // Preserve newlines -- important for certificate import.
-                    // (X509 certs can't be parsed without the newlines.)
-                    // 
+                    // Preserve newlines.
+                    //
                     // This may add an extra newline at EOF. Maybe use
                     // dis.read_upto("\n", ...) followed by dis.read_byte() instead?
                     text += "\n";
@@ -253,8 +272,6 @@ namespace WebProvisioning
             {
                 error("Could not retreive file size");
             }
-      
-            logger.trace(@"Parser(): read text to parse; length=$(text.length)");
         }
 
         public void parse() {
@@ -265,7 +282,7 @@ namespace WebProvisioning
             catch(GLib.Error e)
             {
                 error("Could not parse %s, invalid content", path);
-            } 
+            }
         }
     }
 }