From: Luke Howard <lukeh@padl.com>
Date: Mon, 16 May 2011 07:48:43 +0000 (+0200)
Subject: note that treating all base64 values as binary is bad
X-Git-Tag: tr-beta1~158
X-Git-Url: http://www.project-moonshot.org/gitweb/?p=moonshot.git;a=commitdiff_plain;h=5e6d3b372b94f98e621f3845f25d58b50fde1599

note that treating all base64 values as binary is bad
---

diff --git a/moonshot/mech_eap/util_shib.cpp b/moonshot/mech_eap/util_shib.cpp
index a83a7ea..0ee894b 100644
--- a/moonshot/mech_eap/util_shib.cpp
+++ b/moonshot/mech_eap/util_shib.cpp
@@ -304,6 +304,7 @@ gss_eap_shib_attr_provider::getAttribute(const gss_buffer_t attr,
     buf.value = (void *)shibAttr->getSerializedValues()[*more].c_str();
     buf.length = strlen((char *)buf.value);
 
+    /* FIXME treating all valid base64 values as binary is bad */
     if (base64Valid((char *)buf.value)) {
         ssize_t octetLen;