From 5e6d3b372b94f98e621f3845f25d58b50fde1599 Mon Sep 17 00:00:00 2001 From: Luke Howard Date: Mon, 16 May 2011 09:48:43 +0200 Subject: [PATCH] note that treating all base64 values as binary is bad --- moonshot/mech_eap/util_shib.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/moonshot/mech_eap/util_shib.cpp b/moonshot/mech_eap/util_shib.cpp index a83a7ea..0ee894b 100644 --- a/moonshot/mech_eap/util_shib.cpp +++ b/moonshot/mech_eap/util_shib.cpp @@ -304,6 +304,7 @@ gss_eap_shib_attr_provider::getAttribute(const gss_buffer_t attr, buf.value = (void *)shibAttr->getSerializedValues()[*more].c_str(); buf.length = strlen((char *)buf.value); + /* FIXME treating all valid base64 values as binary is bad */ if (base64Valid((char *)buf.value)) { ssize_t octetLen; -- 2.1.4