From: Scott Cantor <cantor.2@osu.edu>
Date: Fri, 2 Apr 2010 00:24:09 +0000 (+0000)
Subject: Fix race condition during shutdown.
X-Git-Tag: 2.4RC1~67
X-Git-Url: http://www.project-moonshot.org/gitweb/?p=shibboleth%2Fcpp-opensaml.git;a=commitdiff_plain;h=b83476f25f2f38fd3b0f36ed95c9a73b7c9b0eac

Fix race condition during shutdown.
---

diff --git a/saml/saml2/metadata/impl/XMLMetadataProvider.cpp b/saml/saml2/metadata/impl/XMLMetadataProvider.cpp
index be76358..5462564 100644
--- a/saml/saml2/metadata/impl/XMLMetadataProvider.cpp
+++ b/saml/saml2/metadata/impl/XMLMetadataProvider.cpp
@@ -53,12 +53,8 @@ namespace opensaml {
                     m_object(NULL), m_maxCacheDuration(m_reloadInterval) {
             }
             virtual ~XMLMetadataProvider() {
-                if (m_lock)
-                    m_lock->wrlock();
+                shutdown();
                 delete m_object;
-                m_object = NULL;
-                if (m_lock)
-                    m_lock->unlock();
             }
 
             void init() {