From: Scott Cantor <cantor.2@osu.edu>
Date: Tue, 16 Jan 2007 17:00:21 +0000 (+0000)
Subject: Allow for missing message metadata so rule won't break vanilla SOAP.
X-Git-Tag: 2.0-alpha1~109
X-Git-Url: http://www.project-moonshot.org/gitweb/?p=shibboleth%2Fcpp-opensaml.git;a=commitdiff_plain;h=c41bff9d66b8bd17934fa20abcfdf375fd298803

Allow for missing message metadata so rule won't break vanilla SOAP.
---

diff --git a/saml/binding/impl/MessageFlowRule.cpp b/saml/binding/impl/MessageFlowRule.cpp
index ce04682..80aef92 100644
--- a/saml/binding/impl/MessageFlowRule.cpp
+++ b/saml/binding/impl/MessageFlowRule.cpp
@@ -61,35 +61,38 @@ void MessageFlowRule::evaluate(const XMLObject& message, const GenericRequest* r
     Category& log=Category::getInstance(SAML_LOGCAT".SecurityPolicyRule.MessageFlow");
     log.debug("evaluating message flow policy (replay checking %s, expiration %lu)", m_checkReplay ? "on" : "off", m_expires);
 
+    time_t now = time(NULL);
+    time_t skew = XMLToolingConfig::getConfig().clock_skew_secs;
     time_t issueInstant = policy.getIssueInstant();
     if (issueInstant == 0) {
-        log.error("unknown message timestamp");
-        throw BindingException("Message rejected, no timestamp available.");
+        log.info("unknown message timestamp, assuming current time for replay checking");
+        issueInstant = now;
     }
-    
-    time_t skew = XMLToolingConfig::getConfig().clock_skew_secs;
-    time_t now = time(NULL);
-    if (issueInstant > now + skew) {
-        log.errorStream() << "rejected not-yet-valid message, timestamp (" << issueInstant <<
-            "), newest allowed (" << now + skew << ")" << CategoryStream::ENDLINE;
-        throw BindingException("Message rejected, was issued in the future.");
-    }
-    else if (issueInstant < now - skew - m_expires) {
-        log.errorStream() << "rejected expired message, timestamp (" << issueInstant <<
-            "), oldest allowed (" << (now - skew - m_expires) << ")" << CategoryStream::ENDLINE;
-        throw BindingException("Message expired, was issued too long ago.");
+    else {
+        if (issueInstant > now + skew) {
+            log.errorStream() << "rejected not-yet-valid message, timestamp (" << issueInstant <<
+                "), newest allowed (" << now + skew << ")" << CategoryStream::ENDLINE;
+            throw BindingException("Message rejected, was issued in the future.");
+        }
+        else if (issueInstant < now - skew - m_expires) {
+            log.errorStream() << "rejected expired message, timestamp (" << issueInstant <<
+                "), oldest allowed (" << (now - skew - m_expires) << ")" << CategoryStream::ENDLINE;
+            throw BindingException("Message expired, was issued too long ago.");
+        }
     }
     
     // Check replay.
     if (m_checkReplay) {
         const XMLCh* id = policy.getMessageID();
+        if (!id || !*id) {
+            log.info("unknown message ID, no replay check possible");
+            return;
+        }
         ReplayCache* replayCache = XMLToolingConfig::getConfig().getReplayCache();
         if (!replayCache)
             throw BindingException("Message rejected, no ReplayCache instance available.");
-        else if (!id)
-            throw BindingException("Message rejected, did not contain an identifier.");
         auto_ptr_char temp(id);
-        if (!replayCache->check("SAML", temp.get(), issueInstant + skew + m_expires)) {
+        if (!replayCache->check("MessageFlow", temp.get(), issueInstant + skew + m_expires)) {
             log.error("replay detected of message ID (%s)", temp.get());
             throw BindingException("Rejecting replayed message ID ($1).", params(1,temp.get()));
         }