From a6268a810d7892f1752de92ac8b5fbe929c27c4c Mon Sep 17 00:00:00 2001 From: Scott Cantor Date: Thu, 22 Jan 2015 21:32:53 +0000 Subject: [PATCH] https://issues.shibboleth.net/jira/browse/CPPOST-87 --- saml/saml2/metadata/impl/DiscoverableMetadataProvider.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/saml/saml2/metadata/impl/DiscoverableMetadataProvider.cpp b/saml/saml2/metadata/impl/DiscoverableMetadataProvider.cpp index 7316903..2b26618 100644 --- a/saml/saml2/metadata/impl/DiscoverableMetadataProvider.cpp +++ b/saml/saml2/metadata/impl/DiscoverableMetadataProvider.cpp @@ -181,6 +181,7 @@ void DiscoverableMetadataProvider::discoEntity(string& s, const EntityDescriptor json_safe(s, entityid.get()); s += '\"'; bool extFound = false; + bool displayNameFound = false; for (indirect_iterator::const_iterator> idp = make_indirect_iterator(idps.begin()); !extFound && idp != make_indirect_iterator(idps.end()); ++idp) { if (idp->isValid(now) && idp->getExtensions()) { @@ -191,6 +192,7 @@ void DiscoverableMetadataProvider::discoEntity(string& s, const EntityDescriptor extFound = true; const vector& dispnames = info->getDisplayNames(); if (!dispnames.empty()) { + displayNameFound = true; s += ",\n \"DisplayNames\": ["; for (indirect_iterator::const_iterator> dispname = make_indirect_iterator(dispnames.begin()); dispname != make_indirect_iterator(dispnames.end()); ++dispname) { @@ -314,7 +316,7 @@ void DiscoverableMetadataProvider::discoEntity(string& s, const EntityDescriptor } } - if (m_legacyOrgNames && !extFound) { + if (m_legacyOrgNames && !displayNameFound) { const Organization* org = nullptr; for (indirect_iterator::const_iterator> idp = make_indirect_iterator(idps.begin()); !org && idp != make_indirect_iterator(idps.end()); ++idp) { -- 2.1.4