From fe0ce42ca9505ad980e650ada2c11b396970f5a3 Mon Sep 17 00:00:00 2001 From: Scott Cantor Date: Sat, 6 Oct 2012 00:11:45 +0000 Subject: [PATCH] https://issues.shibboleth.net/jira/browse/CPPXT-91 --- saml/saml2/metadata/impl/AbstractMetadataProvider.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/saml/saml2/metadata/impl/AbstractMetadataProvider.cpp b/saml/saml2/metadata/impl/AbstractMetadataProvider.cpp index 229d881..419fe1e 100644 --- a/saml/saml2/metadata/impl/AbstractMetadataProvider.cpp +++ b/saml/saml2/metadata/impl/AbstractMetadataProvider.cpp @@ -363,9 +363,12 @@ const AbstractMetadataProvider::credmap_t::mapped_type& AbstractMetadataProvider k != make_indirect_iterator(keys.end()); ++k) { if (k->getKeyInfo()) { auto_ptr mcc(new MetadataCredentialContext(*k)); - Credential* c = resolver->resolve(mcc.get()); - mcc.release(); - resolved.push_back(c); + auto_ptr c(resolver->resolve(mcc.get())); + if (c.get()) { + mcc.release(); // this API sucks, the object is now owned by the Credential + resolved.push_back(c.get()); + c.release(); + } } } return resolved; -- 2.1.4