From: Scott Cantor <cantor.2@osu.edu>
Date: Thu, 2 Jul 2015 00:43:27 +0000 (+0000)
Subject: SSPCPP-658 - setuid/setgid fails to remove supplementary groups
X-Git-Tag: 2.5.5~13
X-Git-Url: http://www.project-moonshot.org/gitweb/?p=shibboleth%2Fcpp-sp.git;a=commitdiff_plain;h=a6ee34e6e92d960659adea2ddabf2f5b9d3b4b26

SSPCPP-658 - setuid/setgid fails to remove supplementary groups
---

diff --git a/configure.ac b/configure.ac
index 86aade7..ea12766 100644
--- a/configure.ac
+++ b/configure.ac
@@ -77,7 +77,7 @@ AC_FUNC_STRFTIME
 AC_FUNC_STRERROR_R
 AC_CHECK_HEADERS([sys/utsname.h grp.h pwd.h])
 AC_CHECK_HEADERS([sys/socket.h], [AC_DEFINE([SHIBSP_HAVE_SYS_SOCKET_H],[1],[Define to 1 if you have the <sys/socket> header file.])], [])
-AC_CHECK_FUNCS([strchr strdup strstr timegm gmtime_r localtime_r strtok_r strcasecmp getpwnam getgrnam])
+AC_CHECK_FUNCS([strchr strdup strstr timegm gmtime_r localtime_r strtok_r strcasecmp getpwnam getgrnam initgroups])
 AC_CHECK_TYPES([struct sockaddr_storage], [], [], [[#include <sys/socket.h>]])
 AC_CHECK_MEMBERS([struct sockaddr.sa_len], [], [], [[#include <sys/socket.h>]])
 
diff --git a/shibd/shibd.cpp b/shibd/shibd.cpp
index c79e1dc..8c67563 100644
--- a/shibd/shibd.cpp
+++ b/shibd/shibd.cpp
@@ -349,6 +349,13 @@ int main(int argc, char *argv[])
             fprintf(stderr, "getpwnam failed, check -u option\n");
             return -1;
         }
+#ifdef HAVE_INITGROUPS
+        // w/out initgroups/setgroups process retains supplementary groups
+        if (initgroups(pwd->pw_name, pwd->pw_gid) != 0) {
+            fprintf(stderr, "initgroups failed, check -u option\n");
+            return -1;
+        }
+#endif
         if (setuid(pwd->pw_uid) != 0) {
             fprintf(stderr, "setuid failed, check -u option\n");
             return -1;