From: Scott Cantor <cantor.2@osu.edu>
Date: Wed, 11 May 2016 16:54:49 +0000 (-0400)
Subject: SSPCPP-680 - Spurious "caches out of sync" warnings on timed out sessions
X-Git-Url: http://www.project-moonshot.org/gitweb/?p=shibboleth%2Fcpp-sp.git;a=commitdiff_plain;h=a9b65f234b7933930c16e9d85a35228af2ecddcf

SSPCPP-680 - Spurious "caches out of sync" warnings on timed out sessions

https://issues.shibboleth.net/jira/browse/SSPCPP-680
---

diff --git a/shibsp/impl/StorageServiceSessionCache.cpp b/shibsp/impl/StorageServiceSessionCache.cpp
index 6132654..1e6739d 100644
--- a/shibsp/impl/StorageServiceSessionCache.cpp
+++ b/shibsp/impl/StorageServiceSessionCache.cpp
@@ -532,7 +532,7 @@ void StoredSession::validate(const Application& app, const char* client_addr, ti
         int curver = m_obj["version"].integer();
         int ver = m_cache->m_storage->readText(getID(), "session", &record, &lastAccess, curver);
         if (ver == 0) {
-            m_cache->m_log.warn("unsuccessful versioned read of session (ID: %s), cache out of sync?", getID());
+            m_cache->m_log.info("session (ID: %s) no longer in storage", getID());
             throw RetryableProfileException("Your session has expired, and you must re-authenticate.");
         }
 
@@ -1999,7 +1999,7 @@ void SSCache::receive(DDF& in, ostream& out)
         int curver = in["version"].integer();
         int ver = m_storage->readText(key, "session", &record, &lastAccess, client_addr ? 0 : curver);
         if (ver == 0) {
-            m_log.warn("unsuccessful read of session (ID: %s), caches out of sync?", key);
+            m_log.info("session (ID: %s) no longer in storage", key);
             throw RetryableProfileException("Your session has expired, and you must re-authenticate.");
         }