From: Scott Cantor <cantor.2@osu.edu>
Date: Wed, 21 Jan 2015 18:20:06 +0000 (+0000)
Subject: Add a redundant safety check to insert
X-Git-Tag: 2.5.4~20
X-Git-Url: http://www.project-moonshot.org/gitweb/?p=shibboleth%2Fcpp-sp.git;a=commitdiff_plain;h=c44abc33cda3840a0ff1cfe889f2776f13607192

Add a redundant safety check to insert
---

diff --git a/shibsp/impl/StorageServiceSessionCache.cpp b/shibsp/impl/StorageServiceSessionCache.cpp
index b816624..0c5ffe8 100644
--- a/shibsp/impl/StorageServiceSessionCache.cpp
+++ b/shibsp/impl/StorageServiceSessionCache.cpp
@@ -1040,8 +1040,14 @@ void SSCache::test()
 
 void SSCache::insert(const char* key, time_t expires, const char* name, const char* index, short attempts)
 {
-    if (attempts > 10)
+    if (attempts > 10) {
         throw IOException("Exceeded retry limit.");
+    }
+
+    if (!name || !*name) {
+        m_log.warn("NameID value was empty or null, ignoring request to store for logout");
+        return;
+    }
 
     string dup;
     unsigned int storageLimit = m_storage_lite->getCapabilities().getKeySize();