/*
- * Copyright 2001-2006 Internet2
+ * Copyright 2001-2007 Internet2
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
#include "internal.h"
#include "exceptions.h"
-#include "binding/HTTPRequest.h"
-#include "binding/SimpleSigningRule.h"
+#include "binding/SecurityPolicyRule.h"
#include "saml2/core/Assertions.h"
#include "saml2/metadata/Metadata.h"
+#include "saml2/metadata/MetadataCredentialCriteria.h"
#include "saml2/metadata/MetadataProvider.h"
-#include <log4cpp/Category.hh>
+#include <xercesc/util/Base64.hpp>
+#include <xmltooling/logging.h>
+#include <xmltooling/io/HTTPRequest.h>
+#include <xmltooling/security/SignatureTrustEngine.h>
using namespace opensaml::saml2md;
using namespace opensaml;
+using namespace xmltooling::logging;
using namespace xmltooling;
-using namespace log4cpp;
using namespace std;
using xmlsignature::KeyInfo;
+using xmlsignature::SignatureException;
namespace opensaml {
+ class SAML_DLLLOCAL SimpleSigningRule : public SecurityPolicyRule
+ {
+ public:
+ SimpleSigningRule(const DOMElement* e);
+ virtual ~SimpleSigningRule() {}
+
+ void evaluate(const xmltooling::XMLObject& message, const GenericRequest* request, SecurityPolicy& policy) const;
+
+ private:
+ // Appends a raw parameter=value pair to the string.
+ static bool appendParameter(string& s, const char* data, const char* name);
+
+ bool m_errorsFatal;
+ };
+
SecurityPolicyRule* SAML_DLLLOCAL SimpleSigningRuleFactory(const DOMElement* const & e)
{
return new SimpleSigningRule(e);
}
- // Appends a raw parameter=value pair to the string.
- static bool appendParameter(string& s, const char* data, const char* name)
- {
- const char* start = strstr(data,name);
- if (!start)
- return false;
- if (!s.empty())
- s += '&';
- const char* end = strchr(start,'&');
- if (end)
- s.append(start, end-start);
- else
- s.append(start);
- return true;
- }
+ static const XMLCh errorsFatal[] = UNICODE_LITERAL_11(e,r,r,o,r,s,F,a,t,a,l);
};
+bool SimpleSigningRule::appendParameter(string& s, const char* data, const char* name)
+{
+ const char* start = strstr(data,name);
+ if (!start)
+ return false;
+ if (!s.empty())
+ s += '&';
+ const char* end = strchr(start,'&');
+ if (end)
+ s.append(start, end-start);
+ else
+ s.append(start);
+ return true;
+}
+
+SimpleSigningRule::SimpleSigningRule(const DOMElement* e) : m_errorsFatal(false)
+{
+ if (e) {
+ const XMLCh* flag = e->getAttributeNS(NULL, errorsFatal);
+ m_errorsFatal = (flag && (*flag==chLatin_t || *flag==chDigit_1));
+ }
+}
-bool SimpleSigningRule::evaluate(const XMLObject& message, const GenericRequest* request, SecurityPolicy& policy) const
+void SimpleSigningRule::evaluate(const XMLObject& message, const GenericRequest* request, SecurityPolicy& policy) const
{
Category& log=Category::getInstance(SAML_LOGCAT".SecurityPolicyRule.SimpleSigning");
- log.debug("evaluating simple signing policy");
if (!policy.getIssuerMetadata()) {
log.debug("ignoring message, no issuer metadata supplied");
- return false;
+ return;
}
- else if (!policy.getTrustEngine()) {
- log.debug("ignoring message, no TrustEngine supplied");
- return false;
+
+ const SignatureTrustEngine* sigtrust;
+ if (!(sigtrust=dynamic_cast<const SignatureTrustEngine*>(policy.getTrustEngine()))) {
+ log.debug("ignoring message, no SignatureTrustEngine supplied");
+ return;
}
const HTTPRequest* httpRequest = dynamic_cast<const HTTPRequest*>(request);
- if (!request || !httpRequest) {
- log.debug("ignoring message, no HTTP protocol request available");
- return false;
- }
+ if (!request || !httpRequest)
+ return;
const char* signature = request->getParameter("Signature");
- if (!signature) {
- log.debug("ignoring unsigned message");
- return false;
- }
+ if (!signature)
+ return;
const char* sigAlgorithm = request->getParameter("SigAlg");
if (!sigAlgorithm) {
log.error("SigAlg parameter not found, no way to verify the signature");
- return false;
+ return;
}
string input;
// We have to construct a string containing the signature input by accessing the
// request directly. We can't use the decoded parameters because we need the raw
// data and URL-encoding isn't canonical.
+
+ // NOTE: SimpleSign for GET means Redirect binding, which means we verify over the
+ // base64-encoded message directly.
+
pch = httpRequest->getQueryString();
if (!appendParameter(input, pch, "SAMLRequest="))
appendParameter(input, pch, "SAMLResponse=");
else {
// With POST, the input string is concatenated from the decoded form controls.
// GET should be this way too, but I messed up the spec, sorry.
+
+ // NOTE: SimpleSign for POST means POST binding, which means we verify over the
+ // base64-decoded XML. This sucks, because we have to decode the base64 directly.
+ // Serializing the XMLObject doesn't guarantee the signature will verify (this is
+ // why XMLSignature exists, and why this isn't really "simpler").
+
+ unsigned int x;
pch = httpRequest->getParameter("SAMLRequest");
- if (pch)
- input = string("SAMLRequest=") + pch;
+ if (pch) {
+ XMLByte* decoded=Base64::decode(reinterpret_cast<const XMLByte*>(pch),&x);
+ if (!decoded) {
+ log.warn("unable to decode base64 in POST binding message");
+ return;
+ }
+ input = string("SAMLRequest=") + reinterpret_cast<const char*>(decoded);
+ XMLString::release(&decoded);
+ }
else {
pch = httpRequest->getParameter("SAMLResponse");
- input = string("SAMLResponse=") + pch;
+ XMLByte* decoded=Base64::decode(reinterpret_cast<const XMLByte*>(pch),&x);
+ if (!decoded) {
+ log.warn("unable to decode base64 in POST binding message");
+ return;
+ }
+ input = string("SAMLResponse=") + reinterpret_cast<const char*>(decoded);
+ XMLString::release(&decoded);
}
+
pch = httpRequest->getParameter("RelayState");
if (pch)
input = input + "&RelayState=" + pch;
auto_ptr<KeyInfo> kjanitor(keyInfo);
auto_ptr_XMLCh alg(sigAlgorithm);
-
- if (!policy.getTrustEngine()->validate(
- alg.get(), signature, keyInfo, input.c_str(), input.length(),
- *(policy.getIssuerMetadata()), policy.getMetadataProvider()->getKeyResolver()
- )) {
+
+ // Set up criteria object.
+ MetadataCredentialCriteria cc(*(policy.getIssuerMetadata()));
+ cc.setXMLAlgorithm(alg.get());
+
+ if (!sigtrust->validate(alg.get(), signature, keyInfo, input.c_str(), input.length(), *(policy.getMetadataProvider()), &cc)) {
log.error("unable to verify message signature with supplied trust engine");
- return false;
+ if (m_errorsFatal)
+ throw SignatureException("Message was signed, but signature could not be verified.");
+ return;
}
log.debug("signature verified against message issuer");
- return true;
+ policy.setSecure(true);
}
projects / shibboleth / opensaml2.git / blobdiff