Rework signature validation in metadata filter.

[shibboleth/opensaml2.git] / saml / saml2 / metadata / impl / DynamicMetadataProvider.cpp

diff --git a/saml/saml2/metadata/impl/DynamicMetadataProvider.cpp b/saml/saml2/metadata/impl/DynamicMetadataProvider.cpp
index a23308f..7078fac 100644 (file)
--- a/saml/saml2/metadata/impl/DynamicMetadataProvider.cpp
+++ b/saml/saml2/metadata/impl/DynamicMetadataProvider.cpp
@@ -24,10 +24,10 @@
 #include "saml2/metadata/Metadata.h"
 #include "saml2/metadata/DynamicMetadataProvider.h"
 
-#include <xercesc/framework/Wrapper4InputSource.hpp>\r
-#include <xercesc/framework/URLInputSource.hpp>\r
-#include <xercesc/util/XMLUniDefs.hpp>\r
-#include <xmltooling/logging.h>\r
+#include <xercesc/framework/Wrapper4InputSource.hpp>
+#include <xercesc/framework/URLInputSource.hpp>
+#include <xercesc/util/XMLUniDefs.hpp>
+#include <xmltooling/logging.h>
 #include <xmltooling/util/XMLHelper.h>
 
 using namespace opensaml::saml2md;
@@ -35,7 +35,7 @@ using namespace xmltooling::logging;
 using namespace xmltooling;
 using namespace std;
 
-static const XMLCh validate[] = UNICODE_LITERAL_8(v,a,l,i,d,a,t,e);\r
+static const XMLCh validate[] = UNICODE_LITERAL_8(v,a,l,i,d,a,t,e);
 
 namespace opensaml {
     namespace saml2md {
@@ -49,8 +49,8 @@ namespace opensaml {
 DynamicMetadataProvider::DynamicMetadataProvider(const DOMElement* e)
     : AbstractMetadataProvider(e), m_lock(RWLock::create())
 {
-    const XMLCh* flag=e ? e->getAttributeNS(NULL,validate) : NULL;\r
-    m_validate=(XMLString::equals(flag,xmlconstants::XML_TRUE) || XMLString::equals(flag,xmlconstants::XML_ONE));\r
+    const XMLCh* flag=e ? e->getAttributeNS(NULL,validate) : NULL;
+    m_validate=(XMLString::equals(flag,xmlconstants::XML_TRUE) || XMLString::equals(flag,xmlconstants::XML_ONE));
 }
 
 DynamicMetadataProvider::~DynamicMetadataProvider()
@@ -102,16 +102,16 @@ const EntityDescriptor* DynamicMetadataProvider::getEntityDescriptor(const char*
 
 EntityDescriptor* DynamicMetadataProvider::resolve(const char* entityID) const
 {
-    try {\r
-        DOMDocument* doc=NULL;\r
-        auto_ptr_XMLCh widenit(entityID);\r
-        URLInputSource src(widenit.get());\r
-        Wrapper4InputSource dsrc(&src,false);\r
-        if (m_validate)\r
-            doc=XMLToolingConfig::getConfig().getValidatingParser().parse(dsrc);\r
-        else\r
-            doc=XMLToolingConfig::getConfig().getParser().parse(dsrc);\r
-\r
+    try {
+        DOMDocument* doc=NULL;
+        auto_ptr_XMLCh widenit(entityID);
+        URLInputSource src(widenit.get());
+        Wrapper4InputSource dsrc(&src,false);
+        if (m_validate)
+            doc=XMLToolingConfig::getConfig().getValidatingParser().parse(dsrc);
+        else
+            doc=XMLToolingConfig::getConfig().getParser().parse(dsrc);
+
         // Wrap the document for now.
         XercesJanitor<DOMDocument> docjanitor(doc);
                 
@@ -126,20 +126,20 @@ EntityDescriptor* DynamicMetadataProvider::resolve(const char* entityID) const
                 "Root of metadata instance not recognized: $1", params(1,xmlObject->getElementQName().toString().c_str())
                 );
         }
-        xmlObject.release();\r
-        return entity;\r
-    }\r
-    catch (XMLException& e) {\r
-        auto_ptr_char msg(e.getMessage());\r
-        Category::getInstance(SAML_LOGCAT".MetadataProvider.Dynamic").error(\r
-            "Xerces error while resolving entityID (%s): %s", entityID, msg.get()\r
-            );\r
-        throw MetadataException(msg.get());\r
-    }\r
-    catch (exception& e) {\r
-        Category::getInstance(SAML_LOGCAT".MetadataProvider.Dynamic").error(\r
-            "error while resolving entityID (%s): %s", entityID, e.what()\r
-            );\r
-        throw;\r
-    }\r
+        xmlObject.release();
+        return entity;
+    }
+    catch (XMLException& e) {
+        auto_ptr_char msg(e.getMessage());
+        Category::getInstance(SAML_LOGCAT".MetadataProvider.Dynamic").error(
+            "Xerces error while resolving entityID (%s): %s", entityID, msg.get()
+            );
+        throw MetadataException(msg.get());
+    }
+    catch (exception& e) {
+        Category::getInstance(SAML_LOGCAT".MetadataProvider.Dynamic").error(
+            "error while resolving entityID (%s): %s", entityID, e.what()
+            );
+        throw;
+    }
 }