From d6646ff459c51113410f261f9b8e1e02127e7210 Mon Sep 17 00:00:00 2001 From: cantor Date: Mon, 17 Dec 2007 21:05:37 +0000 Subject: [PATCH] Clarify error messages. git-svn-id: https://svn.middleware.georgetown.edu/cpp-opensaml2/trunk@357 fb386ef7-a10c-0410-8ebf-fd3f8e989ab0 --- saml/saml1/binding/impl/SAML1ArtifactDecoder.cpp | 2 +- saml/saml1/binding/impl/SAML1POSTDecoder.cpp | 2 +- saml/saml2/binding/impl/SAML2ArtifactDecoder.cpp | 2 +- saml/saml2/binding/impl/SAML2POSTDecoder.cpp | 2 +- saml/saml2/binding/impl/SAML2RedirectDecoder.cpp | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/saml/saml1/binding/impl/SAML1ArtifactDecoder.cpp b/saml/saml1/binding/impl/SAML1ArtifactDecoder.cpp index cbaf9a5..e24dda1 100644 --- a/saml/saml1/binding/impl/SAML1ArtifactDecoder.cpp +++ b/saml/saml1/binding/impl/SAML1ArtifactDecoder.cpp @@ -82,7 +82,7 @@ XMLObject* SAML1ArtifactDecoder::decode( vector SAMLart; const char* TARGET = httpRequest->getParameter("TARGET"); if (httpRequest->getParameters("SAMLart", SAMLart)==0 || !TARGET) - throw BindingException("Request missing SAMLart or TARGET parameters."); + throw BindingException("Request missing SAMLart or TARGET query string parameters."); relayState = TARGET; if (!m_artifactResolver || !policy.getMetadataProvider() || !policy.getRole()) diff --git a/saml/saml1/binding/impl/SAML1POSTDecoder.cpp b/saml/saml1/binding/impl/SAML1POSTDecoder.cpp index 92a28b7..0e60ffd 100644 --- a/saml/saml1/binding/impl/SAML1POSTDecoder.cpp +++ b/saml/saml1/binding/impl/SAML1POSTDecoder.cpp @@ -84,7 +84,7 @@ XMLObject* SAML1POSTDecoder::decode( const char* samlResponse = httpRequest->getParameter("SAMLResponse"); const char* TARGET = httpRequest->getParameter("TARGET"); if (!samlResponse || !TARGET) - throw BindingException("Request missing SAMLResponse or TARGET parameters."); + throw BindingException("Request missing SAMLResponse or TARGET form parameters."); relayState = TARGET; // Decode the base64 into SAML. diff --git a/saml/saml2/binding/impl/SAML2ArtifactDecoder.cpp b/saml/saml2/binding/impl/SAML2ArtifactDecoder.cpp index cb83ce7..c5f9209 100644 --- a/saml/saml2/binding/impl/SAML2ArtifactDecoder.cpp +++ b/saml/saml2/binding/impl/SAML2ArtifactDecoder.cpp @@ -80,7 +80,7 @@ XMLObject* SAML2ArtifactDecoder::decode( throw BindingException("Unable to cast request object to HTTPRequest type."); const char* SAMLart = httpRequest->getParameter("SAMLart"); if (!SAMLart) - throw BindingException("Request missing SAMLart parameter."); + throw BindingException("Request missing SAMLart query string or form parameter."); const char* state = httpRequest->getParameter("RelayState"); if (state) relayState = state; diff --git a/saml/saml2/binding/impl/SAML2POSTDecoder.cpp b/saml/saml2/binding/impl/SAML2POSTDecoder.cpp index 5438199..1898c4b 100644 --- a/saml/saml2/binding/impl/SAML2POSTDecoder.cpp +++ b/saml/saml2/binding/impl/SAML2POSTDecoder.cpp @@ -84,7 +84,7 @@ XMLObject* SAML2POSTDecoder::decode( if (!msg) msg = httpRequest->getParameter("SAMLRequest"); if (!msg) - throw BindingException("Request missing SAMLRequest or SAMLResponse parameter."); + throw BindingException("Request missing SAMLRequest or SAMLResponse form parameter."); const char* state = httpRequest->getParameter("RelayState"); if (state) relayState = state; diff --git a/saml/saml2/binding/impl/SAML2RedirectDecoder.cpp b/saml/saml2/binding/impl/SAML2RedirectDecoder.cpp index b43589c..ff0f5f7 100644 --- a/saml/saml2/binding/impl/SAML2RedirectDecoder.cpp +++ b/saml/saml2/binding/impl/SAML2RedirectDecoder.cpp @@ -86,7 +86,7 @@ XMLObject* SAML2RedirectDecoder::decode( if (!msg) msg = httpRequest->getParameter("SAMLRequest"); if (!msg) - throw BindingException("Request missing SAMLRequest or SAMLResponse parameter."); + throw BindingException("Request missing SAMLRequest or SAMLResponse query string parameter."); const char* state = httpRequest->getParameter("RelayState"); if (state) relayState = state; -- 2.1.4