freeradius.git
11 years agoMore version fixes for master branch
Arran Cudbard-Bell [Sat, 27 Oct 2012 21:05:55 +0000 (22:05 +0100)]
More version fixes for master branch

Should pass RADIUSD_VERSION_STRING as release

11 years agoUpdate configure script
Arran Cudbard-Bell [Sat, 27 Oct 2012 20:21:52 +0000 (22:21 +0200)]
Update configure script

11 years agoChange version constants to be more useful
Arran Cudbard-Bell [Sat, 27 Oct 2012 20:07:58 +0000 (21:07 +0100)]
Change version constants to be more useful

Configure script now sets:
* RADIUSD_MAJOR_VERSION
* RADIUSD_MINOR_VERSION
* RADIUSD_INCRM_VERSION
* RADIUSD_VERSION (integer representation of version)
* RADIUSD_VERSION_STRING
* RADIUSD_VERSION_COMMIT (latest commit hash if building from a git repo)

Git hash is also displayed in utilities that display version

11 years agoMore fixes to make it work with system libtool && jlibtool
Alan T. DeKok [Sat, 27 Oct 2012 15:57:19 +0000 (17:57 +0200)]
More fixes to make it work with system libtool && jlibtool

11 years agoTry to fix "home server dead" code
Alan T. DeKok [Sat, 27 Oct 2012 11:45:43 +0000 (13:45 +0200)]
Try to fix "home server dead" code

It was pretty horrific, and didn't make sense.  This simplification
seems to work

11 years agoMinor formatting fixes
Arran Cudbard-Bell [Sat, 27 Oct 2012 10:26:35 +0000 (11:26 +0100)]
Minor formatting fixes

11 years agoMerge pull request #118 from philmayers/cache-locking
Arran Cudbard-Bell [Sat, 27 Oct 2012 10:14:55 +0000 (03:14 -0700)]
Merge pull request #118 from philmayers/cache-locking

add locking to rlm_cache

11 years agoadd locking to rlm_cache
Phil Mayers [Fri, 26 Oct 2012 15:47:35 +0000 (16:47 +0100)]
add locking to rlm_cache

11 years agoAfter running it through the formatter
Alan T. DeKok [Sat, 27 Oct 2012 08:00:36 +0000 (10:00 +0200)]
After running it through the formatter

11 years agoFixes to work with system libtool
Alan T. DeKok [Sat, 27 Oct 2012 07:08:18 +0000 (09:08 +0200)]
Fixes to work with system libtool

11 years agoRemove last shred of libtool
Alan T. DeKok [Sat, 27 Oct 2012 06:59:06 +0000 (08:59 +0200)]
Remove last shred of libtool

WARNING: don't do "autoreconf", as it adds libtool back!
Instead, do "autoconf".

11 years agoUse redis escape function
Alan T. DeKok [Fri, 26 Oct 2012 11:46:05 +0000 (13:46 +0200)]
Use redis escape function

11 years agoUnderstand extended format attrs, too
Alan T. DeKok [Thu, 25 Oct 2012 12:03:56 +0000 (14:03 +0200)]
Understand extended format attrs, too

11 years agoCreate threads as joinable, not detached.
Iliya Peregoudov [Thu, 25 Oct 2012 07:29:42 +0000 (11:29 +0400)]
Create threads as joinable, not detached.
Stop and join all threads before detaching modules.

This prevents a crash on exit where the modules are free'd before
the threads stop using them.

11 years agoAdd proxim dictionary
Arran Cudbard-Bell [Thu, 25 Oct 2012 09:53:36 +0000 (10:53 +0100)]
Add proxim dictionary

11 years agoPass correct arguments to memcpy
Alan T. DeKok [Thu, 25 Oct 2012 08:10:22 +0000 (10:10 +0200)]
Pass correct arguments to memcpy

Copying pointers means you pass a pointer to the pointer.

11 years agoMerge branch 'master' of github.com:FreeRADIUS/freeradius-server
Alan T. DeKok [Thu, 25 Oct 2012 08:04:48 +0000 (10:04 +0200)]
Merge branch 'master' of github.com:FreeRADIUS/freeradius-server

11 years agoMerge pull request #112 from armitasp/master
Arran Cudbard-Bell [Wed, 24 Oct 2012 07:13:34 +0000 (00:13 -0700)]
Merge pull request #112 from armitasp/master

Minor formatting fix. add_cui should be add-cui

11 years agoMinor formatting fix. add_cui should be add-cui
Scott Armitage [Tue, 23 Oct 2012 19:36:11 +0000 (20:36 +0100)]
Minor formatting fix. add_cui should be add-cui

11 years agoMore formatting fixes
Arran Cudbard-Bell [Tue, 23 Oct 2012 13:08:19 +0000 (14:08 +0100)]
More formatting fixes

11 years agoImprove Kerberos support when using Heimdal
Ryan Steinmetz [Tue, 23 Oct 2012 11:30:33 +0000 (12:30 +0100)]
Improve Kerberos support when using Heimdal

- Allow specifying a keytab location
- Improved logging

Patch obtained from Thomas Kula <kula@tproa.net>

- Fix krb_auth parameters/casting
- Use strlcpy() instead of strncpy()
- Fix style issues

11 years agoDon't complain if there are triggers don't exist
Alan T. DeKok [Mon, 22 Oct 2012 15:45:44 +0000 (17:45 +0200)]
Don't complain if there are triggers don't exist

11 years agoFixup formatting and errors in cui policy and dependencies
Arran Cudbard-Bell [Mon, 22 Oct 2012 09:23:07 +0000 (10:23 +0100)]
Fixup formatting and errors in cui policy and dependencies

Include sql cui queries by default, as the cuisql module won't be
instantiated in the default config.

Change cui_has_key value to make it clear that it should be changed.

Use string (yes/no) for bool in cui_require_operator_name for consistancy,
ideally the parser would pre-evaluate comparisons between literal strings,
but the performance hit does not outweigh consistency.

Remove spurious spaces around conditions.

Literal strings should be literal (i.e. single quotes).

Packet-Type is still provided by a magic xlat expension.

Substitute 8 spaces for tabs (config files have same formatting rules as C src)

Use outer.request:EAP-Message to check whether were in an inner or outer tunnel,
should be forwards compatible.

${} values are pre-expanded, so do not require double quotes.

control:Proxy-To-Realm is not a magic attribute, it's a standard attribute in the
control list (even when set by rlm_realm).

cui virtual module does not have xlat method, should use cuisql.

11 years agoMerge branch 'master' of github.com:FreeRADIUS/freeradius-server
Arran Cudbard-Bell [Mon, 22 Oct 2012 08:34:42 +0000 (09:34 +0100)]
Merge branch 'master' of github.com:FreeRADIUS/freeradius-server

11 years agoMerge pull request #110 from armitasp/master
Arran Cudbard-Bell [Mon, 22 Oct 2012 08:33:44 +0000 (01:33 -0700)]
Merge pull request #110 from armitasp/master

Updated CUI Policy

11 years agoMinor formatting fixes
Arran Cudbard-Bell [Sun, 21 Oct 2012 16:58:18 +0000 (17:58 +0100)]
Minor formatting fixes

11 years agoChanged sites-available/default. Documented the use of cui
Scott Armitage [Sun, 21 Oct 2012 16:49:56 +0000 (17:49 +0100)]
Changed sites-available/default. Documented the use of cui

11 years agoChanged sites-available/inner-tunnel. Documented the use of cui
Scott Armitage [Sun, 21 Oct 2012 16:28:17 +0000 (17:28 +0100)]
Changed sites-available/inner-tunnel. Documented the use of cui

11 years agoChanged cui policy. Changed the updating of the cui in the database to occur in the...
Scott Armitage [Sun, 21 Oct 2012 16:13:31 +0000 (17:13 +0100)]
Changed cui policy. Changed the updating of the cui in the database to occur in the cui.post-auth.  Changed mods-available/cui module name

11 years agoChanged cui policy. Added settings to (optionally) make requirement of operator name...
Scott Armitage [Sun, 21 Oct 2012 15:58:19 +0000 (16:58 +0100)]
Changed cui policy. Added settings to (optionally) make requirement of operator name a pre-requisite for cui generation

11 years agoChanged cui policy. Added a cui.pre-proxy section to request a cui when proxying...
Scott Armitage [Sun, 21 Oct 2012 15:39:54 +0000 (16:39 +0100)]
Changed cui policy. Added a cui.pre-proxy section to request a cui when proxying authentication requests

11 years agoChanged cui policy. cui.authorize requires a flag is set in client definition. This...
Scott Armitage [Sun, 21 Oct 2012 15:28:23 +0000 (16:28 +0100)]
Changed cui policy. cui.authorize requires a flag is set in client definition.  This allows cui request on a per client basis

11 years agoAdded the cui hash to cui policy
Scott Armitage [Sun, 21 Oct 2012 15:20:13 +0000 (16:20 +0100)]
Added the cui hash to cui policy

11 years agoMade packet data len "size_t".
Alan T. DeKok [Sat, 20 Oct 2012 07:37:36 +0000 (09:37 +0200)]
Made packet data len "size_t".

Only one place needs it to be negative: the read from the socket.
For the rest of the code, it is ALWAYS positive.

As part of this, changed a few other variables, too.
And uses "%zu" for printing "size_t" variables.  C99 is everywhere.
If you want to build the server on a non-C99 compiler, go away.

11 years agoFix compiler warnings
Alan T. DeKok [Sat, 20 Oct 2012 07:26:22 +0000 (09:26 +0200)]
Fix compiler warnings

11 years agoMerge branch 'master' of github.com:FreeRADIUS/freeradius-server
Alan T. DeKok [Sat, 20 Oct 2012 07:05:41 +0000 (09:05 +0200)]
Merge branch 'master' of github.com:FreeRADIUS/freeradius-server

11 years agoSubstitute 'signature' for 'Request Authenticator' or 'Response Authenticator' where...
Arran Cudbard-Bell [Thu, 18 Oct 2012 10:39:42 +0000 (11:39 +0100)]
Substitute 'signature' for 'Request Authenticator' or 'Response Authenticator' where appropriate

11 years agoAdd base64tohex to allow values to be written to IP addresses, integers etc
Arran Cudbard-Bell [Wed, 17 Oct 2012 14:59:47 +0000 (15:59 +0100)]
Add base64tohex to allow values to be written to IP addresses, integers etc

Remove base64tostr (will add tostring expansion later)

Rename strtobase64 to tobase64

11 years agofixes #108 Add function to convert FR value pair types to network byte order
Arran Cudbard-Bell [Wed, 17 Oct 2012 14:32:41 +0000 (15:32 +0100)]
fixes #108 Add function to convert FR value pair types to network byte order

11 years agoRemove dependency on stdbool and use FRs bool constants
Arran Cudbard-Bell [Tue, 16 Oct 2012 09:45:39 +0000 (10:45 +0100)]
Remove dependency on stdbool and use FRs bool constants

11 years agoMove boolean constants to libradius
Arran Cudbard-Bell [Tue, 16 Oct 2012 09:43:05 +0000 (10:43 +0100)]
Move boolean constants to libradius

11 years agofixup formatting/warning
Arran Cudbard-Bell [Mon, 15 Oct 2012 20:43:57 +0000 (21:43 +0100)]
fixup formatting/warning

11 years agoAdd different operators handle to rlm_python
Metasov [Fri, 14 Oct 2011 14:49:23 +0000 (17:49 +0300)]
Add different operators handle to rlm_python

11 years agoremove compilation error messages (As noted by Alan Buxey)
Arran Cudbard-Bell [Mon, 15 Oct 2012 13:47:42 +0000 (14:47 +0100)]
remove compilation error messages (As noted by Alan Buxey)

removes the following at compile time:

dhcp.c: In function ‘fr_dhcp_add_arp_entry’:
dhcp.c:1561: warning: format ‘%lu’ expects type ‘long unsigned int’,
but argument 2 has type ‘unsigned int’
dhcp.c:1561: warning: format ‘%lu’ expects type ‘long unsigned int’,
but argument 3 has type ‘size_t’

11 years agoOnly print out user authorized message if the ldap module is actually being used...
Arran Cudbard-Bell [Mon, 15 Oct 2012 08:42:22 +0000 (09:42 +0100)]
Only print out user authorized message if the ldap module is actually being used for user authorization

11 years agoAdd option to disable password check
Arran Cudbard-Bell [Mon, 15 Oct 2012 08:33:38 +0000 (09:33 +0100)]
Add option to disable password check

11 years agoAdd base64 encoding/decoding library
Arran Cudbard-Bell [Sun, 14 Oct 2012 19:59:31 +0000 (20:59 +0100)]
Add base64 encoding/decoding library

Add %{base64:} expansion to encode the raw octets of an attribute

Add %{strtobase64:} expansion to encode a string to base64

Add %{base64tostr:} expansion to decode a base64 string

11 years agoFixup radius_xlat calls to pass inst (was missed from previous commit)
Arran Cudbard-Bell [Sun, 14 Oct 2012 16:31:14 +0000 (17:31 +0100)]
Fixup radius_xlat calls to pass inst (was missed from previous commit)

Minor reformatting

11 years agoMerge pull request #105 from arr2036/master
Arran Cudbard-Bell [Fri, 12 Oct 2012 15:25:04 +0000 (08:25 -0700)]
Merge pull request #105 from arr2036/master

Fix issue posted to list regarding null check query

11 years agoIf no check query is configured, skip it and run the reply queries
Arran Cudbard-Bell [Fri, 12 Oct 2012 14:34:50 +0000 (15:34 +0100)]
If no check query is configured, skip it and run the reply queries
Fix authorize function to be more sane

11 years agoasserts aren't part of normal code path
Alan T. DeKok [Mon, 8 Oct 2012 20:01:22 +0000 (16:01 -0400)]
asserts aren't part of normal code path

11 years agoMerge branch 'master' of github.com:FreeRADIUS/freeradius-server
Alan T. DeKok [Mon, 8 Oct 2012 19:59:48 +0000 (15:59 -0400)]
Merge branch 'master' of github.com:FreeRADIUS/freeradius-server

11 years agoMerge pull request #102 from philmayers/misc-fixes
Alan DeKok [Sun, 7 Oct 2012 16:40:45 +0000 (09:40 -0700)]
Merge pull request #102 from philmayers/misc-fixes

3 minor fixes - regexp and foreach related

11 years agofix pairmake->pairmake_xlat->pairmake recursive calls with regexps; lets regexps...
Phil Mayers [Sat, 6 Oct 2012 13:00:47 +0000 (14:00 +0100)]
fix pairmake->pairmake_xlat->pairmake recursive calls with regexps; lets regexps work in "users" files again

11 years agodifferent numbers of foreach and xlats - use separate loop
Phil Mayers [Sat, 6 Oct 2012 12:53:32 +0000 (13:53 +0100)]
different numbers of foreach and xlats - use separate loop

11 years agoconvert the VP we are passed rather than xlat the check->name; makes regex matches...
Phil Mayers [Sat, 6 Oct 2012 12:34:01 +0000 (13:34 +0100)]
convert the VP we are passed rather than xlat the check->name; makes regex matches against multiple attributes work again

11 years agoMerge pull request #101 from philmayers/escape-context2
Alan DeKok [Fri, 5 Oct 2012 12:07:43 +0000 (05:07 -0700)]
Merge pull request #101 from philmayers/escape-context2

Re-work escape functions to have REQUEST* and context variables

11 years agopass redis instance to escape function - currently unused
Phil Mayers [Fri, 21 Sep 2012 17:06:21 +0000 (18:06 +0100)]
pass redis instance to escape function - currently unused

11 years agopass LDAP instance to escape function - currently unused
Phil Mayers [Fri, 21 Sep 2012 17:05:31 +0000 (18:05 +0100)]
pass LDAP instance to escape function - currently unused

11 years agorlm_sqlcounter: remove SQL escaping, let the SQL module handle it
Phil Mayers [Fri, 21 Sep 2012 17:04:03 +0000 (18:04 +0100)]
rlm_sqlcounter: remove SQL escaping, let the SQL module handle it

11 years agorlm_sqlippool: pass sql instance to sql escape func
Phil Mayers [Fri, 21 Sep 2012 16:59:37 +0000 (17:59 +0100)]
rlm_sqlippool: pass sql instance to sql escape func

11 years agorlm_sql_log: use escape function argument to make safe-characters per-instance rather...
Phil Mayers [Fri, 21 Sep 2012 16:57:42 +0000 (17:57 +0100)]
rlm_sql_log: use escape function argument to make safe-characters per-instance rather than global

11 years agorlm_sql: use escape function argument to make safe-characters per-instance rather...
Phil Mayers [Fri, 21 Sep 2012 16:55:48 +0000 (17:55 +0100)]
rlm_sql: use escape function argument to make safe-characters per-instance rather than global

11 years agono-op escape function no longer needed
Phil Mayers [Fri, 21 Sep 2012 16:51:56 +0000 (17:51 +0100)]
no-op escape function no longer needed

11 years agoremove dead code path
Phil Mayers [Fri, 21 Sep 2012 16:49:34 +0000 (17:49 +0100)]
remove dead code path

11 years agoadd REQUEST* and void* to escape functions
Phil Mayers [Fri, 21 Sep 2012 16:47:25 +0000 (17:47 +0100)]
add REQUEST* and void* to escape functions

11 years agoremove escape function from xlat handlers; perform escaping *once* in decode_attribute
Phil Mayers [Fri, 5 Oct 2012 11:52:12 +0000 (12:52 +0100)]
remove escape function from xlat handlers; perform escaping *once* in decode_attribute

11 years agoadd extra argument to radius_xlat for escape function context - currently unused
Phil Mayers [Fri, 21 Sep 2012 15:27:38 +0000 (16:27 +0100)]
add extra argument to radius_xlat for escape function context - currently unused

11 years agofix soh_xlat function prototype; fix warning about const discarded
Phil Mayers [Fri, 21 Sep 2012 14:42:44 +0000 (15:42 +0100)]
fix soh_xlat function prototype; fix warning about const discarded

11 years agofix redis_xlat function prototype and remove cast so compiler can detect errors
Phil Mayers [Fri, 21 Sep 2012 14:41:59 +0000 (15:41 +0100)]
fix redis_xlat function prototype and remove cast so compiler can detect errors

11 years agofix cache_xlat function prototype and remove cast so compiler can detect errors
Phil Mayers [Fri, 21 Sep 2012 14:41:23 +0000 (15:41 +0100)]
fix cache_xlat function prototype and remove cast so compiler can detect errors

11 years agofix sql_xlat function prototype and remove cast so compiler can detect errors
Phil Mayers [Fri, 21 Sep 2012 14:41:00 +0000 (15:41 +0100)]
fix sql_xlat function prototype and remove cast so compiler can detect errors

11 years agoMerge pull request #87 from armitasp/master
Arran Cudbard-Bell [Thu, 4 Oct 2012 16:11:40 +0000 (09:11 -0700)]
Merge pull request #87 from armitasp/master

Minor policy.d/operator-name fix

11 years agoMerge pull request #99 from sionescu/wip-fix-with-system-libtool
Alan DeKok [Thu, 4 Oct 2012 10:40:51 +0000 (03:40 -0700)]
Merge pull request #99 from sionescu/wip-fix-with-system-libtool

Fix --with-system-libltdl and --with-system-libtool

11 years agoFix formatting
Arran Cudbard-Bell [Wed, 3 Oct 2012 17:31:21 +0000 (12:31 -0500)]
Fix formatting

11 years agoMerge pull request #100 from mcnewton/rlm_pap_tidy
Arran Cudbard-Bell [Wed, 3 Oct 2012 17:29:29 +0000 (10:29 -0700)]
Merge pull request #100 from mcnewton/rlm_pap_tidy

Rlm pap tidy

11 years agoupdate upgrade documentation with User-Password deprecation note
Matthew Newton [Wed, 3 Oct 2012 00:32:58 +0000 (01:32 +0100)]
update upgrade documentation with User-Password deprecation note

11 years agoremove auth check against User-Password, add autz warning
Matthew Newton [Wed, 3 Oct 2012 00:14:44 +0000 (01:14 +0100)]
remove auth check against User-Password, add autz warning

11 years agoLook for /usr/local/etc/freeradius and use it in preference to /etc/freeradius
Arran Cudbard-Bell [Wed, 3 Oct 2012 00:02:40 +0000 (19:02 -0500)]
Look for /usr/local/etc/freeradius and use it in preference to /etc/freeradius

11 years agoFix --with-system-libltdl and --with-system-libtool
Stelian Ionescu [Tue, 2 Oct 2012 18:00:24 +0000 (20:00 +0200)]
Fix --with-system-libltdl and --with-system-libtool

11 years agoFind the sql headers
Alan T. DeKok [Sun, 30 Sep 2012 06:42:26 +0000 (08:42 +0200)]
Find the sql headers

11 years agoMerge pull request #54 from mcnewton/patch-client-cert
Alan DeKok [Sun, 30 Sep 2012 06:40:10 +0000 (23:40 -0700)]
Merge pull request #54 from mcnewton/patch-client-cert

Add require_client_cert options to EAP-PEAP/TTLS

11 years agoRemove unused definitions
Alan T. DeKok [Sat, 29 Sep 2012 05:10:06 +0000 (07:10 +0200)]
Remove unused definitions

11 years agoadd User-Password warning to rlm_chap
Matthew Newton [Fri, 28 Sep 2012 23:16:38 +0000 (00:16 +0100)]
add User-Password warning to rlm_chap

11 years agoremove ifs and returns from attribute detection loop
Matthew Newton [Fri, 28 Sep 2012 22:12:03 +0000 (23:12 +0100)]
remove ifs and returns from attribute detection loop

11 years agobreak pap auth up into smaller functions, remove goto mess
Matthew Newton [Fri, 28 Sep 2012 21:26:54 +0000 (22:26 +0100)]
break pap auth up into smaller functions, remove goto mess

11 years agostart tidy of rlm_pap - move crypt to separate function
Matthew Newton [Fri, 28 Sep 2012 16:51:58 +0000 (17:51 +0100)]
start tidy of rlm_pap - move crypt to separate function

11 years agoremove encryption_scheme option & related code from rlm_pap
Matthew Newton [Fri, 28 Sep 2012 15:58:37 +0000 (16:58 +0100)]
remove encryption_scheme option & related code from rlm_pap

11 years agoMerge pull request #95 from alanbuxey/master
Arran Cudbard-Bell [Fri, 28 Sep 2012 19:10:50 +0000 (12:10 -0700)]
Merge pull request #95 from alanbuxey/master

better default interop with eduroam

11 years agoadded better compatibility with eduroam requirements
Alan Buxey [Fri, 28 Sep 2012 19:02:12 +0000 (20:02 +0100)]
added better compatibility with eduroam requirements

eduroam use these 2 attributes…by adding them to the default
configuration we should not cause other usage issues but we will make
FreeRADIUS more 'out of the box' ready for eduroam

11 years agoFix to work with jlibtool
Alan T. DeKok [Fri, 28 Sep 2012 11:41:18 +0000 (13:41 +0200)]
Fix to work with jlibtool

11 years agoAdded Makefile for new build system
Alan T. DeKok [Fri, 28 Sep 2012 11:24:49 +0000 (13:24 +0200)]
Added Makefile for new build system

11 years agoInclude all sub-modules, if they're built
Alan T. DeKok [Fri, 28 Sep 2012 11:13:31 +0000 (13:13 +0200)]
Include all sub-modules, if they're built

11 years agoMerge pull request #94 from mcnewton/auth_tidy
Arran Cudbard-Bell [Fri, 28 Sep 2012 09:13:21 +0000 (02:13 -0700)]
Merge pull request #94 from mcnewton/auth_tidy

Auth tidy

11 years agoAdd options for -4 and -6 IP families, like radclient.
Alan T. DeKok [Fri, 28 Sep 2012 08:29:07 +0000 (10:29 +0200)]
Add options for -4 and -6 IP families, like radclient.

Patch from John Dennis

11 years ago rse PPPHint better
Alan T. DeKok [Fri, 28 Sep 2012 08:28:28 +0000 (10:28 +0200)]
 rse PPPHint better

11 years agofix encryption_scheme option in rlm_pap, and update to Cleartext-Password
Matthew Newton [Thu, 27 Sep 2012 22:56:30 +0000 (23:56 +0100)]
fix encryption_scheme option in rlm_pap, and update to Cleartext-Password

11 years agotidy comments in auth.c
Matthew Newton [Thu, 27 Sep 2012 22:46:00 +0000 (23:46 +0100)]
tidy comments in auth.c

11 years agomove User-Password warning from auth.c to rlm_pap
Matthew Newton [Thu, 27 Sep 2012 22:38:57 +0000 (23:38 +0100)]
move User-Password warning from auth.c to rlm_pap

11 years agoDon't copy User-Password -> Cleartext-Password. They need to reconfigure if it breaks.
Matthew Newton [Thu, 27 Sep 2012 22:18:08 +0000 (23:18 +0100)]
Don't copy User-Password -> Cleartext-Password. They need to reconfigure if it breaks.