move User-Password warning from auth.c to rlm_pap
authorMatthew Newton <mcn4@leicester.ac.uk>
Thu, 27 Sep 2012 22:38:57 +0000 (23:38 +0100)
committerMatthew Newton <mcn4@leicester.ac.uk>
Thu, 27 Sep 2012 23:06:31 +0000 (00:06 +0100)
src/main/auth.c
src/modules/rlm_pap/rlm_pap.c

index 6124b6f..f1bfdd1 100644 (file)
@@ -216,17 +216,6 @@ static int rad_check_password(REQUEST *request)
        }
 
        /*
-        *      Sanity check and warn on existance of legacy
-        *      User-Password control attribute.
-        */
-       if (pairfind(request->config_items, PW_USER_PASSWORD, 0) != NULL) {
-               RDEBUG("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");
-               RDEBUG("!!! Please update your configuration so that the \"known good\"               !!!");
-               RDEBUG("!!! clear text password is in Cleartext-Password, and not in User-Password. !!!");
-               RDEBUG("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");
-       }
-
-       /*
         *      Check that Auth-Type has been set, and reject if not.
         *
         *      Do quick checks to see if Cleartext-Password or Crypt-Password have
index cda4636..e793b6c 100644 (file)
@@ -546,6 +546,10 @@ static int pap_authenticate(void *instance, REQUEST *request)
                for (vp = request->config_items; vp != NULL; vp = vp->next) {
                        switch (vp->attribute) {
                        case PW_USER_PASSWORD: /* deprecated */
+                               RDEBUG("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");
+                               RDEBUG("!!! Please update your configuration so that the \"known good\"               !!!");
+                               RDEBUG("!!! clear text password is in Cleartext-Password, and not in User-Password. !!!");
+                               RDEBUG("!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");
                        case PW_CLEARTEXT_PASSWORD: /* preferred */
                                goto do_clear;