src/main/conffile.c

   1 /*
   2  * conffile.c   Read the radiusd.conf file.
   3  *
   4  *              Yep I should learn to use lex & yacc, or at least
   5  *              write a decent parser. I know how to do that, really :)
   6  *              miquels@cistron.nl
   7  *
   8  * Version:     $Id$
   9  *
  10  *   This program is free software; you can redistribute it and/or modify
  11  *   it under the terms of the GNU General Public License as published by
  12  *   the Free Software Foundation; either version 2 of the License, or
  13  *   (at your option) any later version.
  14  *
  15  *   This program is distributed in the hope that it will be useful,
  16  *   but WITHOUT ANY WARRANTY; without even the implied warranty of
  17  *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  18  *   GNU General Public License for more details.
  19  *
  20  *   You should have received a copy of the GNU General Public License
  21  *   along with this program; if not, write to the Free Software
  22  *   Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  23  *
  24  * Copyright 2000,2006  The FreeRADIUS server project
  25  * Copyright 2000  Miquel van Smoorenburg <miquels@cistron.nl>
  26  * Copyright 2000  Alan DeKok <aland@ox.org>
  27  */
  28
  29 RCSID("$Id$")
  30
  31 #include <freeradius-devel/radiusd.h>
  32 #include <freeradius-devel/parser.h>
  33 #include <freeradius-devel/rad_assert.h>
  34
  35 #ifdef HAVE_DIRENT_H
  36 #include <dirent.h>
  37 #endif
  38
  39 #ifdef HAVE_SYS_STAT_H
  40 #include <sys/stat.h>
  41 #endif
  42
  43 #include <ctype.h>
  44
  45 bool check_config = false;
  46
  47 typedef enum conf_property {
  48         CONF_PROPERTY_INVALID = 0,
  49         CONF_PROPERTY_NAME,
  50         CONF_PROPERTY_INSTANCE,
  51 } CONF_PROPERTY;
  52
  53 static const FR_NAME_NUMBER conf_property_name[] = {
  54         { "name",       CONF_PROPERTY_NAME},
  55         { "instance",   CONF_PROPERTY_INSTANCE},
  56
  57         {  NULL , -1 }
  58 };
  59
  60 typedef enum conf_type {
  61         CONF_ITEM_INVALID = 0,
  62         CONF_ITEM_PAIR,
  63         CONF_ITEM_SECTION,
  64         CONF_ITEM_DATA
  65 } CONF_ITEM_TYPE;
  66
  67 struct conf_item {
  68         struct conf_item *next;         //!< Sibling.
  69         struct conf_part *parent;       //!< Parent.
  70         int lineno;                     //!< The line number the config item began on.
  71         char const *filename;           //!< The file the config item was parsed from.
  72         CONF_ITEM_TYPE type;            //!< Whether the config item is a config_pair, conf_section or conf_data.
  73 };
  74
  75 /** Configuration AVP similar to a VALUE_PAIR
  76  *
  77  */
  78 struct conf_pair {
  79         CONF_ITEM       item;
  80         char const      *attr;          //!< Attribute name
  81         char const      *value;         //!< Attribute value
  82         FR_TOKEN        op;             //!< Operator e.g. =, :=
  83         FR_TOKEN        lhs_type;       //!< Name quoting style T_(DOUBLE|SINGLE|BACK)_QUOTE_STRING or T_BARE_WORD.
  84         FR_TOKEN        rhs_type;       //!< Value Quoting style T_(DOUBLE|SINGLE|BACK)_QUOTE_STRING or T_BARE_WORD.
  85         bool            pass2;          //!< do expansion in pass2.
  86         bool            parsed;         //!< Was this item used during parsing?
  87 };
  88
  89 /** Internal data that is associated with a configuration section
  90  *
  91  */
  92 struct conf_data {
  93         CONF_ITEM       item;
  94         char const      *name;
  95         int             flag;
  96         void            *data;          //!< User data
  97         void            (*free)(void *);        //!< Free user data function
  98 };
  99
 100 struct conf_part {
 101         CONF_ITEM       item;
 102         char const      *name1;         //!< First name token.  Given ``foo bar {}`` would be ``foo``.
 103         char const      *name2;         //!< Second name token. Given ``foo bar {}`` would be ``bar``.
 104
 105         FR_TOKEN        name2_type;     //!< The type of quoting around name2.
 106
 107         CONF_ITEM       *children;
 108         CONF_ITEM       *tail;          //!< For speed.
 109         CONF_SECTION    *template;
 110
 111         rbtree_t        *pair_tree;     //!< and a partridge..
 112         rbtree_t        *section_tree;  //!< no jokes here.
 113         rbtree_t        *name2_tree;    //!< for sections of the same name2
 114         rbtree_t        *data_tree;
 115
 116         void            *base;
 117         int             depth;
 118
 119         CONF_PARSER const *variables;
 120 };
 121
 122 typedef struct cf_file_t {
 123         char const      *filename;
 124         CONF_SECTION    *cs;
 125         struct stat     buf;
 126 } cf_file_t;
 127
 128 CONF_SECTION *root_config = NULL;
 129 bool cf_new_escape = false;
 130
 131
 132 static int              cf_data_add_internal(CONF_SECTION *cs, char const *name, void *data,
 133                                              void (*data_free)(void *), int flag);
 134
 135 static void             *cf_data_find_internal(CONF_SECTION const *cs, char const *name, int flag);
 136
 137 static char const       *cf_expand_variables(char const *cf, int *lineno,
 138                                              CONF_SECTION *outercs,
 139                                              char *output, size_t outsize,
 140                                              char const *input, bool *soft_fail);
 141
 142 static int cf_file_include(CONF_SECTION *cs, char const *filename_in);
 143
 144
 145
 146 /*
 147  *      Isolate the scary casts in these tiny provably-safe functions
 148  */
 149
 150 /** Cast a CONF_ITEM to a CONF_PAIR
 151  *
 152  */
 153 CONF_PAIR *cf_item_to_pair(CONF_ITEM const *ci)
 154 {
 155         CONF_PAIR *out;
 156
 157         if (ci == NULL) return NULL;
 158
 159         rad_assert(ci->type == CONF_ITEM_PAIR);
 160
 161         memcpy(&out, &ci, sizeof(out));
 162         return out;
 163 }
 164
 165 /** Cast a CONF_ITEM to a CONF_SECTION
 166  *
 167  */
 168 CONF_SECTION *cf_item_to_section(CONF_ITEM const *ci)
 169 {
 170         CONF_SECTION *out;
 171
 172         if (ci == NULL) return NULL;
 173
 174         rad_assert(ci->type == CONF_ITEM_SECTION);
 175
 176         memcpy(&out, &ci, sizeof(out));
 177         return out;
 178 }
 179
 180 /** Cast a CONF_PAIR to a CONF_ITEM
 181  *
 182  */
 183 CONF_ITEM *cf_pair_to_item(CONF_PAIR const *cp)
 184 {
 185         CONF_ITEM *out;
 186
 187         if (cp == NULL) return NULL;
 188
 189         memcpy(&out, &cp, sizeof(out));
 190         return out;
 191 }
 192
 193 /** Cast a CONF_SECTION to a CONF_ITEM
 194  *
 195  */
 196 CONF_ITEM *cf_section_to_item(CONF_SECTION const *cs)
 197 {
 198         CONF_ITEM *out;
 199
 200         if (cs == NULL) return NULL;
 201
 202         memcpy(&out, &cs, sizeof(out));
 203         return out;
 204 }
 205
 206 /** Cast CONF_DATA to a CONF_ITEM
 207  *
 208  */
 209 static CONF_ITEM *cf_data_to_item(CONF_DATA const *cd)
 210 {
 211         CONF_ITEM *out;
 212
 213         if (cd == NULL) {
 214                 return NULL;
 215         }
 216
 217         memcpy(&out, &cd, sizeof(out));
 218         return out;
 219 }
 220
 221 static int _cf_data_free(CONF_DATA *cd)
 222 {
 223         if (cd->free) cd->free(cd->data);
 224
 225         return 0;
 226 }
 227
 228 /*
 229  *      rbtree callback function
 230  */
 231 static int pair_cmp(void const *a, void const *b)
 232 {
 233         CONF_PAIR const *one = a;
 234         CONF_PAIR const *two = b;
 235
 236         return strcmp(one->attr, two->attr);
 237 }
 238
 239
 240 /*
 241  *      rbtree callback function
 242  */
 243 static int section_cmp(void const *a, void const *b)
 244 {
 245         CONF_SECTION const *one = a;
 246         CONF_SECTION const *two = b;
 247
 248         return strcmp(one->name1, two->name1);
 249 }
 250
 251
 252 /*
 253  *      rbtree callback function
 254  */
 255 static int name2_cmp(void const *a, void const *b)
 256 {
 257         CONF_SECTION const *one = a;
 258         CONF_SECTION const *two = b;
 259
 260         rad_assert(strcmp(one->name1, two->name1) == 0);
 261
 262         if (!one->name2 && !two->name2) return 0;
 263         if (one->name2 && !two->name2) return -1;
 264         if (!one->name2 && two->name2) return +1;
 265
 266         return strcmp(one->name2, two->name2);
 267 }
 268
 269
 270 /*
 271  *      rbtree callback function
 272  */
 273 static int data_cmp(void const *a, void const *b)
 274 {
 275         int rcode;
 276
 277         CONF_DATA const *one = a;
 278         CONF_DATA const *two = b;
 279
 280         rcode = one->flag - two->flag;
 281         if (rcode != 0) return rcode;
 282
 283         return strcmp(one->name, two->name);
 284 }
 285
 286 /*
 287  *      Functions for tracking filenames.
 288  */
 289 static int filename_cmp(void const *a, void const *b)
 290 {
 291         cf_file_t const *one = a;
 292         cf_file_t const *two = b;
 293
 294         if (one->buf.st_dev < two->buf.st_dev) return -1;
 295         if (one->buf.st_dev > two->buf.st_dev) return +1;
 296
 297         if (one->buf.st_ino < two->buf.st_ino) return -1;
 298         if (one->buf.st_ino > two->buf.st_ino) return +1;
 299
 300         return 0;
 301 }
 302
 303 static FILE *cf_file_open(CONF_SECTION *cs, char const *filename)
 304 {
 305         cf_file_t *file;
 306         CONF_DATA *cd;
 307         CONF_SECTION *top;
 308         rbtree_t *tree;
 309         int fd;
 310         FILE *fp;
 311
 312         top = cf_top_section(cs);
 313         cd = cf_data_find_internal(top, "filename", 0);
 314         if (!cd) return NULL;
 315
 316         tree = cd->data;
 317
 318         fp = fopen(filename, "r");
 319         if (!fp) {
 320                 ERROR("Unable to open file \"%s\": %s",
 321                       filename, fr_syserror(errno));
 322                 return NULL;
 323         }
 324
 325         fd = fileno(fp);
 326
 327         file = talloc(tree, cf_file_t);
 328         if (!file) {
 329                 fclose(fp);
 330                 return NULL;
 331         }
 332
 333         file->filename = filename;
 334         file->cs = cs;
 335
 336         if (fstat(fd, &file->buf) == 0) {
 337 #ifdef S_IWOTH
 338                 if ((file->buf.st_mode & S_IWOTH) != 0) {
 339                         ERROR("Configuration file %s is globally writable.  "
 340                               "Refusing to start due to insecure configuration.", filename);
 341
 342                         fclose(fp);
 343                         talloc_free(file);
 344                         return NULL;
 345                 }
 346 #endif
 347         }
 348
 349         /*
 350          *      We can include the same file twice.  e.g. when it
 351          *      contains common definitions, such as for SQL.
 352          *
 353          *      Though the admin should really use templates for that.
 354          */
 355         if (!rbtree_insert(tree, file)) {
 356                 talloc_free(file);
 357         }
 358
 359         return fp;
 360 }
 361
 362 /*
 363  *      Do some checks on the file
 364  */
 365 static bool cf_file_check(CONF_SECTION *cs, char const *filename, bool check_perms)
 366 {
 367         cf_file_t *file;
 368         CONF_DATA *cd;
 369         CONF_SECTION *top;
 370         rbtree_t *tree;
 371
 372         top = cf_top_section(cs);
 373         cd = cf_data_find_internal(top, "filename", 0);
 374         if (!cd) return false;
 375
 376         tree = cd->data;
 377
 378         file = talloc(tree, cf_file_t);
 379         if (!file) return false;
 380
 381         file->filename = filename;
 382         file->cs = cs;
 383
 384         if (stat(filename, &file->buf) < 0) {
 385                 ERROR("Unable to check file \"%s\": %s", filename, fr_syserror(errno));
 386                 talloc_free(file);
 387                 return false;
 388         }
 389
 390         if (!check_perms) {
 391                 talloc_free(file);
 392                 return true;
 393         }
 394
 395 #ifdef S_IWOTH
 396         if ((file->buf.st_mode & S_IWOTH) != 0) {
 397                 ERROR("Configuration file %s is globally writable.  "
 398                       "Refusing to start due to insecure configuration.", filename);
 399                 talloc_free(file);
 400                 return false;
 401         }
 402 #endif
 403
 404         /*
 405          *      It's OK to include the same file twice...
 406          */
 407         if (!rbtree_insert(tree, file)) {
 408                 talloc_free(file);
 409         }
 410
 411         return true;
 412
 413 }
 414
 415
 416 typedef struct cf_file_callback_t {
 417         int             rcode;
 418         rb_walker_t     callback;
 419         CONF_SECTION    *modules;
 420 } cf_file_callback_t;
 421
 422
 423 /*
 424  *      Return 0 for keep going, 1 for stop.
 425  */
 426 static int file_callback(void *ctx, void *data)
 427 {
 428         cf_file_callback_t *cb = ctx;
 429         cf_file_t *file = data;
 430         struct stat buf;
 431
 432         /*
 433          *      The file doesn't exist or we can no longer read it.
 434          */
 435         if (stat(file->filename, &buf) < 0) {
 436                 cb->rcode = CF_FILE_ERROR;
 437                 return 1;
 438         }
 439
 440         /*
 441          *      The file changed, we'll need to re-read it.
 442          */
 443         if (buf.st_mtime != file->buf.st_mtime) {
 444
 445                 if (cb->callback(cb->modules, file->cs)) {
 446                         cb->rcode |= CF_FILE_MODULE;
 447                         DEBUG3("HUP: Changed module file %s", file->filename);
 448                 } else {
 449                         DEBUG3("HUP: Changed config file %s", file->filename);
 450                         cb->rcode |= CF_FILE_CONFIG;
 451                 }
 452         }
 453
 454         return 0;
 455 }
 456
 457
 458 /*
 459  *      See if any of the files have changed.
 460  */
 461 int cf_file_changed(CONF_SECTION *cs, rb_walker_t callback)
 462 {
 463         CONF_DATA *cd;
 464         CONF_SECTION *top;
 465         cf_file_callback_t cb;
 466         rbtree_t *tree;
 467
 468         top = cf_top_section(cs);
 469         cd = cf_data_find_internal(top, "filename", 0);
 470         if (!cd) return true;
 471
 472         tree = cd->data;
 473
 474         cb.rcode = CF_FILE_NONE;
 475         cb.callback = callback;
 476         cb.modules = cf_section_sub_find(cs, "modules");
 477
 478         (void) rbtree_walk(tree, RBTREE_IN_ORDER, file_callback, &cb);
 479
 480         return cb.rcode;
 481 }
 482
 483 static int _cf_section_free(CONF_SECTION *cs)
 484 {
 485         /*
 486          *      Name1 and name2 are allocated contiguous with
 487          *      cs.
 488          */
 489         if (cs->pair_tree) {
 490                 rbtree_free(cs->pair_tree);
 491                 cs->pair_tree = NULL;
 492         }
 493         if (cs->section_tree) {
 494                 rbtree_free(cs->section_tree);
 495                 cs->section_tree = NULL;
 496         }
 497         if (cs->name2_tree) {
 498                 rbtree_free(cs->name2_tree);
 499                 cs->name2_tree = NULL;
 500         }
 501         if (cs->data_tree) {
 502                 rbtree_free(cs->data_tree);
 503                 cs->data_tree = NULL;
 504         }
 505
 506         return 0;
 507 }
 508
 509 /** Allocate a CONF_PAIR
 510  *
 511  * @param parent CONF_SECTION to hang this CONF_PAIR off of.
 512  * @param attr name.
 513  * @param value of CONF_PAIR.
 514  * @param op T_OP_EQ, T_OP_SET etc.
 515  * @param lhs_type T_BARE_WORD, T_DOUBLE_QUOTED_STRING, T_BACK_QUOTED_STRING
 516  * @param rhs_type T_BARE_WORD, T_DOUBLE_QUOTED_STRING, T_BACK_QUOTED_STRING
 517  * @return NULL on error, else a new CONF_SECTION parented by parent.
 518  */
 519 CONF_PAIR *cf_pair_alloc(CONF_SECTION *parent, char const *attr, char const *value,
 520                          FR_TOKEN op, FR_TOKEN lhs_type, FR_TOKEN rhs_type)
 521 {
 522         CONF_PAIR *cp;
 523
 524         rad_assert(fr_equality_op[op] || fr_assignment_op[op]);
 525         if (!attr) return NULL;
 526
 527         cp = talloc_zero(parent, CONF_PAIR);
 528         if (!cp) return NULL;
 529
 530         cp->item.type = CONF_ITEM_PAIR;
 531         cp->item.parent = parent;
 532         cp->lhs_type = lhs_type;
 533         cp->rhs_type = rhs_type;
 534         cp->op = op;
 535
 536         cp->attr = talloc_typed_strdup(cp, attr);
 537         if (!cp->attr) {
 538         error:
 539                 talloc_free(cp);
 540                 return NULL;
 541         }
 542
 543         if (value) {
 544                 cp->value = talloc_typed_strdup(cp, value);
 545                 if (!cp->value) goto error;
 546         }
 547
 548         return cp;
 549 }
 550
 551 /** Duplicate a CONF_PAIR
 552  *
 553  * @param parent to allocate new pair in.
 554  * @param cp to duplicate.
 555  * @return NULL on error, else a duplicate of the input pair.
 556  */
 557 CONF_PAIR *cf_pair_dup(CONF_SECTION *parent, CONF_PAIR *cp)
 558 {
 559         CONF_PAIR *new;
 560
 561         rad_assert(parent);
 562         rad_assert(cp);
 563
 564         new = cf_pair_alloc(parent, cp->attr, cf_pair_value(cp),
 565                             cp->op, cp->lhs_type, cp->rhs_type);
 566         if (!new) return NULL;
 567
 568         new->parsed = cp->parsed;
 569         new->item.lineno = cp->item.lineno;
 570
 571         /*
 572          *      Avoid mallocs if possible.
 573          */
 574         if (!cp->item.filename || (parent->item.filename && !strcmp(parent->item.filename, cp->item.filename))) {
 575                 new->item.filename = parent->item.filename;
 576         } else {
 577                 new->item.filename = talloc_strdup(new, cp->item.filename);
 578         }
 579
 580         return new;
 581 }
 582
 583 /** Add a configuration pair to a section
 584  *
 585  * @param parent section to add pair to.
 586  * @param cp to add.
 587  */
 588 void cf_pair_add(CONF_SECTION *parent, CONF_PAIR *cp)
 589 {
 590         cf_item_add(parent, cf_pair_to_item(cp));
 591 }
 592
 593 /** Allocate a CONF_SECTION
 594  *
 595  * @param parent CONF_SECTION to hang this CONF_SECTION off of.
 596  * @param name1 Primary name.
 597  * @param name2 Secondary name.
 598  * @return NULL on error, else a new CONF_SECTION parented by parent.
 599  */
 600 CONF_SECTION *cf_section_alloc(CONF_SECTION *parent, char const *name1, char const *name2)
 601 {
 602         CONF_SECTION *cs;
 603         char buffer[1024];
 604
 605         if (!name1) return NULL;
 606
 607         if (name2 && parent) {
 608                 if (strchr(name2, '$')) {
 609                         name2 = cf_expand_variables(parent->item.filename,
 610                                                     &parent->item.lineno,
 611                                                     parent,
 612                                                     buffer, sizeof(buffer), name2, NULL);
 613                         if (!name2) {
 614                                 ERROR("Failed expanding section name");
 615                                 return NULL;
 616                         }
 617                 }
 618         }
 619
 620         cs = talloc_zero(parent, CONF_SECTION);
 621         if (!cs) return NULL;
 622
 623         cs->item.type = CONF_ITEM_SECTION;
 624         cs->item.parent = parent;
 625
 626         cs->name1 = talloc_typed_strdup(cs, name1);
 627         if (!cs->name1) {
 628         error:
 629                 talloc_free(cs);
 630                 return NULL;
 631         }
 632
 633         if (name2) {
 634                 cs->name2 = talloc_typed_strdup(cs, name2);
 635                 if (!cs->name2) goto error;
 636         }
 637
 638         cs->pair_tree = rbtree_create(cs, pair_cmp, NULL, 0);
 639         if (!cs->pair_tree) goto error;
 640
 641         talloc_set_destructor(cs, _cf_section_free);
 642
 643         /*
 644          *      Don't create a data tree, it may not be needed.
 645          */
 646
 647         /*
 648          *      Don't create the section tree here, it may not
 649          *      be needed.
 650          */
 651
 652         if (parent) cs->depth = parent->depth + 1;
 653
 654         return cs;
 655 }
 656
 657 /** Duplicate a configuration section
 658  *
 659  * @note recursively duplicates any child sections.
 660  * @note does not duplicate any data associated with a section, or its child sections.
 661  *
 662  * @param parent section (may be NULL).
 663  * @param cs to duplicate.
 664  * @param name1 of new section.
 665  * @param name2 of new section.
 666  * @param copy_meta Copy additional meta data for a section (like template, base, depth and variables).
 667  * @return a duplicate of the existing section, or NULL on error.
 668  */
 669 CONF_SECTION *cf_section_dup(CONF_SECTION *parent, CONF_SECTION const *cs,
 670                              char const *name1, char const *name2, bool copy_meta)
 671 {
 672         CONF_SECTION *new, *subcs;
 673         CONF_PAIR *cp;
 674         CONF_ITEM *ci;
 675
 676         new = cf_section_alloc(parent, name1, name2);
 677
 678         if (copy_meta) {
 679                 new->template = cs->template;
 680                 new->base = cs->base;
 681                 new->depth = cs->depth;
 682                 new->variables = cs->variables;
 683         }
 684
 685         new->item.lineno = cs->item.lineno;
 686
 687         if (!cs->item.filename || (parent && (strcmp(parent->item.filename, cs->item.filename) == 0))) {
 688                 new->item.filename = parent->item.filename;
 689         } else {
 690                 new->item.filename = talloc_strdup(new, cs->item.filename);
 691         }
 692
 693         for (ci = cs->children; ci; ci = ci->next) {
 694                 switch (ci->type) {
 695                 case CONF_ITEM_SECTION:
 696                         subcs = cf_item_to_section(ci);
 697                         subcs = cf_section_dup(new, subcs,
 698                                                cf_section_name1(subcs), cf_section_name2(subcs),
 699                                                copy_meta);
 700                         if (!subcs) {
 701                                 talloc_free(new);
 702                                 return NULL;
 703                         }
 704                         cf_section_add(new, subcs);
 705                         break;
 706
 707                 case CONF_ITEM_PAIR:
 708                         cp = cf_pair_dup(new, cf_item_to_pair(ci));
 709                         if (!cp) {
 710                                 talloc_free(new);
 711                                 return NULL;
 712                         }
 713                         cf_pair_add(new, cp);
 714                         break;
 715
 716                 case CONF_ITEM_DATA: /* Skip data */
 717                         break;
 718
 719                 case CONF_ITEM_INVALID:
 720                         rad_assert(0);
 721                 }
 722         }
 723
 724         return new;
 725 }
 726
 727 void cf_section_add(CONF_SECTION *parent, CONF_SECTION *cs)
 728 {
 729         cf_item_add(parent, &(cs->item));
 730 }
 731
 732 /** Replace pair in a given section with a new pair, of the given value.
 733  *
 734  * @param cs to replace pair in.
 735  * @param cp to replace.
 736  * @param value New value to assign to cp.
 737  * @return 0 on success, -1 on failure.
 738  */
 739 int cf_pair_replace(CONF_SECTION *cs, CONF_PAIR *cp, char const *value)
 740 {
 741         CONF_PAIR *newp;
 742         CONF_ITEM *ci, *cn, **last;
 743
 744         newp = cf_pair_alloc(cs, cp->attr, value, cp->op, cp->lhs_type, cp->rhs_type);
 745         if (!newp) return -1;
 746
 747         ci = &(cp->item);
 748         cn = &(newp->item);
 749
 750         /*
 751          *      Find the old one from the linked list, and replace it
 752          *      with the new one.
 753          */
 754         for (last = &cs->children; (*last) != NULL; last = &(*last)->next) {
 755                 if (*last == ci) {
 756                         cn->next = (*last)->next;
 757                         *last = cn;
 758                         ci->next = NULL;
 759                         break;
 760                 }
 761         }
 762
 763         rbtree_deletebydata(cs->pair_tree, ci);
 764
 765         rbtree_insert(cs->pair_tree, cn);
 766
 767         return 0;
 768 }
 769
 770
 771 /*
 772  *      Add an item to a configuration section.
 773  */
 774 void cf_item_add(CONF_SECTION *cs, CONF_ITEM *ci)
 775 {
 776 #ifndef NDEBUG
 777         CONF_ITEM *first = ci;
 778 #endif
 779
 780         rad_assert((void *)cs != (void *)ci);
 781
 782         if (!cs || !ci) return;
 783
 784         if (!cs->children) {
 785                 rad_assert(cs->tail == NULL);
 786                 cs->children = ci;
 787         } else {
 788                 rad_assert(cs->tail != NULL);
 789                 cs->tail->next = ci;
 790         }
 791
 792         /*
 793          *      Update the trees (and tail) for each item added.
 794          */
 795         for (/* nothing */; ci != NULL; ci = ci->next) {
 796                 rad_assert(ci->next != first);  /* simple cycle detection */
 797
 798                 cs->tail = ci;
 799
 800                 /*
 801                  *      For fast lookups, pairs and sections get
 802                  *      added to rbtree's.
 803                  */
 804                 switch (ci->type) {
 805                 case CONF_ITEM_PAIR:
 806                         if (!rbtree_insert(cs->pair_tree, ci)) {
 807                                 CONF_PAIR *cp = cf_item_to_pair(ci);
 808
 809                                 if (strcmp(cp->attr, "confdir") == 0) break;
 810                                 if (!cp->value) break; /* module name, "ok", etc. */
 811                         }
 812                         break;
 813
 814                 case CONF_ITEM_SECTION: {
 815                         CONF_SECTION *cs_new = cf_item_to_section(ci);
 816                         CONF_SECTION *name1_cs;
 817
 818                         if (!cs->section_tree) {
 819                                 cs->section_tree = rbtree_create(cs, section_cmp, NULL, 0);
 820                                 if (!cs->section_tree) {
 821                                         ERROR("Out of memory");
 822                                         fr_exit_now(1);
 823                                 }
 824                         }
 825
 826                         name1_cs = rbtree_finddata(cs->section_tree, cs_new);
 827                         if (!name1_cs) {
 828                                 if (!rbtree_insert(cs->section_tree, cs_new)) {
 829                                         ERROR("Failed inserting section into tree");
 830                                         fr_exit_now(1);
 831                                 }
 832                                 break;
 833                         }
 834
 835                         /*
 836                          *      We already have a section of
 837                          *      this "name1".  Add a new
 838                          *      sub-section based on name2.
 839                          */
 840                         if (!name1_cs->name2_tree) {
 841                                 name1_cs->name2_tree = rbtree_create(name1_cs, name2_cmp, NULL, 0);
 842                                 if (!name1_cs->name2_tree) {
 843                                         ERROR("Out of memory");
 844                                         fr_exit_now(1);
 845                                 }
 846                         }
 847
 848                         /*
 849                          *      We don't care if this fails.
 850                          *      If the user tries to create
 851                          *      two sections of the same
 852                          *      name1/name2, the duplicate
 853                          *      section is just silently
 854                          *      ignored.
 855                          */
 856                         rbtree_insert(name1_cs->name2_tree, cs_new);
 857                         break;
 858                 } /* was a section */
 859
 860                 case CONF_ITEM_DATA:
 861                         if (!cs->data_tree) {
 862                                 cs->data_tree = rbtree_create(cs, data_cmp, NULL, 0);
 863                         }
 864                         if (cs->data_tree) {
 865                                 rbtree_insert(cs->data_tree, ci);
 866                         }
 867                         break;
 868
 869                 default: /* FIXME: assert & error! */
 870                         break;
 871
 872                 } /* switch over conf types */
 873         } /* loop over ci */
 874 }
 875
 876
 877 CONF_ITEM *cf_reference_item(CONF_SECTION const *parentcs,
 878                              CONF_SECTION *outercs,
 879                              char const *ptr)
 880 {
 881         CONF_PAIR *cp;
 882         CONF_SECTION *next;
 883         CONF_SECTION const *cs = outercs;
 884         char name[8192];
 885         char *p;
 886
 887         if (!cs) goto no_such_item;
 888
 889         strlcpy(name, ptr, sizeof(name));
 890         p = name;
 891
 892         /*
 893          *      ".foo" means "foo from the current section"
 894          */
 895         if (*p == '.') {
 896                 p++;
 897
 898                 /*
 899                  *      Just '.' means the current section
 900                  */
 901                 if (*p == '\0') {
 902                         return cf_section_to_item(cs);
 903                 }
 904
 905                 /*
 906                  *      ..foo means "foo from the section
 907                  *      enclosing this section" (etc.)
 908                  */
 909                 while (*p == '.') {
 910                         if (cs->item.parent) {
 911                                 cs = cs->item.parent;
 912                         }
 913
 914                         /*
 915                          *      .. means the section
 916                          *      enclosing this section
 917                          */
 918                         if (!*++p) {
 919                                 return cf_section_to_item(cs);
 920                         }
 921                 }
 922
 923                 /*
 924                  *      "foo.bar.baz" means "from the root"
 925                  */
 926         } else if (strchr(p, '.') != NULL) {
 927                 if (!parentcs) goto no_such_item;
 928
 929                 cs = parentcs;
 930         }
 931
 932         while (*p) {
 933                 char *q, *r;
 934
 935                 r = strchr(p, '[');
 936                 q = strchr(p, '.');
 937                 if (!r && !q) break;
 938
 939                 if (r && q > r) q = NULL;
 940                 if (q && q < r) r = NULL;
 941
 942                 /*
 943                  *      Split off name2.
 944                  */
 945                 if (r) {
 946                         q = strchr(r + 1, ']');
 947                         if (!q) return NULL; /* parse error */
 948
 949                         /*
 950                          *      Points to foo[bar]xx: parse error,
 951                          *      it should be foo[bar] or foo[bar].baz
 952                          */
 953                         if (q[1] && q[1] != '.') goto no_such_item;
 954
 955                         *r = '\0';
 956                         *q = '\0';
 957                         next = cf_section_sub_find_name2(cs, p, r + 1);
 958                         *r = '[';
 959                         *q = ']';
 960
 961                         /*
 962                          *      Points to a named instance of a section.
 963                          */
 964                         if (!q[1]) {
 965                                 if (!next) goto no_such_item;
 966                                 return &(next->item);
 967                         }
 968
 969                         q++;    /* ensure we skip the ']' and '.' */
 970
 971                 } else {
 972                         *q = '\0';
 973                         next = cf_section_sub_find(cs, p);
 974                         *q = '.';
 975                 }
 976
 977                 if (!next) break; /* it MAY be a pair in this section! */
 978
 979                 cs = next;
 980                 p = q + 1;
 981         }
 982
 983         if (!*p) goto no_such_item;
 984
 985  retry:
 986         /*
 987          *      Find it in the current referenced
 988          *      section.
 989          */
 990         cp = cf_pair_find(cs, p);
 991         if (cp) {
 992                 cp->parsed = true;      /* conf pairs which are referenced count as parsed */
 993                 return &(cp->item);
 994         }
 995
 996         next = cf_section_sub_find(cs, p);
 997         if (next) return &(next->item);
 998
 999         /*
1000          *      "foo" is "in the current section, OR in main".
1001          */
1002         if ((p == name) && (parentcs != NULL) && (cs != parentcs)) {
1003                 cs = parentcs;
1004                 goto retry;
1005         }
1006
1007 no_such_item:
1008         return NULL;
1009 }
1010
1011
1012 CONF_SECTION *cf_top_section(CONF_SECTION *cs)
1013 {
1014         if (!cs) return NULL;
1015
1016         while (cs->item.parent != NULL) {
1017                 cs = cs->item.parent;
1018         }
1019
1020         return cs;
1021 }
1022
1023
1024 /*
1025  *      Expand the variables in an input string.
1026  */
1027 static char const *cf_expand_variables(char const *cf, int *lineno,
1028                                        CONF_SECTION *outercs,
1029                                        char *output, size_t outsize,
1030                                        char const *input, bool *soft_fail)
1031 {
1032         char *p;
1033         char const *end, *ptr;
1034         CONF_SECTION const *parentcs;
1035         char name[8192];
1036
1037         if (soft_fail) *soft_fail = false;
1038
1039         /*
1040          *      Find the master parent conf section.
1041          *      We can't use main_config.config, because we're in the
1042          *      process of re-building it, and it isn't set up yet...
1043          */
1044         parentcs = cf_top_section(outercs);
1045
1046         p = output;
1047         ptr = input;
1048         while (*ptr) {
1049                 /*
1050                  *      Ignore anything other than "${"
1051                  */
1052                 if ((*ptr == '$') && (ptr[1] == '{')) {
1053                         CONF_ITEM *ci;
1054                         CONF_PAIR *cp;
1055                         char *q;
1056
1057                         /*
1058                          *      FIXME: Add support for ${foo:-bar},
1059                          *      like in xlat.c
1060                          */
1061
1062                         /*
1063                          *      Look for trailing '}', and log a
1064                          *      warning for anything that doesn't match,
1065                          *      and exit with a fatal error.
1066                          */
1067                         end = strchr(ptr, '}');
1068                         if (end == NULL) {
1069                                 *p = '\0';
1070                                 INFO("%s[%d]: Variable expansion missing }",
1071                                        cf, *lineno);
1072                                 return NULL;
1073                         }
1074
1075                         ptr += 2;
1076
1077                         /*
1078                          *      Can't really happen because input lines are
1079                          *      capped at 8k, which is sizeof(name)
1080                          */
1081                         if ((size_t) (end - ptr) >= sizeof(name)) {
1082                                 ERROR("%s[%d]: Reference string is too large",
1083                                       cf, *lineno);
1084                                 return NULL;
1085                         }
1086
1087                         memcpy(name, ptr, end - ptr);
1088                         name[end - ptr] = '\0';
1089
1090                         q = strchr(name, ':');
1091                         if (q) {
1092                                 *(q++) = '\0';
1093                         }
1094
1095                         ci = cf_reference_item(parentcs, outercs, name);
1096                         if (!ci) {
1097                                 if (soft_fail) *soft_fail = true;
1098                                 ERROR("%s[%d]: Reference \"${%s}\" not found", cf, *lineno, name);
1099                                 return NULL;
1100                         }
1101
1102                         /*
1103                          *      The expansion doesn't refer to another item or section
1104                          *      it's the property of a section.
1105                          */
1106                         if (q) {
1107                                 CONF_SECTION *mycs = cf_item_to_section(ci);
1108
1109                                 if (ci->type != CONF_ITEM_SECTION) {
1110                                         ERROR("%s[%d]: Can only reference properties of sections", cf, *lineno);
1111                                         return NULL;
1112                                 }
1113
1114                                 switch (fr_str2int(conf_property_name, q, CONF_PROPERTY_INVALID)) {
1115                                 case CONF_PROPERTY_NAME:
1116                                         strcpy(p, mycs->name1);
1117                                         break;
1118
1119                                 case CONF_PROPERTY_INSTANCE:
1120                                         strcpy(p, mycs->name2 ? mycs->name2 : mycs->name1);
1121                                         break;
1122
1123                                 default:
1124                                         ERROR("%s[%d]: Invalid property '%s'", cf, *lineno, q);
1125                                         return NULL;
1126                                 }
1127                                 p += strlen(p);
1128                                 ptr = end + 1;
1129
1130                         } else if (ci->type == CONF_ITEM_PAIR) {
1131                                 /*
1132                                  *  Substitute the value of the variable.
1133                                  */
1134                                 cp = cf_item_to_pair(ci);
1135
1136                                 /*
1137                                  *      If the thing we reference is
1138                                  *      marked up as being expanded in
1139                                  *      pass2, don't expand it now.
1140                                  *      Let it be expanded in pass2.
1141                                  */
1142                                 if (cp->pass2) {
1143                                         if (soft_fail) *soft_fail = true;
1144
1145                                         ERROR("%s[%d]: Reference \"%s\" points to a variable which has not been expanded.",
1146                                               cf, *lineno, input);
1147                                         return NULL;
1148                                 }
1149
1150                                 if (!cp->value) {
1151                                         ERROR("%s[%d]: Reference \"%s\" has no value",
1152                                                cf, *lineno, input);
1153                                         return NULL;
1154                                 }
1155
1156                                 if (p + strlen(cp->value) >= output + outsize) {
1157                                         ERROR("%s[%d]: Reference \"%s\" is too long",
1158                                                cf, *lineno, input);
1159                                         return NULL;
1160                                 }
1161
1162                                 strcpy(p, cp->value);
1163                                 p += strlen(p);
1164                                 ptr = end + 1;
1165
1166                         } else if (ci->type == CONF_ITEM_SECTION) {
1167                                 CONF_SECTION *subcs;
1168
1169                                 /*
1170                                  *      Adding an entry again to a
1171                                  *      section is wrong.  We don't
1172                                  *      want an infinite loop.
1173                                  */
1174                                 if (ci->parent == outercs) {
1175                                         ERROR("%s[%d]: Cannot reference different item in same section", cf, *lineno);
1176                                         return NULL;
1177                                 }
1178
1179                                 /*
1180                                  *      Copy the section instead of
1181                                  *      referencing it.
1182                                  */
1183                                 subcs = cf_item_to_section(ci);
1184                                 subcs = cf_section_dup(outercs, subcs,
1185                                                        cf_section_name1(subcs), cf_section_name2(subcs),
1186                                                        false);
1187                                 if (!subcs) {
1188                                         ERROR("%s[%d]: Failed copying reference %s", cf, *lineno, name);
1189                                         return NULL;
1190                                 }
1191
1192                                 subcs->item.filename = ci->filename;
1193                                 subcs->item.lineno = ci->lineno;
1194                                 cf_item_add(outercs, &(subcs->item));
1195
1196                                 ptr = end + 1;
1197
1198                         } else {
1199                                 ERROR("%s[%d]: Reference \"%s\" type is invalid", cf, *lineno, input);
1200                                 return NULL;
1201                         }
1202                 } else if (memcmp(ptr, "$ENV{", 5) == 0) {
1203                         char *env;
1204
1205                         ptr += 5;
1206
1207                         /*
1208                          *      Look for trailing '}', and log a
1209                          *      warning for anything that doesn't match,
1210                          *      and exit with a fatal error.
1211                          */
1212                         end = strchr(ptr, '}');
1213                         if (end == NULL) {
1214                                 *p = '\0';
1215                                 INFO("%s[%d]: Environment variable expansion missing }",
1216                                        cf, *lineno);
1217                                 return NULL;
1218                         }
1219
1220                         /*
1221                          *      Can't really happen because input lines are
1222                          *      capped at 8k, which is sizeof(name)
1223                          */
1224                         if ((size_t) (end - ptr) >= sizeof(name)) {
1225                                 ERROR("%s[%d]: Environment variable name is too large",
1226                                        cf, *lineno);
1227                                 return NULL;
1228                         }
1229
1230                         memcpy(name, ptr, end - ptr);
1231                         name[end - ptr] = '\0';
1232
1233                         /*
1234                          *      Get the environment variable.
1235                          *      If none exists, then make it an empty string.
1236                          */
1237                         env = getenv(name);
1238                         if (env == NULL) {
1239                                 *name = '\0';
1240                                 env = name;
1241                         }
1242
1243                         if (p + strlen(env) >= output + outsize) {
1244                                 ERROR("%s[%d]: Reference \"%s\" is too long",
1245                                        cf, *lineno, input);
1246                                 return NULL;
1247                         }
1248
1249                         strcpy(p, env);
1250                         p += strlen(p);
1251                         ptr = end + 1;
1252
1253                 } else {
1254                         /*
1255                          *      Copy it over verbatim.
1256                          */
1257                         *(p++) = *(ptr++);
1258                 }
1259
1260
1261                 if (p >= (output + outsize)) {
1262                         ERROR("%s[%d]: Reference \"%s\" is too long",
1263                                cf, *lineno, input);
1264                         return NULL;
1265                 }
1266         } /* loop over all of the input string. */
1267
1268         *p = '\0';
1269
1270         return output;
1271 }
1272
1273 static char const parse_spaces[] = "                                                                                                                                                                                                                                                                ";
1274
1275 /** Validation function for ipaddr conffile types
1276  *
1277  */
1278 static inline int fr_item_validate_ipaddr(CONF_SECTION *cs, char const *name, PW_TYPE type, char const *value,
1279                                           fr_ipaddr_t *ipaddr)
1280 {
1281         char ipbuf[128];
1282
1283         if (strcmp(value, "*") == 0) {
1284                 cf_log_info(cs, "%.*s\t%s = *", cs->depth, parse_spaces, name);
1285         } else if (strspn(value, ".0123456789abdefABCDEF:%[]/") == strlen(value)) {
1286                 cf_log_info(cs, "%.*s\t%s = %s", cs->depth, parse_spaces, name, value);
1287         } else {
1288                 cf_log_info(cs, "%.*s\t%s = %s IPv%s address [%s]", cs->depth, parse_spaces, name, value,
1289                             (ipaddr->af == AF_INET ? "4" : " 6"), ip_ntoh(ipaddr, ipbuf, sizeof(ipbuf)));
1290         }
1291
1292         switch (type) {
1293         case PW_TYPE_IPV4_ADDR:
1294         case PW_TYPE_IPV6_ADDR:
1295         case PW_TYPE_COMBO_IP_ADDR:
1296                 switch (ipaddr->af) {
1297                 case AF_INET:
1298                 if (ipaddr->prefix != 32) {
1299                         ERROR("Invalid IPv4 mask length \"/%i\".  Only \"/32\" permitted for non-prefix types",
1300                               ipaddr->prefix);
1301
1302                         return -1;
1303                 }
1304                         break;
1305
1306                 case AF_INET6:
1307                 if (ipaddr->prefix != 128) {
1308                         ERROR("Invalid IPv6 mask length \"/%i\".  Only \"/128\" permitted for non-prefix types",
1309                               ipaddr->prefix);
1310
1311                         return -1;
1312                 }
1313                         break;
1314
1315                 default:
1316                         return -1;
1317                 }
1318         default:
1319                 return 0;
1320         }
1321 }
1322
1323 /** Parses a #CONF_PAIR into a C data type, with a default value.
1324  *
1325  * Takes fields from a #CONF_PARSER struct and uses them to parse the string value
1326  * of a #CONF_PAIR into a C data type matching the type argument.
1327  *
1328  * The format of the types are the same as #value_data_t types.
1329  *
1330  * @note The dflt value will only be used if no matching #CONF_PAIR is found. Empty strings will not
1331  *       result in the dflt value being used.
1332  *
1333  * **PW_TYPE to data type mappings**
1334  * | PW_TYPE                 | Data type          | Dynamically allocated  |
1335  * | ----------------------- | ------------------ | ---------------------- |
1336  * | PW_TYPE_TMPL            | ``vp_tmpl_t``      | Yes                    |
1337  * | PW_TYPE_BOOLEAN         | ``bool``           | No                     |
1338  * | PW_TYPE_INTEGER         | ``uint32_t``       | No                     |
1339  * | PW_TYPE_SHORT           | ``uint16_t``       | No                     |
1340  * | PW_TYPE_INTEGER64       | ``uint64_t``       | No                     |
1341  * | PW_TYPE_SIGNED          | ``int32_t``        | No                     |
1342  * | PW_TYPE_STRING          | ``char const *``   | Yes                    |
1343  * | PW_TYPE_IPV4_ADDR       | ``fr_ipaddr_t``    | No                     |
1344  * | PW_TYPE_IPV4_PREFIX     | ``fr_ipaddr_t``    | No                     |
1345  * | PW_TYPE_IPV6_ADDR       | ``fr_ipaddr_t``    | No                     |
1346  * | PW_TYPE_IPV6_PREFIX     | ``fr_ipaddr_t``    | No                     |
1347  * | PW_TYPE_COMBO_IP_ADDR   | ``fr_ipaddr_t``    | No                     |
1348  * | PW_TYPE_COMBO_IP_PREFIX | ``fr_ipaddr_t``    | No                     |
1349  * | PW_TYPE_TIMEVAL         | ``struct timeval`` | No                     |
1350  *
1351  * @param cs to search for matching #CONF_PAIR in.
1352  * @param name of #CONF_PAIR to search for.
1353  * @param type Data type to parse #CONF_PAIR value as.
1354  *      Should be one of the following ``data`` types, and one or more of the following ``flag`` types or'd together:
1355  *      - ``data`` #PW_TYPE_TMPL                - @copybrief PW_TYPE_TMPL
1356  *                                                Feeds the value into #tmpl_afrom_str. Value can be
1357  *                                                obtained when processing requests, with #tmpl_expand or #tmpl_aexpand.
1358  *      - ``data`` #PW_TYPE_BOOLEAN             - @copybrief PW_TYPE_BOOLEAN
1359  *      - ``data`` #PW_TYPE_INTEGER             - @copybrief PW_TYPE_INTEGER
1360  *      - ``data`` #PW_TYPE_SHORT               - @copybrief PW_TYPE_SHORT
1361  *      - ``data`` #PW_TYPE_INTEGER64           - @copybrief PW_TYPE_INTEGER64
1362  *      - ``data`` #PW_TYPE_SIGNED              - @copybrief PW_TYPE_SIGNED
1363  *      - ``data`` #PW_TYPE_STRING              - @copybrief PW_TYPE_STRING
1364  *      - ``data`` #PW_TYPE_IPV4_ADDR           - @copybrief PW_TYPE_IPV4_ADDR (IPv4 address with prefix 32).
1365  *      - ``data`` #PW_TYPE_IPV4_PREFIX         - @copybrief PW_TYPE_IPV4_PREFIX (IPv4 address with variable prefix).
1366  *      - ``data`` #PW_TYPE_IPV6_ADDR           - @copybrief PW_TYPE_IPV6_ADDR (IPv6 address with prefix 128).
1367  *      - ``data`` #PW_TYPE_IPV6_PREFIX         - @copybrief PW_TYPE_IPV6_PREFIX (IPv6 address with variable prefix).
1368  *      - ``data`` #PW_TYPE_COMBO_IP_ADDR       - @copybrief PW_TYPE_COMBO_IP_ADDR (IPv4/IPv6 address with
1369  *                                                prefix 32/128).
1370  *      - ``data`` #PW_TYPE_COMBO_IP_PREFIX     - @copybrief PW_TYPE_COMBO_IP_PREFIX (IPv4/IPv6 address with
1371  *                                                variable prefix).
1372  *      - ``data`` #PW_TYPE_TIMEVAL             - @copybrief PW_TYPE_TIMEVAL
1373  *      - ``flag`` #PW_TYPE_DEPRECATED          - @copybrief PW_TYPE_DEPRECATED
1374  *      - ``flag`` #PW_TYPE_REQUIRED            - @copybrief PW_TYPE_REQUIRED
1375  *      - ``flag`` #PW_TYPE_ATTRIBUTE           - @copybrief PW_TYPE_ATTRIBUTE
1376  *      - ``flag`` #PW_TYPE_SECRET              - @copybrief PW_TYPE_SECRET
1377  *      - ``flag`` #PW_TYPE_FILE_INPUT          - @copybrief PW_TYPE_FILE_INPUT
1378  *      - ``flag`` #PW_TYPE_NOT_EMPTY           - @copybrief PW_TYPE_NOT_EMPTY
1379  * @param data Pointer to a global variable, or pointer to a field in the struct being populated with values.
1380  * @param dflt value to use, if no #CONF_PAIR is found.
1381  * @return
1382  *      - 1 if default value was used.
1383  *      - 0 on success.
1384  *      - -1 on error.
1385  *      - -2 if deprecated.
1386  */
1387 int cf_item_parse(CONF_SECTION *cs, char const *name, unsigned int type, void *data, char const *dflt)
1388 {
1389         int rcode;
1390         bool deprecated, required, attribute, secret, file_input, cant_be_empty, tmpl, multi, file_exists;
1391         char **q;
1392         char const *value;
1393         CONF_PAIR *cp = NULL;
1394         fr_ipaddr_t *ipaddr;
1395         char buffer[8192];
1396         CONF_ITEM *c_item;
1397
1398         if (!cs) return -1;
1399
1400         c_item = &cs->item;
1401
1402         deprecated = (type & PW_TYPE_DEPRECATED);
1403         required = (type & PW_TYPE_REQUIRED);
1404         attribute = (type & PW_TYPE_ATTRIBUTE);
1405         secret = (type & PW_TYPE_SECRET);
1406         file_input = (type == PW_TYPE_FILE_INPUT);      /* check, not and */
1407         file_exists = (type == PW_TYPE_FILE_EXISTS);    /* check, not and */
1408         cant_be_empty = (type & PW_TYPE_NOT_EMPTY);
1409         tmpl = (type & PW_TYPE_TMPL);
1410         multi = (type & PW_TYPE_MULTI);
1411
1412         if (attribute) required = true;
1413         if (required) cant_be_empty = true;     /* May want to review this in the future... */
1414
1415         /*
1416          *      Everything except templates must have a base type.
1417          */
1418         if (!(type & 0xff) && !tmpl) {
1419                 cf_log_err(c_item, "Configuration item \"%s\" must have a data type", name);
1420                 return -1;
1421         }
1422
1423         type &= 0xff;                           /* normal types are small */
1424
1425         rcode = 0;
1426
1427         cp = cf_pair_find(cs, name);
1428
1429         /*
1430          *      No pairs match the configuration item name in the current
1431          *      section, use the default value.
1432          */
1433         if (!cp) {
1434                 if (deprecated) return 0;       /* Don't set the default value */
1435
1436                 rcode = 1;
1437                 value = dflt;
1438         /*
1439          *      Something matched, used the CONF_PAIR value.
1440          */
1441         } else {
1442                 CONF_PAIR *next = cp;
1443
1444                 value = cp->value;
1445                 cp->parsed = true;
1446                 c_item = &cp->item;
1447
1448                 if (deprecated) {
1449                         cf_log_err(c_item, "Configuration item \"%s\" is deprecated", name);
1450                         return -2;
1451                 }
1452
1453                 /*
1454                  *      A quick check to see if the next item is the same.
1455                  */
1456                 if (!multi && cp->item.next && (cp->item.next->type == CONF_ITEM_PAIR)) {
1457                         next = cf_item_to_pair(cp->item.next);
1458
1459                         if (strcmp(next->attr, name) == 0) {
1460                                 WARN("%s[%d]: Ignoring duplicate configuration item '%s'",
1461                                      next->item.filename ? next->item.filename : "unknown",
1462                                      next->item.lineno, name);
1463                         }
1464                 }
1465
1466                 if (multi) {
1467                         while ((next = cf_pair_find_next(cs, next, name)) != NULL) {
1468                                 /*
1469                                  *      @fixme We should actually validate
1470                                  *      the value of the pairs too
1471                                  */
1472                                 next->parsed = true;
1473                         };
1474                 }
1475         }
1476
1477         if (!value) {
1478                 if (required) {
1479                         cf_log_err(c_item, "Configuration item \"%s\" must have a value", name);
1480
1481                         return -1;
1482                 }
1483                 return rcode;
1484         }
1485
1486         if ((value[0] == '\0') && cant_be_empty) {
1487         cant_be_empty:
1488                 cf_log_err(c_item, "Configuration item \"%s\" must not be empty (zero length)", name);
1489                 if (!required) cf_log_err(c_item, "Comment item to silence this message");
1490
1491                 return -1;
1492         }
1493
1494
1495         /*
1496          *      Process a value as a LITERAL template.  Once all of
1497          *      the attrs and xlats are defined, the pass2 code
1498          *      converts it to the appropriate type.
1499          */
1500         if (tmpl) {
1501                 vp_tmpl_t *vpt;
1502
1503                 if (!value) {
1504                         *(vp_tmpl_t **)data = NULL;
1505                         return 0;
1506                 }
1507
1508                 rad_assert(!attribute);
1509                 vpt = tmpl_alloc(cs, TMPL_TYPE_LITERAL, value, strlen(value));
1510                 *(vp_tmpl_t **)data = vpt;
1511
1512                 return 0;
1513         }
1514
1515         switch (type) {
1516         case PW_TYPE_BOOLEAN:
1517                 /*
1518                  *      Allow yes/no, true/false, and on/off
1519                  */
1520                 if ((strcasecmp(value, "yes") == 0) ||
1521                     (strcasecmp(value, "true") == 0) ||
1522                     (strcasecmp(value, "on") == 0)) {
1523                         *(bool *)data = true;
1524                 } else if ((strcasecmp(value, "no") == 0) ||
1525                            (strcasecmp(value, "false") == 0) ||
1526                            (strcasecmp(value, "off") == 0)) {
1527                         *(bool *)data = false;
1528                 } else {
1529                         *(bool *)data = false;
1530                         cf_log_err(&(cs->item), "Invalid value \"%s\" for boolean "
1531                                "variable %s", value, name);
1532                         return -1;
1533                 }
1534                 cf_log_info(cs, "%.*s\t%s = %s",
1535                             cs->depth, parse_spaces, name, value);
1536                 break;
1537
1538         case PW_TYPE_INTEGER:
1539         {
1540                 unsigned long v = strtoul(value, 0, 0);
1541
1542                 /*
1543                  *      Restrict integer values to 0-INT32_MAX, this means
1544                  *      it will always be safe to cast them to a signed type
1545                  *      for comparisons, and imposes the same range limit as
1546                  *      before we switched to using an unsigned type to
1547                  *      represent config item integers.
1548                  */
1549                 if (v > INT32_MAX) {
1550                         cf_log_err(&(cs->item), "Invalid value \"%s\" for variable %s, must be between 0-%u", value,
1551                                    name, INT32_MAX);
1552                         return -1;
1553                 }
1554
1555                 *(uint32_t *)data = v;
1556                 cf_log_info(cs, "%.*s\t%s = %u", cs->depth, parse_spaces, name, *(uint32_t *)data);
1557         }
1558                 break;
1559
1560         case PW_TYPE_BYTE:
1561         {
1562                 unsigned long v = strtoul(value, 0, 0);
1563
1564                 if (v > UINT8_MAX) {
1565                         cf_log_err(&(cs->item), "Invalid value \"%s\" for variable %s, must be between 0-%u", value,
1566                                    name, UINT8_MAX);
1567                         return -1;
1568                 }
1569                 *(uint8_t *)data = (uint8_t) v;
1570                 cf_log_info(cs, "%.*s\t%s = %u", cs->depth, parse_spaces, name, *(uint8_t *)data);
1571         }
1572                 break;
1573
1574         case PW_TYPE_SHORT:
1575         {
1576                 unsigned long v = strtoul(value, 0, 0);
1577
1578                 if (v > UINT16_MAX) {
1579                         cf_log_err(&(cs->item), "Invalid value \"%s\" for variable %s, must be between 0-%u", value,
1580                                    name, UINT16_MAX);
1581                         return -1;
1582                 }
1583                 *(uint16_t *)data = (uint16_t) v;
1584                 cf_log_info(cs, "%.*s\t%s = %u", cs->depth, parse_spaces, name, *(uint16_t *)data);
1585         }
1586                 break;
1587
1588         case PW_TYPE_INTEGER64:
1589                 *(uint64_t *)data = strtoull(value, 0, 0);
1590                 cf_log_info(cs, "%.*s\t%s = %" PRIu64, cs->depth, parse_spaces, name, *(uint64_t *)data);
1591                 break;
1592
1593         case PW_TYPE_SIGNED:
1594                 *(int32_t *)data = strtol(value, 0, 0);
1595                 cf_log_info(cs, "%.*s\t%s = %d", cs->depth, parse_spaces, name, *(int32_t *)data);
1596                 break;
1597
1598         case PW_TYPE_STRING:
1599                 q = (char **) data;
1600                 if (*q != NULL) {
1601                         talloc_free(*q);
1602                 }
1603
1604                 /*
1605                  *      Expand variables which haven't already been
1606                  *      expanded automagically when the configuration
1607                  *      file was read.
1608                  */
1609                 if (value == dflt) {
1610                         int lineno = 0;
1611
1612                         lineno = cs->item.lineno;
1613
1614                         value = cf_expand_variables("<internal>",
1615                                                     &lineno,
1616                                                     cs, buffer, sizeof(buffer),
1617                                                     value, NULL);
1618                         if (!value) {
1619                                 cf_log_err(&(cs->item),"Failed expanding variable %s", name);
1620                                 return -1;
1621                         }
1622                 }
1623
1624                 if (cant_be_empty && (value[0] == '\0')) goto cant_be_empty;
1625
1626                 if (attribute) {
1627                         if (!dict_attrbyname(value)) {
1628                                 if (!cp) {
1629                                         cf_log_err(&(cs->item), "No such attribute '%s' for configuration '%s'",
1630                                                    value, name);
1631                                 } else {
1632                                         cf_log_err(&(cp->item), "No such attribute '%s'", value);
1633                                 }
1634                                 return -1;
1635                         }
1636                 }
1637
1638                 /*
1639                  *      Hide secrets when using "radiusd -X".
1640                  */
1641                 if (secret && (rad_debug_lvl <= 2)) {
1642                         cf_log_info(cs, "%.*s\t%s = <<< secret >>>",
1643                                     cs->depth, parse_spaces, name);
1644                 } else {
1645                         cf_log_info(cs, "%.*s\t%s = \"%s\"",
1646                                     cs->depth, parse_spaces, name, value ? value : "(null)");
1647                 }
1648                 *q = value ? talloc_typed_strdup(cs, value) : NULL;
1649
1650                 /*
1651                  *      If there's data AND it's an input file, check
1652                  *      that we can read it.  This check allows errors
1653                  *      to be caught as early as possible, during
1654                  *      server startup.
1655                  */
1656                 if (*q && file_input && !cf_file_check(cs, *q, true)) {
1657                         return -1;
1658                 }
1659
1660                 if (*q && file_exists && !cf_file_check(cs, *q, false)) {
1661                         return -1;
1662                 }
1663                 break;
1664
1665         case PW_TYPE_IPV4_ADDR:
1666         case PW_TYPE_IPV4_PREFIX:
1667                 ipaddr = data;
1668
1669                 if (fr_pton4(ipaddr, value, -1, true, false) < 0) {
1670                         ERROR("%s", fr_strerror());
1671                         return -1;
1672                 }
1673                 if (fr_item_validate_ipaddr(cs, name, type, value, ipaddr) < 0) return -1;
1674                 break;
1675
1676         case PW_TYPE_IPV6_ADDR:
1677         case PW_TYPE_IPV6_PREFIX:
1678                 ipaddr = data;
1679
1680                 if (fr_pton6(ipaddr, value, -1, true, false) < 0) {
1681                         ERROR("%s", fr_strerror());
1682                         return -1;
1683                 }
1684                 if (fr_item_validate_ipaddr(cs, name, type, value, ipaddr) < 0) return -1;
1685                 break;
1686
1687         case PW_TYPE_COMBO_IP_ADDR:
1688         case PW_TYPE_COMBO_IP_PREFIX:
1689                 ipaddr = data;
1690
1691                 if (fr_pton(ipaddr, value, -1, AF_UNSPEC, true) < 0) {
1692                         ERROR("%s", fr_strerror());
1693                         return -1;
1694                 }
1695                 if (fr_item_validate_ipaddr(cs, name, type, value, ipaddr) < 0) return -1;
1696                 break;
1697
1698         case PW_TYPE_TIMEVAL: {
1699                 int sec;
1700                 char *end;
1701                 struct timeval tv;
1702
1703                 sec = strtoul(value, &end, 10);
1704                 tv.tv_sec = sec;
1705                 tv.tv_usec = 0;
1706                 if (*end == '.') {
1707                         size_t len;
1708
1709                         len = strlen(end + 1);
1710
1711                         if (len > 6) {
1712                                 ERROR("Too much precision for timeval");
1713                                 return -1;
1714                         }
1715
1716                         /*
1717                          *      If they write "0.1", that means
1718                          *      "10000" microseconds.
1719                          */
1720                         sec = strtoul(end + 1, NULL, 10);
1721                         while (len < 6) {
1722                                 sec *= 10;
1723                                 len++;
1724                         }
1725
1726                         tv.tv_usec = sec;
1727                 }
1728                 cf_log_info(cs, "%.*s\t%s = %d.%06d",
1729                             cs->depth, parse_spaces, name, (int) tv.tv_sec, (int) tv.tv_usec);
1730                 memcpy(data, &tv, sizeof(tv));
1731                 }
1732                 break;
1733
1734         default:
1735                 /*
1736                  *      If we get here, it's a sanity check error.
1737                  *      It's not an error parsing the configuration
1738                  *      file.
1739                  */
1740                 rad_assert(type > PW_TYPE_INVALID);
1741                 rad_assert(type < PW_TYPE_MAX);
1742
1743                 ERROR("type '%s' is not supported in the configuration files",
1744                        fr_int2str(dict_attr_types, type, "?Unknown?"));
1745                 return -1;
1746         } /* switch over variable type */
1747
1748         if (!cp) {
1749                 CONF_PAIR *cpn;
1750
1751                 cpn = cf_pair_alloc(cs, name, value, T_OP_SET, T_BARE_WORD, T_BARE_WORD);
1752                 if (!cpn) return -1;
1753                 cpn->parsed = true;
1754                 cpn->item.filename = "<internal>";
1755                 cpn->item.lineno = 0;
1756                 cf_item_add(cs, &(cpn->item));
1757         }
1758
1759         return rcode;
1760 }
1761
1762
1763 /*
1764  *      A copy of cf_section_parse that initializes pointers before
1765  *      parsing them.
1766  */
1767 static void cf_section_parse_init(CONF_SECTION *cs, void *base,
1768                                   CONF_PARSER const *variables)
1769 {
1770         int i;
1771
1772         for (i = 0; variables[i].name != NULL; i++) {
1773                 if (variables[i].type == PW_TYPE_SUBSECTION) {
1774                         CONF_SECTION *subcs;
1775
1776                         if (!variables[i].dflt) continue;
1777
1778                         subcs = cf_section_sub_find(cs, variables[i].name);
1779
1780                         /*
1781                          *      If there's no subsection in the
1782                          *      config, BUT the CONF_PARSER wants one,
1783                          *      then create an empty one.  This is so
1784                          *      that we can track the strings,
1785                          *      etc. allocated in the subsection.
1786                          */
1787                         if (!subcs) {
1788                                 subcs = cf_section_alloc(cs, variables[i].name, NULL);
1789                                 if (!subcs) return;
1790
1791                                 subcs->item.filename = cs->item.filename;
1792                                 subcs->item.lineno = cs->item.lineno;
1793                                 cf_item_add(cs, &(subcs->item));
1794                         }
1795
1796                         cf_section_parse_init(subcs, (uint8_t *)base + variables[i].offset,
1797                                               (CONF_PARSER const *) variables[i].dflt);
1798                         continue;
1799                 }
1800
1801                 if ((variables[i].type != PW_TYPE_STRING) &&
1802                     (variables[i].type != PW_TYPE_FILE_INPUT) &&
1803                     (variables[i].type != PW_TYPE_FILE_OUTPUT)) {
1804                         continue;
1805                 }
1806
1807                 if (variables[i].data) {
1808                         *(char **) variables[i].data = NULL;
1809                 } else if (base) {
1810                         *(char **) (((char *)base) + variables[i].offset) = NULL;
1811                 } else {
1812                         continue;
1813                 }
1814         } /* for all variables in the configuration section */
1815 }
1816
1817
1818 static void cf_section_parse_warn(CONF_SECTION *cs)
1819 {
1820         CONF_ITEM *ci;
1821
1822         for (ci = cs->children; ci; ci = ci->next) {
1823                 /*
1824                  *      Don't recurse on sections. We can only safely
1825                  *      check conf pairs at the same level as the
1826                  *      section that was just parsed.
1827                  */
1828                 if (ci->type == CONF_ITEM_SECTION) continue;
1829                 if (ci->type == CONF_ITEM_PAIR) {
1830                         CONF_PAIR *cp;
1831
1832                         cp = cf_item_to_pair(ci);
1833                         if (cp->parsed) continue;
1834
1835                         WARN("%s[%d]: The item '%s' is defined, but is unused by the configuration",
1836                              cp->item.filename ? cp->item.filename : "unknown",
1837                              cp->item.lineno ? cp->item.lineno : 0,
1838                                 cp->attr);
1839                 }
1840
1841                 /*
1842                  *      Skip everything else.
1843                  */
1844         }
1845 }
1846
1847 /** Parse a configuration section into user-supplied variables
1848  *
1849  * @param cs to parse.
1850  * @param base pointer to a struct to fill with data.  Any buffers will also be talloced
1851  *      using this parent as a pointer.
1852  * @param variables mappings between struct fields and #CONF_ITEM s.
1853  * @return
1854  *      - 0 on success.
1855  *      - -1 on general error.
1856  *      - -2 if a deprecated #CONF_ITEM was found.
1857  */
1858 int cf_section_parse(CONF_SECTION *cs, void *base, CONF_PARSER const *variables)
1859 {
1860         int ret = 0;
1861         int i;
1862         void *data;
1863
1864         cs->variables = variables; /* this doesn't hurt anything */
1865
1866         if (!cs->name2) {
1867                 cf_log_info(cs, "%.*s%s {", cs->depth, parse_spaces, cs->name1);
1868         } else {
1869                 cf_log_info(cs, "%.*s%s %s {", cs->depth, parse_spaces, cs->name1, cs->name2);
1870         }
1871
1872         cf_section_parse_init(cs, base, variables);
1873
1874         /*
1875          *      Handle the known configuration parameters.
1876          */
1877         for (i = 0; variables[i].name != NULL; i++) {
1878                 /*
1879                  *      Handle subsections specially
1880                  */
1881                 if (variables[i].type == PW_TYPE_SUBSECTION) {
1882                         CONF_SECTION *subcs;
1883
1884                         subcs = cf_section_sub_find(cs, variables[i].name);
1885                         /*
1886                          *      Default in this case is overloaded to mean a pointer
1887                          *      to the CONF_PARSER struct for the subsection.
1888                          */
1889                         if (!variables[i].dflt || !subcs) {
1890                                 ERROR("Internal sanity check 1 failed in cf_section_parse %s", variables[i].name);
1891                                 ret = -1;
1892                                 goto finish;
1893                         }
1894
1895                         ret = cf_section_parse(subcs, (uint8_t *)base + variables[i].offset,
1896                                                (CONF_PARSER const *) variables[i].dflt);
1897                         if (ret < 0) goto finish;
1898                         continue;
1899                 } /* else it's a CONF_PAIR */
1900
1901                 if (variables[i].data) {
1902                         data = variables[i].data; /* prefer this. */
1903                 } else if (base) {
1904                         data = ((char *)base) + variables[i].offset;
1905                 } else {
1906                         ERROR("Internal sanity check 2 failed in cf_section_parse");
1907                         ret = -1;
1908                         goto finish;
1909                 }
1910
1911                 /*
1912                  *      Parse the pair we found, or a default value.
1913                  */
1914                 ret = cf_item_parse(cs, variables[i].name, variables[i].type, data, variables[i].dflt);
1915                 switch (ret) {
1916                 case 1:         /* Used default */
1917                         ret = 0;
1918                         break;
1919
1920                 case 0:         /* OK */
1921                         break;
1922
1923                 case -1:        /* Parse error */
1924                         goto finish;
1925
1926                 case -2:        /* Deprecated CONF ITEM */
1927                         if ((variables[i + 1].offset == variables[i].offset) &&
1928                             (variables[i + 1].data == variables[i].data)) {
1929                                 cf_log_err(&(cs->item), "Replace \"%s\" with \"%s\"", variables[i].name,
1930                                            variables[i + 1].name);
1931                         }
1932                         goto finish;
1933                 }
1934         } /* for all variables in the configuration section */
1935
1936         /*
1937          *      Ensure we have a proper terminator, type so we catch
1938          *      missing terminators reliably
1939          */
1940         rad_assert(variables[i].type == -1);
1941
1942         /*
1943          *      Warn about items in the configuration which weren't
1944          *      checked during parsing.
1945          */
1946         if (rad_debug_lvl >= 3) cf_section_parse_warn(cs);
1947
1948         cs->base = base;
1949
1950         cf_log_info(cs, "%.*s}", cs->depth, parse_spaces);
1951
1952 finish:
1953         return ret;
1954 }
1955
1956
1957 /*
1958  *      Check XLAT things in pass 2.  But don't cache the xlat stuff anywhere.
1959  */
1960 int cf_section_parse_pass2(CONF_SECTION *cs, void *base, CONF_PARSER const *variables)
1961 {
1962         int i;
1963         ssize_t slen;
1964         char const *error;
1965         char *value = NULL;
1966         xlat_exp_t *xlat;
1967
1968         /*
1969          *      Handle the known configuration parameters.
1970          */
1971         for (i = 0; variables[i].name != NULL; i++) {
1972                 CONF_PAIR *cp;
1973                 void *data;
1974
1975                 /*
1976                  *      Handle subsections specially
1977                  */
1978                 if (variables[i].type == PW_TYPE_SUBSECTION) {
1979                         CONF_SECTION *subcs;
1980                         subcs = cf_section_sub_find(cs, variables[i].name);
1981
1982                         if (cf_section_parse_pass2(subcs, (uint8_t *)base + variables[i].offset,
1983                                                    (CONF_PARSER const *) variables[i].dflt) < 0) {
1984                                 return -1;
1985                         }
1986                         continue;
1987                 } /* else it's a CONF_PAIR */
1988
1989                 /*
1990                  *      Figure out which data we need to fix.
1991                  */
1992                 if (variables[i].data) {
1993                         data = variables[i].data; /* prefer this. */
1994                 } else if (base) {
1995                         data = ((char *)base) + variables[i].offset;
1996                 } else {
1997                         data = NULL;
1998                 }
1999
2000                 cp = cf_pair_find(cs, variables[i].name);
2001                 xlat = NULL;
2002
2003         redo:
2004                 if (!cp || !cp->value || !data) continue;
2005
2006                 if ((cp->rhs_type != T_DOUBLE_QUOTED_STRING) &&
2007                     (cp->rhs_type != T_BARE_WORD)) continue;
2008
2009                 /*
2010                  *      Non-xlat expansions shouldn't have xlat!
2011                  */
2012                 if (((variables[i].type & PW_TYPE_XLAT) == 0) &&
2013                     ((variables[i].type & PW_TYPE_TMPL) == 0)) {
2014                         /*
2015                          *      Ignore %{... in shared secrets.
2016                          *      They're never dynamically expanded.
2017                          */
2018                         if ((variables[i].type & PW_TYPE_SECRET) != 0) continue;
2019
2020                         if (strstr(cp->value, "%{") != NULL) {
2021                                 WARN("%s[%d]: Found dynamic expansion in string which will not be dynamically expanded",
2022                                      cp->item.filename ? cp->item.filename : "unknown",
2023                                      cp->item.lineno ? cp->item.lineno : 0);
2024                         }
2025                         continue;
2026                 }
2027
2028                 /*
2029                  *      Parse (and throw away) the xlat string.
2030                  *
2031                  *      FIXME: All of these should be converted from PW_TYPE_XLAT
2032                  *      to PW_TYPE_TMPL.
2033                  */
2034                 if ((variables[i].type & PW_TYPE_XLAT) != 0) {
2035                         /*
2036                          *      xlat expansions should be parseable.
2037                          */
2038                         value = talloc_strdup(cs, cp->value); /* modified by xlat_tokenize */
2039                         xlat = NULL;
2040
2041                         slen = xlat_tokenize(cs, value, &xlat, &error);
2042                         if (slen < 0) {
2043                                 char *spaces, *text;
2044
2045                         error:
2046                                 fr_canonicalize_error(cs, &spaces, &text, slen, cp->value);
2047
2048                                 cf_log_err(&cp->item, "Failed parsing expanded string:");
2049                                 cf_log_err(&cp->item, "%s", text);
2050                                 cf_log_err(&cp->item, "%s^ %s", spaces, error);
2051
2052                                 talloc_free(spaces);
2053                                 talloc_free(text);
2054                                 talloc_free(value);
2055                                 talloc_free(xlat);
2056                                 return -1;
2057                         }
2058
2059                         talloc_free(value);
2060                         talloc_free(xlat);
2061                 }
2062
2063                 /*
2064                  *      Convert the LITERAL template to the actual
2065                  *      type.
2066                  */
2067                 if ((variables[i].type & PW_TYPE_TMPL) != 0) {
2068                         vp_tmpl_t *vpt;
2069
2070                         slen = tmpl_afrom_str(cs, &vpt, cp->value, talloc_array_length(cp->value) - 1,
2071                                               cp->rhs_type,
2072                                               REQUEST_CURRENT, PAIR_LIST_REQUEST, true);
2073                         if (slen < 0) {
2074                                 error = fr_strerror();
2075                                 goto error;
2076                         }
2077
2078                         /*
2079                          *      Sanity check
2080                          *
2081                          *      Don't add default - update with new types.
2082                          */
2083                         switch (vpt->type) {
2084                         /*
2085                          *      All attributes should have been defined by this point.
2086                          */
2087                         case TMPL_TYPE_ATTR_UNDEFINED:
2088                                 cf_log_err(&cp->item, "Unknown attribute '%s'", vpt->tmpl_unknown_name);
2089                                 return -1;
2090
2091                         case TMPL_TYPE_LITERAL:
2092                         case TMPL_TYPE_ATTR:
2093                         case TMPL_TYPE_LIST:
2094                         case TMPL_TYPE_DATA:
2095                         case TMPL_TYPE_EXEC:
2096                         case TMPL_TYPE_XLAT:
2097                         case TMPL_TYPE_XLAT_STRUCT:
2098                                 break;
2099
2100                         case TMPL_TYPE_UNKNOWN:
2101                         case TMPL_TYPE_REGEX:
2102                         case TMPL_TYPE_REGEX_STRUCT:
2103                         case TMPL_TYPE_NULL:
2104                                 rad_assert(0);
2105                         }
2106
2107                         talloc_free(*(vp_tmpl_t **)data);
2108                         *(vp_tmpl_t **)data = vpt;
2109                 }
2110
2111                 /*
2112                  *      If the "multi" flag is set, check all of them.
2113                  */
2114                 if ((variables[i].type & PW_TYPE_MULTI) != 0) {
2115                         cp = cf_pair_find_next(cs, cp, cp->attr);
2116                         goto redo;
2117                 }
2118         } /* for all variables in the configuration section */
2119
2120         return 0;
2121 }
2122
2123 /*
2124  *      Merge the template so everyting else "just works".
2125  */
2126 static bool cf_template_merge(CONF_SECTION *cs, CONF_SECTION const *template)
2127 {
2128         CONF_ITEM *ci;
2129
2130         if (!cs || !template) return true;
2131
2132         cs->template = NULL;
2133
2134         /*
2135          *      Walk over the template, adding its' entries to the
2136          *      current section.  But only if the entries don't
2137          *      already exist in the current section.
2138          */
2139         for (ci = template->children; ci; ci = ci->next) {
2140                 if (ci->type == CONF_ITEM_PAIR) {
2141                         CONF_PAIR *cp1, *cp2;
2142
2143                         /*
2144                          *      It exists, don't over-write it.
2145                          */
2146                         cp1 = cf_item_to_pair(ci);
2147                         if (cf_pair_find(cs, cp1->attr)) {
2148                                 continue;
2149                         }
2150
2151                         /*
2152                          *      Create a new pair with all of the data
2153                          *      of the old one.
2154                          */
2155                         cp2 = cf_pair_dup(cs, cp1);
2156                         if (!cp2) return false;
2157
2158                         cp2->item.filename = cp1->item.filename;
2159                         cp2->item.lineno = cp1->item.lineno;
2160
2161                         cf_item_add(cs, &(cp2->item));
2162                         continue;
2163                 }
2164
2165                 if (ci->type == CONF_ITEM_SECTION) {
2166                         CONF_SECTION *subcs1, *subcs2;
2167
2168                         subcs1 = cf_item_to_section(ci);
2169                         rad_assert(subcs1 != NULL);
2170
2171                         subcs2 = cf_section_sub_find_name2(cs, subcs1->name1, subcs1->name2);
2172                         if (subcs2) {
2173                                 /*
2174                                  *      sub-sections get merged.
2175                                  */
2176                                 if (!cf_template_merge(subcs2, subcs1)) {
2177                                         return false;
2178                                 }
2179                                 continue;
2180                         }
2181
2182                         /*
2183                          *      Our section doesn't have a matching
2184                          *      sub-section.  Copy it verbatim from
2185                          *      the template.
2186                          */
2187                         subcs2 = cf_section_dup(cs, subcs1,
2188                                                 cf_section_name1(subcs1), cf_section_name2(subcs1),
2189                                                 false);
2190                         if (!subcs2) return false;
2191
2192                         subcs2->item.filename = subcs1->item.filename;
2193                         subcs2->item.lineno = subcs1->item.lineno;
2194
2195                         cf_item_add(cs, &(subcs2->item));
2196                         continue;
2197                 }
2198
2199                 /* ignore everything else */
2200         }
2201
2202         return true;
2203 }
2204
2205 static char const *cf_local_file(char const *base, char const *filename,
2206                                  char *buffer, size_t bufsize)
2207 {
2208         size_t dirsize;
2209         char *p;
2210
2211         strlcpy(buffer, base, bufsize);
2212
2213         p = strrchr(buffer, FR_DIR_SEP);
2214         if (!p) return filename;
2215         if (p[1]) {             /* ./foo */
2216                 p[1] = '\0';
2217         }
2218
2219         dirsize = (p - buffer) + 1;
2220
2221         if ((dirsize + strlen(filename)) >= bufsize) {
2222                 return NULL;
2223         }
2224
2225         strlcpy(p + 1, filename, bufsize - dirsize);
2226
2227         return buffer;
2228 }
2229
2230
2231 /*
2232  *      Read a part of the config file.
2233  */
2234 static int cf_section_read(char const *filename, int *lineno, FILE *fp,
2235                            CONF_SECTION *current)
2236
2237 {
2238         CONF_SECTION *this, *css;
2239         CONF_PAIR *cpn;
2240         char const *ptr;
2241         char const *value;
2242         char buf[8192];
2243         char buf1[8192];
2244         char buf2[8192];
2245         char buf3[8192];
2246         char buf4[8192];
2247         FR_TOKEN t1 = T_INVALID, t2, t3;
2248         bool has_spaces = false;
2249         bool pass2;
2250         char *cbuf = buf;
2251         size_t len;
2252
2253         this = current;         /* add items here */
2254
2255         /*
2256          *      Read, checking for line continuations ('\\' at EOL)
2257          */
2258         for (;;) {
2259                 int at_eof;
2260                 css = NULL;
2261
2262                 /*
2263                  *      Get data, and remember if we are at EOF.
2264                  */
2265                 at_eof = (fgets(cbuf, sizeof(buf) - (cbuf - buf), fp) == NULL);
2266                 (*lineno)++;
2267
2268                 /*
2269                  *      We read the entire 8k worth of data: complain.
2270                  *      Note that we don't care if the last character
2271                  *      is \n: it's still forbidden.  This means that
2272                  *      the maximum allowed length of text is 8k-1, which
2273                  *      should be plenty.
2274                  */
2275                 len = strlen(cbuf);
2276                 if ((cbuf + len + 1) >= (buf + sizeof(buf))) {
2277                         ERROR("%s[%d]: Line too long",
2278                                filename, *lineno);
2279                         return -1;
2280                 }
2281
2282                 if (has_spaces) {
2283                         ptr = cbuf;
2284                         while (isspace((int) *ptr)) ptr++;
2285
2286                         if (ptr > cbuf) {
2287                                 memmove(cbuf, ptr, len - (ptr - cbuf));
2288                                 len -= (ptr - cbuf);
2289                         }
2290                 }
2291
2292                 /*
2293                  *      Not doing continuations: check for edge
2294                  *      conditions.
2295                  */
2296                 if (cbuf == buf) {
2297                         if (at_eof) break;
2298
2299                         ptr = buf;
2300                         while (*ptr && isspace((int) *ptr)) ptr++;
2301
2302                         if (!*ptr || (*ptr == '#')) continue;
2303
2304                 } else if (at_eof || (len == 0)) {
2305                         ERROR("%s[%d]: Continuation at EOF is illegal",
2306                                filename, *lineno);
2307                         return -1;
2308                 }
2309
2310                 /*
2311                  *      See if there's a continuation.
2312                  */
2313                 while ((len > 0) &&
2314                        ((cbuf[len - 1] == '\n') || (cbuf[len - 1] == '\r'))) {
2315                         len--;
2316                         cbuf[len] = '\0';
2317                 }
2318
2319                 if ((len > 0) && (cbuf[len - 1] == '\\')) {
2320                         /*
2321                          *      Check for "suppress spaces" magic.
2322                          */
2323                         if (!has_spaces && (len > 2) && (cbuf[len - 2] == '"')) {
2324                                 has_spaces = true;
2325                         }
2326
2327                         cbuf[len - 1] = '\0';
2328                         cbuf += len - 1;
2329                         continue;
2330                 }
2331
2332                 ptr = cbuf = buf;
2333                 has_spaces = false;
2334
2335         get_more:
2336                 pass2 = false;
2337
2338                 /*
2339                  *      The parser is getting to be evil.
2340                  */
2341                 while ((*ptr == ' ') || (*ptr == '\t')) ptr++;
2342
2343                 if (((ptr[0] == '%') && (ptr[1] == '{')) ||
2344                     (ptr[0] == '`')) {
2345                         int hack;
2346
2347                         if (ptr[0] == '%') {
2348                                 hack = rad_copy_variable(buf1, ptr);
2349                         } else {
2350                                 hack = rad_copy_string(buf1, ptr);
2351                         }
2352                         if (hack < 0) {
2353                                 ERROR("%s[%d]: Invalid expansion: %s",
2354                                        filename, *lineno, ptr);
2355                                 return -1;
2356                         }
2357
2358                         ptr += hack;
2359
2360                         t2 = gettoken(&ptr, buf2, sizeof(buf2), true);
2361                         switch (t2) {
2362                         case T_EOL:
2363                         case T_HASH:
2364                                 goto do_bare_word;
2365
2366                         default:
2367                                 ERROR("%s[%d]: Invalid expansion: %s",
2368                                        filename, *lineno, ptr);
2369                                 return -1;
2370                         }
2371                 } else {
2372                         t1 = gettoken(&ptr, buf1, sizeof(buf1), true);
2373                 }
2374
2375                 /*
2376                  *      The caller eats "name1 name2 {", and calls us
2377                  *      for the data inside of the section.  So if we
2378                  *      receive a closing brace, then it must mean the
2379                  *      end of the section.
2380                  */
2381                if (t1 == T_RCBRACE) {
2382                        if (this == current) {
2383                                ERROR("%s[%d]: Too many closing braces",
2384                                       filename, *lineno);
2385                                return -1;
2386                        }
2387
2388                        /*
2389                         *       Merge the template into the existing
2390                         *       section.  This uses more memory, but
2391                         *       means that templates now work with
2392                         *       sub-sections, etc.
2393                         */
2394                        if (!cf_template_merge(this, this->template)) {
2395                                return -1;
2396                        }
2397
2398                        this = this->item.parent;
2399                        goto check_for_more;
2400                }
2401
2402                if (t1 != T_BARE_WORD) goto skip_keywords;
2403
2404                 /*
2405                  *      Allow for $INCLUDE files
2406                  *
2407                  *      This *SHOULD* work for any level include.
2408                  *      I really really really hate this file.  -cparker
2409                  */
2410                if ((strcasecmp(buf1, "$INCLUDE") == 0) ||
2411                    (strcasecmp(buf1, "$-INCLUDE") == 0)) {
2412                         bool relative = true;
2413
2414                         t2 = getword(&ptr, buf2, sizeof(buf2), true);
2415                         if (t2 != T_EOL) {
2416                                ERROR("%s[%d]: Unexpected text after $INCLUDE",
2417                                      filename, *lineno);
2418                                return -1;
2419                         }
2420
2421                         if (buf2[0] == '$') relative = false;
2422
2423                         value = cf_expand_variables(filename, lineno, this, buf4, sizeof(buf4), buf2, NULL);
2424                         if (!value) return -1;
2425
2426                         if (!FR_DIR_IS_RELATIVE(value)) relative = false;
2427
2428                         if (relative) {
2429                                 value = cf_local_file(filename, value, buf3,
2430                                                       sizeof(buf3));
2431                                 if (!value) {
2432                                         ERROR("%s[%d]: Directories too deep.",
2433                                                filename, *lineno);
2434                                         return -1;
2435                                 }
2436                         }
2437
2438
2439 #ifdef HAVE_DIRENT_H
2440                         /*
2441                          *      $INCLUDE foo/
2442                          *
2443                          *      Include ALL non-"dot" files in the directory.
2444                          *      careful!
2445                          */
2446                         if (value[strlen(value) - 1] == '/') {
2447                                 DIR             *dir;
2448                                 struct dirent   *dp;
2449                                 struct stat stat_buf;
2450
2451                                 DEBUG2("including files in directory %s", value );
2452 #ifdef S_IWOTH
2453                                 /*
2454                                  *      Security checks.
2455                                  */
2456                                 if (stat(value, &stat_buf) < 0) {
2457                                         ERROR("%s[%d]: Failed reading directory %s: %s",
2458                                                filename, *lineno,
2459                                                value, fr_syserror(errno));
2460                                         return -1;
2461                                 }
2462
2463                                 if ((stat_buf.st_mode & S_IWOTH) != 0) {
2464                                         ERROR("%s[%d]: Directory %s is globally writable.  Refusing to start due to "
2465                                               "insecure configuration", filename, *lineno, value);
2466                                         return -1;
2467                                 }
2468 #endif
2469                                 dir = opendir(value);
2470                                 if (!dir) {
2471                                         ERROR("%s[%d]: Error reading directory %s: %s",
2472                                                filename, *lineno, value,
2473                                                fr_syserror(errno));
2474                                         return -1;
2475                                 }
2476
2477                                 /*
2478                                  *      Read the directory, ignoring "." files.
2479                                  */
2480                                 while ((dp = readdir(dir)) != NULL) {
2481                                         char const *p;
2482
2483                                         if (dp->d_name[0] == '.') continue;
2484
2485                                         /*
2486                                          *      Check for valid characters
2487                                          */
2488                                         for (p = dp->d_name; *p != '\0'; p++) {
2489                                                 if (isalpha((int)*p) ||
2490                                                     isdigit((int)*p) ||
2491                                                     (*p == '-') ||
2492                                                     (*p == '_') ||
2493                                                     (*p == '.')) continue;
2494                                                 break;
2495                                         }
2496                                         if (*p != '\0') continue;
2497
2498                                         snprintf(buf2, sizeof(buf2), "%s%s",
2499                                                  value, dp->d_name);
2500                                         if ((stat(buf2, &stat_buf) != 0) ||
2501                                             S_ISDIR(stat_buf.st_mode)) continue;
2502                                         /*
2503                                          *      Read the file into the current
2504                                          *      configuration section.
2505                                          */
2506                                         if (cf_file_include(this, buf2) < 0) {
2507                                                 closedir(dir);
2508                                                 return -1;
2509                                         }
2510                                 }
2511                                 closedir(dir);
2512                         }  else
2513 #endif
2514                         { /* it was a normal file */
2515                                 if (buf1[1] == '-') {
2516                                         struct stat statbuf;
2517
2518                                         if (stat(value, &statbuf) < 0) {
2519                                                 WARN("Not including file %s: %s", value, fr_syserror(errno));
2520                                                 continue;
2521                                         }
2522                                 }
2523
2524                                 if (cf_file_include(this, value) < 0) {
2525                                         return -1;
2526                                 }
2527                         }
2528                         continue;
2529                 } /* we were in an include */
2530
2531                if (strcasecmp(buf1, "$template") == 0) {
2532                        CONF_ITEM *ci;
2533                        CONF_SECTION *parentcs, *templatecs;
2534                        t2 = getword(&ptr, buf2, sizeof(buf2), true);
2535
2536                        if (t2 != T_EOL) {
2537                                ERROR("%s[%d]: Unexpected text after $TEMPLATE", filename, *lineno);
2538                                return -1;
2539                        }
2540
2541                        parentcs = cf_top_section(current);
2542
2543                        templatecs = cf_section_sub_find(parentcs, "templates");
2544                        if (!templatecs) {
2545                                 ERROR("%s[%d]: No \"templates\" section for reference \"%s\"", filename, *lineno, buf2);
2546                                 return -1;
2547                        }
2548
2549                        ci = cf_reference_item(parentcs, templatecs, buf2);
2550                        if (!ci || (ci->type != CONF_ITEM_SECTION)) {
2551                                 ERROR("%s[%d]: Reference \"%s\" not found", filename, *lineno, buf2);
2552                                 return -1;
2553                        }
2554
2555                        if (!this) {
2556                                 ERROR("%s[%d]: Internal sanity check error in template reference", filename, *lineno);
2557                                 return -1;
2558                        }
2559
2560                        if (this->template) {
2561                                 ERROR("%s[%d]: Section already has a template", filename, *lineno);
2562                                 return -1;
2563                        }
2564
2565                        this->template = cf_item_to_section(ci);
2566                        continue;
2567                }
2568
2569                 /*
2570                  *      Ensure that the user can't add CONF_PAIRs
2571                  *      with 'internal' names;
2572                  */
2573                 if (buf1[0] == '_') {
2574                         ERROR("%s[%d]: Illegal configuration pair name \"%s\"", filename, *lineno, buf1);
2575                         return -1;
2576                 }
2577
2578                 /*
2579                  *      Handle if/elsif specially.
2580                  */
2581                 if ((strcmp(buf1, "if") == 0) || (strcmp(buf1, "elsif") == 0)) {
2582                         ssize_t slen;
2583                         char const *error = NULL;
2584                         char *p;
2585                         CONF_SECTION *server;
2586                         fr_cond_t *cond = NULL;
2587
2588                         /*
2589                          *      if / elsif MUST be inside of a
2590                          *      processing section, which MUST in turn
2591                          *      be inside of a "server" directive.
2592                          */
2593                         if (!this->item.parent) {
2594                         invalid_location:
2595                                 ERROR("%s[%d]: Invalid location for '%s'",
2596                                        filename, *lineno, buf1);
2597                                 return -1;
2598                         }
2599
2600                         /*
2601                          *      Can only have "if" in 3 named sections.
2602                          */
2603                         server = this->item.parent;
2604                         while (server &&
2605                                (strcmp(server->name1, "server") != 0) &&
2606                                (strcmp(server->name1, "policy") != 0) &&
2607                                (strcmp(server->name1, "instantiate") != 0)) {
2608                                 server = server->item.parent;
2609                                 if (!server) goto invalid_location;
2610                         }
2611
2612                         /*
2613                          *      Skip (...) to find the {
2614                          */
2615                         slen = fr_condition_tokenize(this, cf_section_to_item(this), ptr, &cond,
2616                                                      &error, FR_COND_TWO_PASS);
2617                         memcpy(&p, &ptr, sizeof(p));
2618
2619                         if (slen < 0) {
2620                                 if (p[-slen] != '{') goto cond_error;
2621                                 slen = -slen;
2622                         }
2623                         TALLOC_FREE(cond);
2624
2625                         /*
2626                          *      This hack is so that the NEXT stage
2627                          *      doesn't go "too far" in expanding the
2628                          *      variable.  We can parse the conditions
2629                          *      without expanding the ${...} stuff.
2630                          *      BUT we don't want to expand all of the
2631                          *      stuff AFTER the condition.  So we do
2632                          *      two passes.
2633                          *
2634                          *      The first pass is to discover the end
2635                          *      of the condition.  We then expand THAT
2636                          *      string, and do a second pass parsing
2637                          *      the expanded condition.
2638                          */
2639                         p += slen;
2640                         *p = '\0';
2641
2642                         /*
2643                          *      If there's a ${...}.  If so, expand it.
2644                          */
2645                         if (strchr(ptr, '$') != NULL) {
2646                                 ptr = cf_expand_variables(filename, lineno,
2647                                                           this,
2648                                                           buf3, sizeof(buf3),
2649                                                           ptr, NULL);
2650                                 if (!ptr) {
2651                                         ERROR("%s[%d]: Parse error expanding ${...} in condition",
2652                                               filename, *lineno);
2653                                         return -1;
2654                                 }
2655                         } /* else leave it alone */
2656
2657                         css = cf_section_alloc(this, buf1, ptr);
2658                         if (!css) {
2659                                 ERROR("%s[%d]: Failed allocating memory for section",
2660                                       filename, *lineno);
2661                                 return -1;
2662                         }
2663                         css->item.filename = filename;
2664                         css->item.lineno = *lineno;
2665
2666                         slen = fr_condition_tokenize(css, cf_section_to_item(css), ptr, &cond,
2667                                                      &error, FR_COND_TWO_PASS);
2668                         *p = '{'; /* put it back */
2669
2670                 cond_error:
2671                         if (slen < 0) {
2672                                 char *spaces, *text;
2673
2674                                 fr_canonicalize_error(this, &spaces, &text, slen, ptr);
2675
2676                                 ERROR("%s[%d]: Parse error in condition",
2677                                       filename, *lineno);
2678                                 ERROR("%s[%d]: %s", filename, *lineno, text);
2679                                 ERROR("%s[%d]: %s^ %s", filename, *lineno, spaces, error);
2680
2681                                 talloc_free(spaces);
2682                                 talloc_free(text);
2683                                 talloc_free(css);
2684                                 return -1;
2685                         }
2686
2687                         if ((size_t) slen >= (sizeof(buf2) - 1)) {
2688                                 talloc_free(css);
2689                                 ERROR("%s[%d]: Condition is too large after \"%s\"",
2690                                        filename, *lineno, buf1);
2691                                 return -1;
2692                         }
2693
2694                         /*
2695                          *      Copy the expanded and parsed condition
2696                          *      into buf2.  Then, parse the text after
2697                          *      the condition, which now MUST be a '{.
2698                          *
2699                          *      If it wasn't '{' it would have been
2700                          *      caught in the first pass of
2701                          *      conditional parsing, above.
2702                          */
2703                         memcpy(buf2, ptr, slen);
2704                         buf2[slen] = '\0';
2705                         ptr = p;
2706
2707                         if ((t3 = gettoken(&ptr, buf3, sizeof(buf3), true)) != T_LCBRACE) {
2708                                 talloc_free(css);
2709                                 ERROR("%s[%d]: Expected '{' %d",
2710                                       filename, *lineno, t3);
2711                                 return -1;
2712                         }
2713
2714                         /*
2715                          *      Swap the condition with trailing stuff for
2716                          *      the final condition.
2717                          */
2718                         memcpy(&p, &css->name2, sizeof(css->name2));
2719                         talloc_free(p);
2720                         css->name2 = talloc_typed_strdup(css, buf2);
2721
2722                         cf_item_add(this, &(css->item));
2723                         cf_data_add_internal(css, "if", cond, NULL, false);
2724
2725                         /*
2726                          *      The current section is now the child section.
2727                          */
2728                         this = css;
2729                         css = NULL;
2730                         goto check_for_more;
2731                 }
2732
2733         skip_keywords:
2734                 /*
2735                  *      Grab the next token.
2736                  */
2737                 t2 = gettoken(&ptr, buf2, sizeof(buf2), !cf_new_escape);
2738                 switch (t2) {
2739                 case T_EOL:
2740                 case T_HASH:
2741                 case T_COMMA:
2742                 do_bare_word:
2743                         t3 = t2;
2744                         t2 = T_OP_EQ;
2745                         value = NULL;
2746                         goto do_set;
2747
2748                 case T_OP_INCRM:
2749                 case T_OP_ADD:
2750                 case T_OP_CMP_EQ:
2751                 case T_OP_SUB:
2752                 case T_OP_LE:
2753                 case T_OP_GE:
2754                 case T_OP_CMP_FALSE:
2755                         if (!this || (strcmp(this->name1, "update") != 0)) {
2756                                 ERROR("%s[%d]: Invalid operator in assignment",
2757                                        filename, *lineno);
2758                                 return -1;
2759                         }
2760                         /* FALL-THROUGH */
2761
2762                 case T_OP_EQ:
2763                 case T_OP_SET:
2764                         while (isspace((int) *ptr)) ptr++;
2765
2766                         /*
2767                          *      New parser: non-quoted strings are
2768                          *      bare words, and we parse everything
2769                          *      until the next newline, or the next
2770                          *      comma.  If they have { or } in a bare
2771                          *      word, well... too bad.
2772                          */
2773                         if (cf_new_escape && (*ptr != '"') && (*ptr != '\'')
2774                             && (*ptr != '`') && (*ptr != '/')) {
2775                                 const char *q = ptr;
2776
2777                                 t3 = T_BARE_WORD;
2778                                 while (*q && (*q >= ' ') && (*q != ',') &&
2779                                        !isspace(*q)) q++;
2780
2781                                 if ((size_t) (q - ptr) >= sizeof(buf3)) {
2782                                         ERROR("%s[%d]: Parse error: value too long",
2783                                               filename, *lineno);
2784                                         return -1;
2785                                 }
2786
2787                                 memcpy(buf3, ptr, (q - ptr));
2788                                 buf3[q - ptr] = '\0';
2789                                 ptr = q;
2790
2791                         } else {
2792                                 t3 = getstring(&ptr, buf3, sizeof(buf3), !cf_new_escape);
2793                         }
2794
2795                         if (t3 == T_INVALID) {
2796                                 ERROR("%s[%d]: Parse error: %s",
2797                                        filename, *lineno,
2798                                        fr_strerror());
2799                                 return -1;
2800                         }
2801
2802                         /*
2803                          *      Allow "foo" by itself, or "foo = bar"
2804                          */
2805                         switch (t3) {
2806                                 bool soft_fail;
2807
2808                         case T_BARE_WORD:
2809                         case T_DOUBLE_QUOTED_STRING:
2810                         case T_BACK_QUOTED_STRING:
2811                                 value = cf_expand_variables(filename, lineno, this, buf4, sizeof(buf4), buf3, &soft_fail);
2812                                 if (!value) {
2813                                         if (!soft_fail) return -1;
2814
2815                                         /*
2816                                          *      References an item which doesn't exist,
2817                                          *      or which is already marked up as being
2818                                          *      expanded in pass2.  Wait for pass2 to
2819                                          *      do the expansions.
2820                                          */
2821                                         pass2 = true;
2822                                         value = buf3;
2823                                 }
2824                                 break;
2825
2826                         case T_EOL:
2827                         case T_HASH:
2828                                 value = NULL;
2829                                 break;
2830
2831                         default:
2832                                 value = buf3;
2833                                 break;
2834                         }
2835
2836                         /*
2837                          *      Add this CONF_PAIR to our CONF_SECTION
2838                          */
2839                 do_set:
2840                         cpn = cf_pair_alloc(this, buf1, value, t2, t1, t3);
2841                         if (!cpn) return -1;
2842                         cpn->item.filename = filename;
2843                         cpn->item.lineno = *lineno;
2844                         cpn->pass2 = pass2;
2845                         cf_item_add(this, &(cpn->item));
2846
2847                         /*
2848                          *      Hacks for escaping
2849                          */
2850                         if (!cf_new_escape && !this->item.parent && value &&
2851                             (strcmp(buf1, "correct_escapes") == 0) &&
2852                             ((strcmp(value, "true") == 0) ||
2853                              (strcmp(value, "yes") == 0) ||
2854                              (strcmp(value, "1") == 0))) {
2855                                 cf_new_escape = true;
2856                         }
2857
2858                         /*
2859                          *      Require a comma, unless there's a comment.
2860                          */
2861                         while (isspace(*ptr)) ptr++;
2862
2863                         if (*ptr == ',') {
2864                                 ptr++;
2865                                 break;
2866                         }
2867
2868                         /*
2869                          *      module # stuff!
2870                          *      foo = bar # other stuff
2871                          */
2872                         if ((t3 == T_HASH) || (t3 == T_COMMA) || (t3 == T_EOL) || (*ptr == '#')) continue;
2873
2874                         if (!*ptr || (*ptr == '}')) break;
2875
2876                         ERROR("%s[%d]: Syntax error: Expected comma after '%s': %s",
2877                               filename, *lineno, value, ptr);
2878                         return -1;
2879
2880                         /*
2881                          *      No '=', must be a section or sub-section.
2882                          */
2883                 case T_BARE_WORD:
2884                 case T_DOUBLE_QUOTED_STRING:
2885                 case T_SINGLE_QUOTED_STRING:
2886                         t3 = gettoken(&ptr, buf3, sizeof(buf3), true);
2887                         if (t3 != T_LCBRACE) {
2888                                 ERROR("%s[%d]: Expecting section start brace '{' after \"%s %s\"",
2889                                        filename, *lineno, buf1, buf2);
2890                                 return -1;
2891                         }
2892                         /* FALL-THROUGH */
2893
2894                 case T_LCBRACE:
2895                         css = cf_section_alloc(this, buf1,
2896                                                t2 == T_LCBRACE ? NULL : buf2);
2897                         if (!css) {
2898                                 ERROR("%s[%d]: Failed allocating memory for section",
2899                                       filename, *lineno);
2900                                 return -1;
2901                         }
2902
2903                         css->item.filename = filename;
2904                         css->item.lineno = *lineno;
2905                         cf_item_add(this, &(css->item));
2906
2907                         /*
2908                          *      There may not be a name2
2909                          */
2910                         css->name2_type = (t2 == T_LCBRACE) ? T_INVALID : t2;
2911
2912                         /*
2913                          *      The current section is now the child section.
2914                          */
2915                         this = css;
2916                         break;
2917
2918                 case T_INVALID:
2919                         ERROR("%s[%d]: Syntax error in '%s': %s", filename, *lineno, ptr, fr_strerror());
2920
2921                         return -1;
2922
2923                 default:
2924                         ERROR("%s[%d]: Parse error after \"%s\": unexpected token \"%s\"",
2925                               filename, *lineno, buf1, fr_int2str(fr_tokens, t2, "<INVALID>"));
2926
2927                         return -1;
2928                 }
2929
2930         check_for_more:
2931                 /*
2932                  *      Done parsing one thing.  Skip to EOL if possible.
2933                  */
2934                 while (isspace(*ptr)) ptr++;
2935
2936                 if (*ptr == '#') continue;
2937
2938                 if (*ptr) {
2939                         goto get_more;
2940                 }
2941
2942         }
2943
2944         /*
2945          *      See if EOF was unexpected ..
2946          */
2947         if (feof(fp) && (this != current)) {
2948                 ERROR("%s[%d]: EOF reached without closing brace for section %s starting at line %d",
2949                       filename, *lineno, cf_section_name1(this), cf_section_lineno(this));
2950                 return -1;
2951         }
2952
2953         return 0;
2954 }
2955
2956 /*
2957  *      Include one config file in another.
2958  */
2959 static int cf_file_include(CONF_SECTION *cs, char const *filename_in)
2960 {
2961         FILE            *fp;
2962         int             lineno = 0;
2963         char const      *filename;
2964
2965         /*
2966          *      So we only need to do this once.
2967          */
2968         filename = talloc_strdup(cs, filename_in);
2969
2970         DEBUG2("including configuration file %s", filename);
2971
2972         fp = cf_file_open(cs, filename);
2973         if (!fp) return -1;
2974
2975         if (!cs->item.filename) cs->item.filename = filename;
2976
2977         /*
2978          *      Read the section.  It's OK to have EOF without a
2979          *      matching close brace.
2980          */
2981         if (cf_section_read(filename, &lineno, fp, cs) < 0) {
2982                 fclose(fp);
2983                 return -1;
2984         }
2985
2986         fclose(fp);
2987         return 0;
2988 }
2989
2990
2991 /*
2992  *      Do variable expansion in pass2.
2993  *
2994  *      This is a breadth-first expansion.  "deep
2995  */
2996 static int cf_section_pass2(CONF_SECTION *cs)
2997 {
2998         CONF_ITEM *ci;
2999
3000         for (ci = cs->children; ci; ci = ci->next) {
3001                 char const *value;
3002                 CONF_PAIR *cp;
3003                 char buffer[8192];
3004
3005                 if (ci->type != CONF_ITEM_PAIR) continue;
3006
3007                 cp = cf_item_to_pair(ci);
3008                 if (!cp->value || !cp->pass2) continue;
3009
3010                 rad_assert((cp->rhs_type == T_BARE_WORD) ||
3011                            (cp->rhs_type == T_DOUBLE_QUOTED_STRING) ||
3012                            (cp->rhs_type == T_BACK_QUOTED_STRING));
3013
3014                 value = cf_expand_variables(ci->filename, &ci->lineno, cs, buffer, sizeof(buffer), cp->value, NULL);
3015                 if (!value) return -1;
3016
3017                 rad_const_free(cp->value);
3018                 cp->value = talloc_typed_strdup(cp, value);
3019         }
3020
3021         for (ci = cs->children; ci; ci = ci->next) {
3022                 if (ci->type != CONF_ITEM_SECTION) continue;
3023
3024                 if (cf_section_pass2(cf_item_to_section(ci)) < 0) return -1;
3025         }
3026
3027         return 0;
3028 }
3029
3030
3031 /*
3032  *      Bootstrap a config file.
3033  */
3034 int cf_file_read(CONF_SECTION *cs, char const *filename)
3035 {
3036         char *p;
3037         CONF_PAIR *cp;
3038         rbtree_t *tree;
3039
3040         cp = cf_pair_alloc(cs, "confdir", filename, T_OP_SET, T_BARE_WORD, T_SINGLE_QUOTED_STRING);
3041         if (!cp) return -1;
3042
3043         p = strrchr(cp->value, FR_DIR_SEP);
3044         if (p) *p = '\0';
3045
3046         cp->item.filename = "<internal>";
3047         cp->item.lineno = -1;
3048         cf_item_add(cs, &(cp->item));
3049
3050         tree = rbtree_create(cs, filename_cmp, NULL, 0);
3051         if (!tree) return -1;
3052
3053         cf_data_add_internal(cs, "filename", tree, NULL, 0);
3054
3055         if (cf_file_include(cs, filename) < 0) return -1;
3056
3057         /*
3058          *      Now that we've read the file, go back through it and
3059          *      expand the variables.
3060          */
3061         if (cf_section_pass2(cs) < 0) return -1;
3062
3063         return 0;
3064 }
3065
3066
3067 void cf_file_free(CONF_SECTION *cs)
3068 {
3069         talloc_free(cs);
3070 }
3071
3072
3073 /*
3074  * Return a CONF_PAIR within a CONF_SECTION.
3075  */
3076 CONF_PAIR *cf_pair_find(CONF_SECTION const *cs, char const *name)
3077 {
3078         CONF_PAIR *cp, mycp;
3079
3080         if (!cs || !name) return NULL;
3081
3082         mycp.attr = name;
3083         cp = rbtree_finddata(cs->pair_tree, &mycp);
3084         if (cp) return cp;
3085
3086         if (!cs->template) return NULL;
3087
3088         return rbtree_finddata(cs->template->pair_tree, &mycp);
3089 }
3090
3091 /*
3092  * Return the attr of a CONF_PAIR
3093  */
3094
3095 char const *cf_pair_attr(CONF_PAIR const *pair)
3096 {
3097         return (pair ? pair->attr : NULL);
3098 }
3099
3100 /*
3101  * Return the value of a CONF_PAIR
3102  */
3103
3104 char const *cf_pair_value(CONF_PAIR const *pair)
3105 {
3106         return (pair ? pair->value : NULL);
3107 }
3108
3109 FR_TOKEN cf_pair_operator(CONF_PAIR const *pair)
3110 {
3111         return (pair ? pair->op : T_INVALID);
3112 }
3113
3114 /** Return the value (lhs) type
3115  *
3116  * @param pair to extract value type from.
3117  * @return one of T_BARE_WORD, T_SINGLE_QUOTED_STRING, T_BACK_QUOTED_STRING
3118  *      T_DOUBLE_QUOTED_STRING or T_INVALID if the pair is NULL.
3119  */
3120 FR_TOKEN cf_pair_attr_type(CONF_PAIR const *pair)
3121 {
3122         return (pair ? pair->lhs_type : T_INVALID);
3123 }
3124
3125 /** Return the value (rhs) type
3126  *
3127  * @param pair to extract value type from.
3128  * @return one of T_BARE_WORD, T_SINGLE_QUOTED_STRING, T_BACK_QUOTED_STRING
3129  *      T_DOUBLE_QUOTED_STRING or T_INVALID if the pair is NULL.
3130  */
3131 FR_TOKEN cf_pair_value_type(CONF_PAIR const *pair)
3132 {
3133         return (pair ? pair->rhs_type : T_INVALID);
3134 }
3135
3136 /*
3137  * Turn a CONF_PAIR into a VALUE_PAIR
3138  * For now, ignore the "value_type" field...
3139  */
3140 VALUE_PAIR *cf_pairtovp(CONF_PAIR *pair)
3141 {
3142         if (!pair) {
3143                 fr_strerror_printf("Internal error");
3144                 return NULL;
3145         }
3146
3147         if (!pair->value) {
3148                 fr_strerror_printf("No value given for attribute %s", pair->attr);
3149                 return NULL;
3150         }
3151
3152         /*
3153          *      false comparisons never match.  BUT if it's a "string"
3154          *      or `string`, then remember to expand it later.
3155          */
3156         if ((pair->op != T_OP_CMP_FALSE) &&
3157             ((pair->rhs_type == T_DOUBLE_QUOTED_STRING) ||
3158              (pair->rhs_type == T_BACK_QUOTED_STRING))) {
3159                 VALUE_PAIR *vp;
3160
3161                 vp = fr_pair_make(pair, NULL, pair->attr, NULL, pair->op);
3162                 if (!vp) {
3163                         return NULL;
3164                 }
3165
3166                 if (fr_pair_mark_xlat(vp, pair->value) < 0) {
3167                         talloc_free(vp);
3168
3169                         return NULL;
3170                 }
3171
3172                 return vp;
3173         }
3174
3175         return fr_pair_make(pair, NULL, pair->attr, pair->value, pair->op);
3176 }
3177
3178 /*
3179  * Return the first label of a CONF_SECTION
3180  */
3181
3182 char const *cf_section_name1(CONF_SECTION const *cs)
3183 {
3184         return (cs ? cs->name1 : NULL);
3185 }
3186
3187 /*
3188  * Return the second label of a CONF_SECTION
3189  */
3190
3191 char const *cf_section_name2(CONF_SECTION const *cs)
3192 {
3193         return (cs ? cs->name2 : NULL);
3194 }
3195
3196 /** Return name2 if set, else name1
3197  *
3198  */
3199 char const *cf_section_name(CONF_SECTION const *cs)
3200 {
3201         char const *name;
3202
3203         name = cf_section_name2(cs);
3204         if (name) return name;
3205
3206         return cf_section_name1(cs);
3207 }
3208
3209 /*
3210  * Find a value in a CONF_SECTION
3211  */
3212 char const *cf_section_value_find(CONF_SECTION const *cs, char const *attr)
3213 {
3214         CONF_PAIR       *cp;
3215
3216         cp = cf_pair_find(cs, attr);
3217
3218         return (cp ? cp->value : NULL);
3219 }
3220
3221
3222 CONF_SECTION *cf_section_find_name2(CONF_SECTION const *cs,
3223                                     char const *name1, char const *name2)
3224 {
3225         char const      *their2;
3226         CONF_ITEM const *ci;
3227
3228         if (!cs || !name1) return NULL;
3229
3230         for (ci = &(cs->item); ci; ci = ci->next) {
3231                 if (ci->type != CONF_ITEM_SECTION)
3232                         continue;
3233
3234                 if (strcmp(cf_item_to_section(ci)->name1, name1) != 0) {
3235                         continue;
3236                 }
3237
3238                 their2 = cf_item_to_section(ci)->name2;
3239
3240                 if ((!name2 && !their2) ||
3241                     (name2 && their2 && (strcmp(name2, their2) == 0))) {
3242                         return cf_item_to_section(ci);
3243                 }
3244         }
3245
3246         return NULL;
3247 }
3248
3249 /** Find a pair with a name matching attr, after specified pair.
3250  *
3251  * @param cs to search in.
3252  * @param pair to search from (may be NULL).
3253  * @param attr to find (may be NULL in which case any attribute matches).
3254  * @return the next matching CONF_PAIR or NULL if none matched.
3255  */
3256 CONF_PAIR *cf_pair_find_next(CONF_SECTION const *cs,
3257                              CONF_PAIR const *pair, char const *attr)
3258 {
3259         CONF_ITEM       *ci;
3260
3261         if (!cs) return NULL;
3262
3263         /*
3264          *      If pair is NULL and we're trying to find a specific
3265          *      attribute this must be a first time run.
3266          *
3267          *      Find the pair with correct name.
3268          */
3269         if (!pair && attr) return cf_pair_find(cs, attr);
3270
3271         /*
3272          *      Start searching from the next child, or from the head
3273          *      of the list of children (if no pair was provided).
3274          */
3275         for (ci = pair ? pair->item.next : cs->children;
3276              ci;
3277              ci = ci->next) {
3278                 if (ci->type != CONF_ITEM_PAIR) continue;
3279
3280                 if (!attr || strcmp(cf_item_to_pair(ci)->attr, attr) == 0) break;
3281         }
3282
3283         return cf_item_to_pair(ci);
3284 }
3285
3286 /*
3287  * Find a CONF_SECTION, or return the root if name is NULL
3288  */
3289
3290 CONF_SECTION *cf_section_find(char const *name)
3291 {
3292         if (name)
3293                 return cf_section_sub_find(root_config, name);
3294         else
3295                 return root_config;
3296 }
3297
3298 /** Find a sub-section in a section
3299  *
3300  *      This finds ANY section having the same first name.
3301  *      The second name is ignored.
3302  */
3303 CONF_SECTION *cf_section_sub_find(CONF_SECTION const *cs, char const *name)
3304 {
3305         CONF_SECTION mycs;
3306
3307         if (!cs || !name) return NULL;  /* can't find an un-named section */
3308
3309         /*
3310          *      No sub-sections have been defined, so none exist.
3311          */
3312         if (!cs->section_tree) return NULL;
3313
3314         mycs.name1 = name;
3315         mycs.name2 = NULL;
3316         return rbtree_finddata(cs->section_tree, &mycs);
3317 }
3318
3319
3320 /** Find a CONF_SECTION with both names.
3321  *
3322  */
3323 CONF_SECTION *cf_section_sub_find_name2(CONF_SECTION const *cs,
3324                                         char const *name1, char const *name2)
3325 {
3326         CONF_ITEM    *ci;
3327
3328         if (!cs) cs = root_config;
3329         if (!cs) return NULL;
3330
3331         if (name1) {
3332                 CONF_SECTION mycs, *master_cs;
3333
3334                 if (!cs->section_tree) return NULL;
3335
3336                 mycs.name1 = name1;
3337                 mycs.name2 = name2;
3338
3339                 master_cs = rbtree_finddata(cs->section_tree, &mycs);
3340                 if (!master_cs) return NULL;
3341
3342                 /*
3343                  *      Look it up in the name2 tree.  If it's there,
3344                  *      return it.
3345                  */
3346                 if (master_cs->name2_tree) {
3347                         CONF_SECTION *subcs;
3348
3349                         subcs = rbtree_finddata(master_cs->name2_tree, &mycs);
3350                         if (subcs) return subcs;
3351                 }
3352
3353                 /*
3354                  *      We don't insert ourselves into the name2 tree.
3355                  *      So if there's nothing in the name2 tree, maybe
3356                  *      *we* are the answer.
3357                  */
3358                 if (!master_cs->name2 && name2) return NULL;
3359                 if (master_cs->name2 && !name2) return NULL;
3360                 if (!master_cs->name2 && !name2) return master_cs;
3361
3362                 if (strcmp(master_cs->name2, name2) == 0) {
3363                         return master_cs;
3364                 }
3365
3366                 return NULL;
3367         }
3368
3369         /*
3370          *      Else do it the old-fashioned way.
3371          */
3372         for (ci = cs->children; ci; ci = ci->next) {
3373                 CONF_SECTION *subcs;
3374
3375                 if (ci->type != CONF_ITEM_SECTION)
3376                         continue;
3377
3378                 subcs = cf_item_to_section(ci);
3379                 if (!subcs->name2) {
3380                         if (strcmp(subcs->name1, name2) == 0) break;
3381                 } else {
3382                         if (strcmp(subcs->name2, name2) == 0) break;
3383                 }
3384         }
3385
3386         return cf_item_to_section(ci);
3387 }
3388
3389 /*
3390  * Return the next subsection after a CONF_SECTION
3391  * with a certain name1 (char *name1). If the requested
3392  * name1 is NULL, any name1 matches.
3393  */
3394
3395 CONF_SECTION *cf_subsection_find_next(CONF_SECTION const *section,
3396                                       CONF_SECTION const *subsection,
3397                                       char const *name1)
3398 {
3399         CONF_ITEM       *ci;
3400
3401         if (!section) return NULL;
3402
3403         /*
3404          * If subsection is NULL this must be a first time run
3405          * Find the subsection with correct name
3406          */
3407
3408         if (!subsection) {
3409                 ci = section->children;
3410         } else {
3411                 ci = subsection->item.next;
3412         }
3413
3414         for (; ci; ci = ci->next) {
3415                 if (ci->type != CONF_ITEM_SECTION)
3416                         continue;
3417                 if ((name1 == NULL) ||
3418                     (strcmp(cf_item_to_section(ci)->name1, name1) == 0))
3419                         break;
3420         }
3421
3422         return cf_item_to_section(ci);
3423 }
3424
3425
3426 /*
3427  * Return the next section after a CONF_SECTION
3428  * with a certain name1 (char *name1). If the requested
3429  * name1 is NULL, any name1 matches.
3430  */
3431
3432 CONF_SECTION *cf_section_find_next(CONF_SECTION const *section,
3433                                    CONF_SECTION const *subsection,
3434                                    char const *name1)
3435 {
3436         if (!section) return NULL;
3437
3438         if (!section->item.parent) return NULL;
3439
3440         return cf_subsection_find_next(section->item.parent, subsection, name1);
3441 }
3442
3443 /** Return the next item after a CONF_ITEM.
3444  *
3445  */
3446 CONF_ITEM *cf_item_find_next(CONF_SECTION const *section, CONF_ITEM const *item)
3447 {
3448         if (!section) return NULL;
3449
3450         /*
3451          *      If item is NULL this must be a first time run
3452          *      Return the first item
3453          */
3454         if (item == NULL) {
3455                 return section->children;
3456         } else {
3457                 return item->next;
3458         }
3459 }
3460
3461 static void _pair_count(int *count, CONF_SECTION const *cs)
3462 {
3463         CONF_ITEM const *ci;
3464
3465         for (ci = cf_item_find_next(cs, NULL);
3466              ci != NULL;
3467              ci = cf_item_find_next(cs, ci)) {
3468
3469                 if (cf_item_is_section(ci)) {
3470                         _pair_count(count, cf_item_to_section(ci));
3471                         continue;
3472                 }
3473
3474                 (*count)++;
3475         }
3476 }
3477
3478 /** Count the number of conf pairs beneath a section
3479  *
3480  * @param[in] cs to search for items in.
3481  * @return number of pairs nested within section.
3482  */
3483 int cf_pair_count(CONF_SECTION const *cs)
3484 {
3485         int count = 0;
3486
3487         _pair_count(&count, cs);
3488
3489         return count;
3490 }
3491
3492 CONF_SECTION *cf_item_parent(CONF_ITEM const *ci)
3493 {
3494         if (!ci) return NULL;
3495
3496         return ci->parent;
3497 }
3498
3499 int cf_section_lineno(CONF_SECTION const *section)
3500 {
3501         return section->item.lineno;
3502 }
3503
3504 char const *cf_pair_filename(CONF_PAIR const *pair)
3505 {
3506         return pair->item.filename;
3507 }
3508
3509 char const *cf_section_filename(CONF_SECTION const *section)
3510 {
3511         return section->item.filename;
3512 }
3513
3514 int cf_pair_lineno(CONF_PAIR const *pair)
3515 {
3516         return pair->item.lineno;
3517 }
3518
3519 bool cf_item_is_section(CONF_ITEM const *item)
3520 {
3521         return item->type == CONF_ITEM_SECTION;
3522 }
3523
3524 bool cf_item_is_pair(CONF_ITEM const *item)
3525 {
3526         return item->type == CONF_ITEM_PAIR;
3527 }
3528
3529
3530 static CONF_DATA *cf_data_alloc(CONF_SECTION *parent, char const *name,
3531                                 void *data, void (*data_free)(void *))
3532 {
3533         CONF_DATA *cd;
3534
3535         cd = talloc_zero(parent, CONF_DATA);
3536         if (!cd) return NULL;
3537
3538         cd->item.type = CONF_ITEM_DATA;
3539         cd->item.parent = parent;
3540         cd->name = talloc_typed_strdup(cd, name);
3541         if (!cd->name) {
3542                 talloc_free(cd);
3543                 return NULL;
3544         }
3545
3546         cd->data = data;
3547         cd->free = data_free;
3548
3549         if (cd->free) {
3550                 talloc_set_destructor(cd, _cf_data_free);
3551         }
3552
3553         return cd;
3554 }
3555
3556 static void *cf_data_find_internal(CONF_SECTION const *cs, char const *name, int flag)
3557 {
3558         if (!cs || !name) return NULL;
3559
3560         /*
3561          *      Find the name in the tree, for speed.
3562          */
3563         if (cs->data_tree) {
3564                 CONF_DATA mycd;
3565
3566                 mycd.name = name;
3567                 mycd.flag = flag;
3568                 return rbtree_finddata(cs->data_tree, &mycd);
3569         }
3570
3571         return NULL;
3572 }
3573
3574 /*
3575  *      Find data from a particular section.
3576  */
3577 void *cf_data_find(CONF_SECTION const *cs, char const *name)
3578 {
3579         CONF_DATA *cd = cf_data_find_internal(cs, name, 0);
3580
3581         if (cd) return cd->data;
3582         return NULL;
3583 }
3584
3585
3586 /*
3587  *      Add named data to a configuration section.
3588  */
3589 static int cf_data_add_internal(CONF_SECTION *cs, char const *name,
3590                                 void *data, void (*data_free)(void *),
3591                                 int flag)
3592 {
3593         CONF_DATA *cd;
3594
3595         if (!cs || !name) return -1;
3596
3597         /*
3598          *      Already exists.  Can't add it.
3599          */
3600         if (cf_data_find_internal(cs, name, flag) != NULL) return -1;
3601
3602         cd = cf_data_alloc(cs, name, data, data_free);
3603         if (!cd) return -1;
3604         cd->flag = flag;
3605
3606         cf_item_add(cs, cf_data_to_item(cd));
3607
3608         return 0;
3609 }
3610
3611 /*
3612  *      Add named data to a configuration section.
3613  */
3614 int cf_data_add(CONF_SECTION *cs, char const *name,
3615                 void *data, void (*data_free)(void *))
3616 {
3617         return cf_data_add_internal(cs, name, data, data_free, 0);
3618 }
3619
3620 /** Remove named data from a configuration section
3621  *
3622  */
3623 void *cf_data_remove(CONF_SECTION *cs, char const *name)
3624 {
3625         CONF_DATA mycd;
3626         CONF_DATA *cd;
3627         CONF_ITEM *ci, *it;
3628         void *data;
3629
3630         if (!cs || !name) return NULL;
3631         if (!cs->data_tree) return NULL;
3632
3633         /*
3634          *      Find the name in the tree, for speed.
3635          */
3636         mycd.name = name;
3637         mycd.flag = 0;
3638         cd = rbtree_finddata(cs->data_tree, &mycd);
3639         if (!cd) return NULL;
3640
3641         ci = cf_data_to_item(cd);
3642         if (cs->children == ci) {
3643                 cs->children = ci->next;
3644                 if (cs->tail == ci) cs->tail = NULL;
3645         } else {
3646                 for (it = cs->children; it; it = it->next) {
3647                         if (it->next == ci) {
3648                                 it->next = ci->next;
3649                                 if (cs->tail == ci) cs->tail = it;
3650                                 break;
3651                         }
3652                 }
3653         }
3654
3655         talloc_set_destructor(cd, NULL);        /* Disarm the destructor */
3656         rbtree_deletebydata(cs->data_tree, &mycd);
3657
3658         data = cd->data;
3659         talloc_free(cd);
3660
3661         return data;
3662 }
3663
3664 /*
3665  *      This is here to make the rest of the code easier to read.  It
3666  *      ties conffile.c to log.c, but it means we don't have to
3667  *      pollute every other function with the knowledge of the
3668  *      configuration internals.
3669  */
3670 void cf_log_err(CONF_ITEM const *ci, char const *fmt, ...)
3671 {
3672         va_list ap;
3673         char buffer[256];
3674
3675         va_start(ap, fmt);
3676         vsnprintf(buffer, sizeof(buffer), fmt, ap);
3677         va_end(ap);
3678
3679         if (ci) {
3680                 ERROR("%s[%d]: %s",
3681                        ci->filename ? ci->filename : "unknown",
3682                        ci->lineno ? ci->lineno : 0,
3683                        buffer);
3684         } else {
3685                 ERROR("<unknown>[*]: %s", buffer);
3686         }
3687 }
3688
3689 void cf_log_err_cs(CONF_SECTION const *cs, char const *fmt, ...)
3690 {
3691         va_list ap;
3692         char buffer[256];
3693
3694         va_start(ap, fmt);
3695         vsnprintf(buffer, sizeof(buffer), fmt, ap);
3696         va_end(ap);
3697
3698         rad_assert(cs != NULL);
3699
3700         ERROR("%s[%d]: %s",
3701                cs->item.filename ? cs->item.filename : "unknown",
3702                cs->item.lineno ? cs->item.lineno : 0,
3703                buffer);
3704 }
3705
3706 void cf_log_err_cp(CONF_PAIR const *cp, char const *fmt, ...)
3707 {
3708         va_list ap;
3709         char buffer[256];
3710
3711         va_start(ap, fmt);
3712         vsnprintf(buffer, sizeof(buffer), fmt, ap);
3713         va_end(ap);
3714
3715         rad_assert(cp != NULL);
3716
3717         ERROR("%s[%d]: %s",
3718                cp->item.filename ? cp->item.filename : "unknown",
3719                cp->item.lineno ? cp->item.lineno : 0,
3720                buffer);
3721 }
3722
3723 void cf_log_info(CONF_SECTION const *cs, char const *fmt, ...)
3724 {
3725         va_list ap;
3726
3727         va_start(ap, fmt);
3728         if ((rad_debug_lvl > 1) && cs) vradlog(L_DBG, fmt, ap);
3729         va_end(ap);
3730 }
3731
3732 /*
3733  *      Wrapper to simplify the code.
3734  */
3735 void cf_log_module(CONF_SECTION const *cs, char const *fmt, ...)
3736 {
3737         va_list ap;
3738         char buffer[256];
3739
3740         va_start(ap, fmt);
3741         if (rad_debug_lvl > 1 && cs) {
3742                 vsnprintf(buffer, sizeof(buffer), fmt, ap);
3743
3744                 DEBUG("%.*s# %s", cs->depth, parse_spaces, buffer);
3745         }
3746         va_end(ap);
3747 }
3748
3749 const CONF_PARSER *cf_section_parse_table(CONF_SECTION *cs)
3750 {
3751         if (!cs) return NULL;
3752
3753         return cs->variables;
3754 }
3755
3756 /*
3757  *      For "switch" and "case" statements.
3758  */
3759 FR_TOKEN cf_section_name2_type(CONF_SECTION const *cs)
3760 {
3761         if (!cs) return T_INVALID;
3762
3763         return cs->name2_type;
3764 }