projects
/
freeradius.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
cf4f6f2
)
Use memmove instead of memcpy. Fixes coverity complaint.
author
Alan T. DeKok
<aland@freeradius.org>
Mon, 1 Sep 2014 14:37:03 +0000
(10:37 -0400)
committer
Alan T. DeKok
<aland@freeradius.org>
Mon, 1 Sep 2014 14:37:03 +0000
(10:37 -0400)
But doesn't change anything, because "hdr_len" is always a small
value. It's just not checked as such, so coverity doesn't pick up
on it
src/lib/radius.c
patch
|
blob
|
history
diff --git
a/src/lib/radius.c
b/src/lib/radius.c
index
0a40682
..
3bd6b25
100644
(file)
--- a/
src/lib/radius.c
+++ b/
src/lib/radius.c
@@
-1041,7
+1041,7
@@
static ssize_t attr_shift(uint8_t const *start, uint8_t const *end,
len -= sublen;
memmove(ptr + 255 + hdr_len, ptr + 255, sublen);
- mem
cpy
(ptr + 255, ptr, hdr_len);
+ mem
move
(ptr + 255, ptr, hdr_len);
ptr[1] += sublen;
if (vsa_offset) ptr[vsa_offset] += sublen;
ptr[flag_offset] |= 0x80;