Check for NULL secret on dynamic clients
authorAlan T. DeKok <aland@freeradius.org>
Wed, 29 Aug 2012 16:40:03 +0000 (18:40 +0200)
committerAlan T. DeKok <aland@freeradius.org>
Wed, 29 Aug 2012 16:44:36 +0000 (18:44 +0200)
src/main/client.c

index 59a14d1..dbfaa1e 100644 (file)
@@ -1093,6 +1093,13 @@ RADCLIENT *client_create(RADCLIENT_LIST *clients, REQUEST *request)
                goto error;
        }
 
+       if (!c->secret || !*c->secret) {
+               DEBUG("- Cannot add client %s: No secret was specified.",
+                     ip_ntoh(&request->packet->src_ipaddr,
+                             buffer, sizeof(buffer)));
+               goto error;
+       }
+
        if (!client_validate(clients, request->client, c)) {
                return NULL;
        }