Fix two pointer signedness warnings
authorNikolai Kondrashov <Nikolai.Kondrashov@redhat.com>
Thu, 29 Jan 2015 19:39:44 +0000 (21:39 +0200)
committerNikolai Kondrashov <Nikolai.Kondrashov@redhat.com>
Fri, 30 Jan 2015 16:16:32 +0000 (18:16 +0200)
This fixes the following compiler warnings:

freeradius-server-2.2.6/src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c: scope_hint: In function 'cbtls_verify'
freeradius-server-2.2.6/src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c:711: warning: pointer targets in passing argument 2 of 'pairmake' differ in signedness
freeradius-server-2.2.6/src/include/libradius.h:373: note: expected 'const char *' but argument is of type 'unsigned char *'

freeradius-server-2.2.6/src/modules/rlm_expr/rlm_expr.c: scope_hint: In function 'base64_to_hex_xlat'
freeradius-server-2.2.6/src/modules/rlm_expr/rlm_expr.c:678: warning: pointer targets in passing argument 1 of 'fr_bin2hex' differ in signedness
freeradius-server-2.2.6/src/include/libradius.h:418: note: expected 'const uint8_t *' but argument is of type 'char *'

src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c
src/modules/rlm_expr/rlm_expr.c

index 434f248..a958d04 100644 (file)
@@ -710,7 +710,7 @@ static int cbtls_verify(int ok, X509_STORE_CTX *ctx)
 
                                        pairadd(&handler->certs,
                                                pairmake(cert_attr_names[EAPTLS_SAN_EMAIL][lookup],
-                                                        ASN1_STRING_data(name->d.rfc822Name), T_OP_SET));
+                                                        (char *)ASN1_STRING_data(name->d.rfc822Name), T_OP_SET));
                                        break;
                                default:
                                        /* XXX TODO handle other SAN types */
index 3aa2a49..c4476cc 100644 (file)
@@ -675,7 +675,7 @@ static size_t base64_to_hex_xlat(UNUSED void *instance, REQUEST *request,
                       "have %zd bytes", (declen * 2) + 1, outlen);
        }
 
-       fr_bin2hex(decbuf, out, declen);
+       fr_bin2hex((uint8_t *)decbuf, out, declen);
 
        return declen * 2;
 }