Return -1 on error, not NULL
authoraland <aland>
Tue, 6 Feb 2007 13:57:09 +0000 (13:57 +0000)
committeraland <aland>
Tue, 6 Feb 2007 13:57:09 +0000 (13:57 +0000)
The file permission checks here are probably too strong..

src/main/conffile.c

index 8c036b1..4d2f812 100644 (file)
@@ -1216,7 +1216,7 @@ int cf_file_include(const char *file, CONF_SECTION *cs)
                if ((statbuf.st_mode & S_IROTH) != 0) {
                        radlog(L_ERR|L_CONS, "Configuration file %s is globally readable.  Refusing to start due to insecure configuration.",
                               file);
-                       return NULL;
+                       return -1;
                }
        }