Treat bad records as EOF.

This helps when the disk is full, and rlm_detail writes a partial record.

diff --git a/src/modules/frs_detail/frs_detail.c b/src/modules/frs_detail/frs_detail.c
index 921dc31..5bd42a7 100644 (file)
--- a/src/modules/frs_detail/frs_detail.c
+++ b/src/modules/frs_detail/frs_detail.c
@@ -731,7 +731,16 @@ int detail_recv(rad_listen_t *listener,
  alloc_packet:
        data->tries++;
        
-       rad_assert(data->state == STATE_QUEUED);
+       /*
+        *      The writer doesn't check that the record was
+        *      completely written.  If the disk is full, this can
+        *      result in a truncated record.  When that happens,
+        *      treat it as EOF.
+        */
+       if (data->state != STATE_QUEUED) {
+               radlog(L_ERR, "Truncated record: treating it as EOF for detail file %s", data->filename_work);
+               goto cleanup;     
+       }
 
        /*
         *      We're done reading the file, but we didn't read