Check tag values, too.

When comparing attributes, both tag AND value have to match
for the attributes to compare as equal.

Closes Coverity #59

diff --git a/src/main/valuepair.c b/src/main/valuepair.c
index 1482238..d6b2382 100644 (file)
--- a/src/main/valuepair.c
+++ b/src/main/valuepair.c
@@ -181,7 +181,7 @@ int radius_compare_vps(REQUEST *request, VALUE_PAIR *check, VALUE_PAIR *vp)
         *      Tagged attributes are equal if and only if both the
         *      tag AND value match.
         */
-       if ((ret == 0) && check->flags.has_tag) {
+       if (check->flags.has_tag) {
                ret = ((int) vp->flags.tag) - ((int) check->flags.tag);
                if (ret != 0) return ret;
        }