SoH isn't very useful without attributes
authorMatthew Newton <mcn4@leicester.ac.uk>
Thu, 26 Nov 2015 11:24:44 +0000 (11:24 +0000)
committerMatthew Newton <mcn4@leicester.ac.uk>
Thu, 26 Nov 2015 12:18:35 +0000 (12:18 +0000)
Broken in c11e3d8454 by no longer setting fake->packet->vps.

eapsoh_verify has no need to see the original request as long
as it's got access to the data to parse, so just pass in the
fake request and get the attributes created there directly.

doc/ChangeLog
src/modules/rlm_eap/types/rlm_eap_peap/peap.c

index 6a08d57..52e302c 100644 (file)
@@ -34,6 +34,7 @@ FreeRADIUS 3.0.11 Mon 05 Oct 2015 15:00:00 EDT urgency=medium
        * Fixed bug with radmin related to the option "stats detail <filename>"
        * Complain if the detail file reader does not have permission
          to read the "detail.work" file.  Fixes #1398
+       * Fixed SoH. Attributes were not being copied to the virtual server.
 
 FreeRADIUS 3.0.10 Mon 05 Oct 2015 15:00:00 EDT urgency=medium
        Feature improvements
index bdb11d6..79c30d1 100644 (file)
@@ -804,7 +804,7 @@ rlm_rcode_t eappeap_process(eap_handler_t *handler, tls_session_t *tls_session)
        case PEAP_STATUS_WAIT_FOR_SOH_RESPONSE:
                fake = request_alloc_fake(request);
                rad_assert(!fake->packet->vps);
-               eapsoh_verify(request, fake->packet, data, data_len);
+               eapsoh_verify(fake, fake->packet, data, data_len);
                setup_fake_request(request, fake, t);
 
                if (t->soh_virtual_server) {