Remove unnecessary check to update REALM
authorAlejandro Perez <alejandro.perez.mendez@gmail.com>
Tue, 9 May 2017 12:13:52 +0000 (14:13 +0200)
committerAlejandro Perez <alejandro.perez.mendez@gmail.com>
Tue, 9 May 2017 12:32:19 +0000 (14:32 +0200)
Existing code precluded a REALM from being updated if there were traffic within the last 5 minutes.
This is an error since when the TLS keys expire, the home server will reject client’s attempts to establish a connection, leading to up to 5 minutes of denied user authentications.

src/modules/rlm_realm/trustrouter.c

index 1636a4b..44a7cfe 100644 (file)
@@ -321,14 +321,6 @@ static bool update_required(REALM const *r)
                }
 
                /*
-                *      This server has received a packet in the last
-                *      5 minutes.  It doesn't need an update.
-                */
-               if ((now - server->last_packet_recv) < 300) {
-                       return false;
-               }
-
-               /*
                 *      If we've opened in the last 10 minutes, then
                 *      open rather than update.
                 */