This patch changes the return code within the CISCO_ACCOUNTING_HACK from FAIL to...

If a FAIL is returned, freeradius does not sent an ACK to the NAS that sent the stop
packet, so it just keeps resending.  NOOP is more appropriate.

diff --git a/src/modules/rlm_sql/rlm_sql.c b/src/modules/rlm_sql/rlm_sql.c
index 2d1e6bc..9b1a162 100644 (file)
--- a/src/modules/rlm_sql/rlm_sql.c
+++ b/src/modules/rlm_sql/rlm_sql.c
@@ -550,7 +550,7 @@ static int rlm_sql_accounting(void *instance, REQUEST * request) {
                                                        radius_xlat(logstr, MAX_QUERY_LEN, "rlm_sql:  Stop packet with zero session length.  (user '%{User-Name}', nas '%{NAS-IP-Address}')", request, NULL);
                                                        radlog(L_ERR, logstr);
                                                        sql_release_socket(inst, sqlsocket);
-                                                       return RLM_MODULE_FAIL;
+                                                       return RLM_MODULE_NOOP;
                                                }
 #endif