secret is NULL for LOCAL realms.
authorAlan T. DeKok <aland@freeradius.org>
Mon, 1 Dec 2008 13:40:00 +0000 (14:40 +0100)
committerAlan T. DeKok <aland@freeradius.org>
Mon, 1 Dec 2008 16:47:25 +0000 (17:47 +0100)
Fixes Coverity #68

src/main/realms.c

index e191ae1..b56062e 100644 (file)
@@ -921,7 +921,7 @@ static int old_server_add(realm_config_t *rc, CONF_SECTION *cs,
        myhome.type = type;
        home = rbtree_finddata(home_servers_byname, &myhome);
        if (home) {
-               if (strcmp(home->secret, secret) != 0) {
+               if (secret && (strcmp(home->secret, secret) != 0)) {
                        cf_log_err(cf_sectiontoitem(cs), "Inconsistent shared secret for home server \"%s\"", name);
                        return 0;
                }