FR-GV-305 read the correct offset instead of uninitialized memory

diff --git a/src/lib/radius.c b/src/lib/radius.c
index 81a8066..2ecaabf 100644 (file)
--- a/src/lib/radius.c
+++ b/src/lib/radius.c
@@ -4086,7 +4086,7 @@ ssize_t data2vp(TALLOC_CTX *ctx,
                break;
 
        case PW_TYPE_SIGNED:    /* overloaded with vp_integer */
-               memcpy(&vp->vp_integer, buffer, 4);
+               memcpy(&vp->vp_integer, data, 4);
                vp->vp_integer = ntohl(vp->vp_integer);
                break;
 

diff --git a/src/tests/dictionary.test b/src/tests/dictionary.test
index af84f2c..1b3130f 100644 (file)
--- a/src/tests/dictionary.test
+++ b/src/tests/dictionary.test
@@ -7,4 +7,5 @@ BEGIN-VENDOR TEST
 ATTRIBUTE      Test-Name               1 string
 ATTRIBUTE      Test-Number             2 integer
 ATTRIBUTE      Test-Server-Port        3 integer
+ATTRIBUTE      Test-Signed             4 signed
 END-VENDOR TEST

diff --git a/src/tests/unit/wimax.txt b/src/tests/unit/wimax.txt
index 6e373d5..f9d416a 100644 (file)
--- a/src/tests/unit/wimax.txt
+++ b/src/tests/unit/wimax.txt
@@ -155,3 +155,9 @@ data WiMAX-Release = "EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE
 decode 1a 0b 00 00 60 b5 31 05 80 00 00
 data Attr-26 = 0x000060b53105800000
 
+encode WiMAX-GMT-Timezone-offset = -1
+data 1a 0d 00 00 60 b5 03 07 00 ff ff ff ff
+
+decode -
+data WiMAX-GMT-Timezone-offset = -1
+