don't use i for inner and outer loop. Found by PVS-Studio
authorAlan T. DeKok <aland@freeradius.org>
Wed, 17 May 2017 15:26:54 +0000 (11:26 -0400)
committerAlan T. DeKok <aland@freeradius.org>
Fri, 19 May 2017 18:06:52 +0000 (14:06 -0400)
src/lib/misc.c

index 587482f..6449b29 100644 (file)
@@ -1871,7 +1871,7 @@ static char *mystrtok(char **ptr, char const *sep)
  */
 int fr_get_time(char const *date_str, time_t *date)
 {
-       int             i;
+       int             i, j;
        time_t          t;
        struct tm       *tm, s_tm;
        char            buf[64];
@@ -1928,9 +1928,9 @@ int fr_get_time(char const *date_str, time_t *date)
                        f[0] = f[i];
                        f[i] = p;
 
-                       for (i = 0; i < 12; i++) {
-                               if (strncasecmp(months[i], f[0], 3) == 0) {
-                                       tm->tm_mon = i;
+                       for (j = 0; j < 12; j++) {
+                               if (strncasecmp(months[j], f[0], 3) == 0) {
+                                       tm->tm_mon = j;
                                        break;
                                }
                        }