freeradius.git
9 years agoA number of fixes (mainly comments) of rlm_expr release_3_0_4_rc2
Herwin Weststrate [Thu, 14 Aug 2014 11:07:48 +0000 (13:07 +0200)]
A number of fixes (mainly comments) of rlm_expr

* Update the urlunquote example to make it copy-pastable by doubling the %. Add a comment why
* Typo fix: s/wont'/won't/
* Removed UNUSED macro for *instance in (un)escape_xlat, it is being used here
* Fix the unuescape example, the name here should be unescape, not escape
* Added a ":" after "Example" in tolower. This makes it easier to find the examples in this file, since all other examples did this.

9 years agoFixed a typo in a code comment for LM-Response
Herwin Weststrate [Tue, 22 Jul 2014 16:45:11 +0000 (18:45 +0200)]
Fixed a typo in a code comment for LM-Response

9 years agoMerge pull request #758 from spbnick/trigger_max_threads_on_limit
Alan DeKok [Fri, 22 Aug 2014 11:15:37 +0000 (07:15 -0400)]
Merge pull request #758 from spbnick/trigger_max_threads_on_limit

Trigger max_threads upon reaching the limit

9 years agoDefine sig_t for systems without it. Closes #765
Alan T. DeKok [Fri, 22 Aug 2014 10:55:12 +0000 (06:55 -0400)]
Define sig_t for systems without it.  Closes #765

9 years agonote recent changes
Alan T. DeKok [Thu, 21 Aug 2014 11:29:36 +0000 (07:29 -0400)]
note recent changes

9 years agoPassing const to non-const
Alan T. DeKok [Thu, 21 Aug 2014 11:26:33 +0000 (07:26 -0400)]
Passing const to non-const

9 years agoExpand switch arguments once, instead of for each 'case'
Alan T. DeKok [Thu, 21 Aug 2014 10:57:33 +0000 (06:57 -0400)]
Expand switch arguments once, instead of for each 'case'

9 years agoFix error in sqlite3 postauth query
Arran Cudbard-Bell [Wed, 20 Aug 2014 08:27:46 +0000 (15:27 +0700)]
Fix error in sqlite3 postauth query

9 years agoUse "virtual_server", which is correct
Alan T. DeKok [Fri, 15 Aug 2014 13:33:14 +0000 (15:33 +0200)]
Use "virtual_server", which is correct

9 years agoIgnore flags
Alan T. DeKok [Fri, 15 Aug 2014 12:04:44 +0000 (14:04 +0200)]
Ignore flags

9 years agoDocument "pool = ..."
Alan T. DeKok [Fri, 15 Aug 2014 09:19:14 +0000 (11:19 +0200)]
Document "pool = ..."

9 years agoUpdate for new pools
Alan T. DeKok [Fri, 15 Aug 2014 08:50:07 +0000 (10:50 +0200)]
Update for new pools

9 years agoFix paircopyvp, so we don't break xlat expansions
Arran Cudbard-Bell [Thu, 14 Aug 2014 22:23:16 +0000 (18:23 -0400)]
Fix paircopyvp, so we don't break xlat expansions

9 years agoFormatting
Arran Cudbard-Bell [Thu, 14 Aug 2014 22:22:59 +0000 (18:22 -0400)]
Formatting

9 years agoFound should be a bool
Arran Cudbard-Bell [Thu, 14 Aug 2014 22:22:47 +0000 (18:22 -0400)]
Found should be a bool

9 years agoFix section lookup in radwho
Arran Cudbard-Bell [Thu, 14 Aug 2014 21:52:35 +0000 (17:52 -0400)]
Fix section lookup in radwho

9 years agoFixup policies to use attribute references
Arran Cudbard-Bell [Thu, 14 Aug 2014 21:24:47 +0000 (17:24 -0400)]
Fixup policies to use attribute references

9 years agoFix parenting issue in paircmp.c
Arran Cudbard-Bell [Thu, 14 Aug 2014 20:53:12 +0000 (16:53 -0400)]
Fix parenting issue in paircmp.c

9 years agoSoft assert and exit on internal validation error
Arran Cudbard-Bell [Thu, 14 Aug 2014 20:52:34 +0000 (16:52 -0400)]
Soft assert and exit on internal validation error

9 years agoCleanup formatting in rlm_realm
Arran Cudbard-Bell [Thu, 14 Aug 2014 20:12:45 +0000 (16:12 -0400)]
Cleanup formatting in rlm_realm

9 years agoFixup weirdness in couchbase configure.ac
Arran Cudbard-Bell [Thu, 14 Aug 2014 19:02:39 +0000 (15:02 -0400)]
Fixup weirdness in couchbase configure.ac

9 years agoName for stdin should be "-" for backwards compatibility
Arran Cudbard-Bell [Thu, 14 Aug 2014 18:46:49 +0000 (14:46 -0400)]
Name for stdin should be "-" for backwards compatibility

9 years agoMinor fix
Arran Cudbard-Bell [Thu, 14 Aug 2014 02:43:41 +0000 (22:43 -0400)]
Minor fix

9 years agotimestr_match returns int, not uint32_t
Alan T. DeKok [Thu, 14 Aug 2014 15:04:51 +0000 (17:04 +0200)]
timestr_match returns int, not uint32_t

9 years agoRe-arrange code to be cleaner
Alan T. DeKok [Thu, 14 Aug 2014 14:10:08 +0000 (16:10 +0200)]
Re-arrange code to be cleaner

9 years agoNote recent changes
Alan T. DeKok [Thu, 14 Aug 2014 13:55:52 +0000 (15:55 +0200)]
Note recent changes

9 years agoBe more generous about the lack of whitespace
Alan T. DeKok [Thu, 14 Aug 2014 12:52:59 +0000 (14:52 +0200)]
Be more generous about the lack of whitespace

9 years agoSet variable to default value.
Alan T. DeKok [Thu, 14 Aug 2014 11:41:50 +0000 (13:41 +0200)]
Set variable to default value.

9 years agoBuild on FreeBSD
Alan T. DeKok [Thu, 14 Aug 2014 11:40:46 +0000 (13:40 +0200)]
Build on FreeBSD

9 years agoAllow for enforcement in post-auth
Alan T. DeKok [Thu, 14 Aug 2014 08:15:29 +0000 (10:15 +0200)]
Allow for enforcement in post-auth

Which is really where they should be

9 years agomake sqlite defaults a bit friendlier
Arran Cudbard-Bell [Thu, 14 Aug 2014 02:38:50 +0000 (22:38 -0400)]
make sqlite defaults a bit friendlier

9 years agoAssert head pointer isn't NULL if sql_get_grouplist returned 1 or more groups
Arran Cudbard-Bell [Wed, 13 Aug 2014 21:28:03 +0000 (17:28 -0400)]
Assert head pointer isn't NULL if sql_get_grouplist returned 1 or more groups

9 years agoNeed to process at least one group entry before we check if we need to continue
Arran Cudbard-Bell [Wed, 13 Aug 2014 21:23:09 +0000 (17:23 -0400)]
Need to process at least one group entry before we check if we need to continue

9 years agoFix for calling foreach sections at varying depths
Arran Cudbard-Bell [Tue, 12 Aug 2014 15:46:41 +0000 (11:46 -0400)]
Fix for calling foreach sections at varying depths

9 years agoCall VERIFY_VP from vp_prints_value
Arran Cudbard-Bell [Tue, 12 Aug 2014 15:42:52 +0000 (11:42 -0400)]
Call VERIFY_VP from vp_prints_value

9 years agoCleanup request_data functions
Arran Cudbard-Bell [Tue, 12 Aug 2014 15:42:35 +0000 (11:42 -0400)]
Cleanup request_data functions

9 years agoSmall code cleanup in rlm_perl config parser
Herwin Weststrate [Tue, 12 Aug 2014 08:18:54 +0000 (10:18 +0200)]
Small code cleanup in rlm_perl config parser

Less repetitive code

9 years agoReplaced Nullav with (AV*)NULL in rlm_perl
Herwin Weststrate [Mon, 11 Aug 2014 17:25:26 +0000 (19:25 +0200)]
Replaced Nullav with (AV*)NULL in rlm_perl

Nullav is deperacted, see http://perldoc.perl.org/5.12.1/perlapi.html#Handy-Values

9 years agoShould return NOOP, not fail, to be consistent with other modules
Arran Cudbard-Bell [Mon, 11 Aug 2014 13:42:38 +0000 (09:42 -0400)]
Should return NOOP, not fail, to be consistent with other modules

9 years agoHandle no config for section. Closes #759
Alan T. DeKok [Mon, 11 Aug 2014 12:43:39 +0000 (14:43 +0200)]
Handle no config for section.  Closes #759

9 years agoFix naming in map.c
Arran Cudbard-Bell [Mon, 11 Aug 2014 03:15:14 +0000 (23:15 -0400)]
Fix naming in map.c

9 years agoMark rad_assert_fail as never returning
Arran Cudbard-Bell [Sun, 10 Aug 2014 15:50:12 +0000 (11:50 -0400)]
Mark rad_assert_fail as never returning

9 years agoAggregate tmpl and map functions in their own .c/.h files
Arran Cudbard-Bell [Sun, 10 Aug 2014 14:53:47 +0000 (10:53 -0400)]
Aggregate tmpl and map functions in their own .c/.h files

Rename all 'vpt' references to tmpl

9 years agoUpdate ChangeLog
Arran Cudbard-Bell [Sat, 9 Aug 2014 00:02:27 +0000 (20:02 -0400)]
Update ChangeLog

9 years agoRelease the socket used to load LDAP clients
Arran Cudbard-Bell [Fri, 8 Aug 2014 23:49:53 +0000 (19:49 -0400)]
Release the socket used to load LDAP clients

9 years agoAdd 'Warning:' prefix
Arran Cudbard-Bell [Fri, 8 Aug 2014 16:24:39 +0000 (12:24 -0400)]
Add 'Warning:' prefix

9 years agoNumber of active connections should not be signed
Arran Cudbard-Bell [Fri, 8 Aug 2014 15:17:35 +0000 (11:17 -0400)]
Number of active connections should not be signed

9 years agoFormatting in threads.c
Arran Cudbard-Bell [Fri, 8 Aug 2014 14:32:00 +0000 (10:32 -0400)]
Formatting in threads.c

9 years agoassert(pool->active == pool->num) if we can't find any free connections
Arran Cudbard-Bell [Wed, 6 Aug 2014 22:14:21 +0000 (18:14 -0400)]
assert(pool->active == pool->num) if we can't find any free connections

9 years agoFix weird loop in connection.c
Arran Cudbard-Bell [Wed, 6 Aug 2014 22:07:25 +0000 (18:07 -0400)]
Fix weird loop in connection.c

9 years agoTrigger max_threads upon reaching the limit
Nikolai Kondrashov [Thu, 7 Aug 2014 12:57:57 +0000 (15:57 +0300)]
Trigger max_threads upon reaching the limit

Trigger "max_threads" event (and thus "threadMaxThreads" trap, with
default SNMP configuration) upon reaching "max_servers" thread limit,
instead of on an attempt to exceed it, as the latter never happens.

9 years agoAdd more verbose logging for the connection pool
Arran Cudbard-Bell [Wed, 6 Aug 2014 16:26:11 +0000 (12:26 -0400)]
Add more verbose logging for the connection pool

9 years agoDoxygen
Arran Cudbard-Bell [Wed, 6 Aug 2014 15:07:49 +0000 (11:07 -0400)]
Doxygen

9 years agoDistinguish between single VP inserts, and list merges
Arran Cudbard-Bell [Wed, 6 Aug 2014 14:48:24 +0000 (10:48 -0400)]
Distinguish between single VP inserts, and list merges

9 years agoForce should be a bool
Arran Cudbard-Bell [Tue, 5 Aug 2014 19:01:45 +0000 (15:01 -0400)]
Force should be a bool

9 years agoRefactor radius_map2vp and add support for returning multiple attributes from RHS...
Arran Cudbard-Bell [Tue, 5 Aug 2014 03:10:39 +0000 (23:10 -0400)]
Refactor radius_map2vp and add support for returning multiple attributes from RHS attr references

9 years agoMake it clearer how the switch-attr-cmp test failed
Arran Cudbard-Bell [Tue, 5 Aug 2014 01:00:17 +0000 (21:00 -0400)]
Make it clearer how the switch-attr-cmp test failed

9 years agoAllow Attr[*] in radius_parse_attr
Arran Cudbard-Bell [Tue, 5 Aug 2014 00:57:54 +0000 (20:57 -0400)]
Allow Attr[*] in radius_parse_attr

9 years agoradius_parse_attr writes nice descriptive errors to the error buffer, so use them...
Arran Cudbard-Bell [Mon, 4 Aug 2014 21:43:07 +0000 (17:43 -0400)]
radius_parse_attr writes nice descriptive errors to the error buffer, so use them...

9 years agomake radius_tmply_copy_vp respect instance numbers and NUM_ALL (*)
Arran Cudbard-Bell [Mon, 4 Aug 2014 19:31:29 +0000 (15:31 -0400)]
make radius_tmply_copy_vp respect instance numbers and NUM_ALL (*)

9 years agoRename 'paircopy2' to 'paircopy_by_num'
Arran Cudbard-Bell [Mon, 4 Aug 2014 18:41:39 +0000 (14:41 -0400)]
Rename 'paircopy2' to 'paircopy_by_num'

9 years agoNested extern
Alan T. DeKok [Sun, 3 Aug 2014 06:41:36 +0000 (08:41 +0200)]
Nested extern

9 years agoDon't open proxy UDP socket if it's not needed
Alan T. DeKok [Sat, 2 Aug 2014 16:36:17 +0000 (18:36 +0200)]
Don't open proxy UDP socket if it's not needed

9 years agoRemove double xlat
Alan T. DeKok [Sat, 2 Aug 2014 12:14:12 +0000 (14:14 +0200)]
Remove double xlat

9 years agorename radiusProfileDn to radiusProfileDN
Arran Cudbard-Bell [Wed, 30 Jul 2014 01:35:15 +0000 (21:35 -0400)]
rename radiusProfileDn to radiusProfileDN

9 years agoCN should not be required in radiusProfile schema
Arran Cudbard-Bell [Tue, 29 Jul 2014 19:24:03 +0000 (15:24 -0400)]
CN should not be required in radiusProfile schema

9 years agoUse PSK only if PSK is available
Alan T. DeKok [Tue, 29 Jul 2014 16:26:35 +0000 (18:26 +0200)]
Use PSK only if PSK is available

9 years agoFix OpenSSL checks/linking in modules
Arran Cudbard-Bell [Mon, 28 Jul 2014 19:52:13 +0000 (15:52 -0400)]
Fix OpenSSL checks/linking in modules

9 years agoit's OK for this->server to be NULL
Alan T. DeKok [Mon, 28 Jul 2014 16:15:09 +0000 (12:15 -0400)]
it's OK for this->server to be NULL

9 years agoFix comment. Closes #745
Alan T. DeKok [Sun, 27 Jul 2014 23:10:11 +0000 (19:10 -0400)]
Fix comment. Closes #745

9 years agoRemove redundant pcap.h include
Arran Cudbard-Bell [Sun, 27 Jul 2014 15:21:51 +0000 (11:21 -0400)]
Remove redundant pcap.h include

9 years agoMove net functions which don't depend on PCAP libraries into net.c
Arran Cudbard-Bell [Sun, 27 Jul 2014 15:06:34 +0000 (11:06 -0400)]
Move net functions which don't depend on PCAP libraries into net.c

9 years agoPutting every source file on its own line makes it easier to resolve merge errors
Arran Cudbard-Bell [Sun, 27 Jul 2014 14:14:56 +0000 (10:14 -0400)]
Putting every source file on its own line makes it easier to resolve merge errors

9 years agoThe last 2 functions require pcap.
Alan T. DeKok [Sun, 27 Jul 2014 13:27:03 +0000 (09:27 -0400)]
The last 2 functions require pcap.

9 years agorlm_otp doesn't need a configure script
Arran Cudbard-Bell [Sat, 26 Jul 2014 15:05:24 +0000 (11:05 -0400)]
rlm_otp doesn't need a configure script

9 years agoImport/Export from Apache DS to cleanup formatting
Arran Cudbard-Bell [Sat, 26 Jul 2014 14:21:34 +0000 (10:21 -0400)]
Import/Export from Apache DS to cleanup formatting

9 years agoTypo in clients schema
Arran Cudbard-Bell [Sat, 26 Jul 2014 13:23:31 +0000 (09:23 -0400)]
Typo in clients schema

9 years agoOnly include pcap.h if we have libpcap
Arran Cudbard-Bell [Fri, 25 Jul 2014 20:47:46 +0000 (16:47 -0400)]
Only include pcap.h if we have libpcap

9 years agoOrganise LDAP schemas better
Arran Cudbard-Bell [Fri, 25 Jul 2014 20:06:30 +0000 (16:06 -0400)]
Organise LDAP schemas better

9 years agoChange IANA number in LDAP schemas from 3317 to 11344
Arran Cudbard-Bell [Fri, 25 Jul 2014 19:48:01 +0000 (15:48 -0400)]
Change IANA number in LDAP schemas from 3317 to 11344

No idea who 'Port Community Rotterdam' are, but we have our own IANA number, so should be using it.

9 years agoHack to get TLS-PSK-Identity
Alan T. DeKok [Thu, 24 Jul 2014 00:59:50 +0000 (20:59 -0400)]
Hack to get TLS-PSK-Identity

9 years agoNeeds cast to long long int
Arran Cudbard-Bell [Fri, 25 Jul 2014 16:47:23 +0000 (12:47 -0400)]
Needs cast to long long int

9 years agoprint 64bit rlm_expr result
Arran Cudbard-Bell [Fri, 25 Jul 2014 16:25:39 +0000 (12:25 -0400)]
print 64bit rlm_expr result

9 years agoContinue to build functions which don't rely on libpcap, when we don't have libpcap
Arran Cudbard-Bell [Wed, 23 Jul 2014 16:49:32 +0000 (12:49 -0400)]
Continue to build functions which don't rely on libpcap, when we don't have libpcap

9 years agoFix formatting of switch statements
Arran Cudbard-Bell [Wed, 23 Jul 2014 16:40:57 +0000 (12:40 -0400)]
Fix formatting of switch statements

9 years agoMerge pull request #742 from qnet-herwin/rlm_perl_v3.0.x
Arran Cudbard-Bell [Tue, 22 Jul 2014 17:23:22 +0000 (13:23 -0400)]
Merge pull request #742 from qnet-herwin/rlm_perl_v3.0.x

Fix error in attribute copying to rlm_perl

9 years agoFix error in attribute copying to rlm_perl
Herwin Weststrate [Tue, 22 Jul 2014 15:56:57 +0000 (17:56 +0200)]
Fix error in attribute copying to rlm_perl

Introduced in commit c225c615760d4c907640ebd249f860d5ab3258dd. It copied the RAD_REPLY hash twice, which had the side effects that some keys dropped out.

9 years agoDebian: Ensure some directories exist
Herwin Weststrate [Tue, 15 Jul 2014 10:04:13 +0000 (12:04 +0200)]
Debian: Ensure some directories exist

This prevents some warnings when installing the package.

9 years agoOther perl formatting
Arran Cudbard-Bell [Mon, 21 Jul 2014 14:30:18 +0000 (10:30 -0400)]
Other perl formatting

9 years agoFix multivalues attributes in rlm_perl. Addresses #731, Addresses #722
Arran Cudbard-Bell [Mon, 21 Jul 2014 14:25:25 +0000 (10:25 -0400)]
Fix multivalues attributes in rlm_perl. Addresses #731, Addresses #722

9 years agoAdd the gigawords calculation for MSSQL in accounting stop SQL clause
root [Mon, 21 Jul 2014 06:42:42 +0000 (06:42 +0000)]
Add the gigawords calculation for MSSQL in accounting stop SQL clause

9 years agoAdded a NULL check to rlm_perl
Herwin Weststrate [Sun, 20 Jul 2014 08:57:21 +0000 (10:57 +0200)]
Added a NULL check to rlm_perl

Otherwise, trying to start rlm_perl with an invalid file parameter would cause a segfault.

9 years agoMerge pull request #732 from nchaigne/v3.0.x
Arran Cudbard-Bell [Wed, 16 Jul 2014 18:51:30 +0000 (14:51 -0400)]
Merge pull request #732 from nchaigne/v3.0.x

dhcpclient - timeout and decline, release, inform

9 years agoMerge pull request #734 from spbnick/switch_cnf_to_sha256
Arran Cudbard-Bell [Wed, 16 Jul 2014 18:50:27 +0000 (14:50 -0400)]
Merge pull request #734 from spbnick/switch_cnf_to_sha256

Switch .cnf files to sha256 message digest

9 years agoMerge pull request #736 from spbnick/add_rlm_krb5_doc
Arran Cudbard-Bell [Wed, 16 Jul 2014 18:50:08 +0000 (14:50 -0400)]
Merge pull request #736 from spbnick/add_rlm_krb5_doc

Add minimal rlm_krb5 documentation file

9 years agoMerge pull request #735 from spbnick/add_P_option_to_man_pages
Arran Cudbard-Bell [Wed, 16 Jul 2014 18:49:51 +0000 (14:49 -0400)]
Merge pull request #735 from spbnick/add_P_option_to_man_pages

Add description of -P option to man pages

9 years agoMerge pull request #733 from spbnick/clarify_snmp_trap_conditions
Arran Cudbard-Bell [Wed, 16 Jul 2014 18:49:22 +0000 (14:49 -0400)]
Merge pull request #733 from spbnick/clarify_snmp_trap_conditions

Clarify conditions of limit hit SNMP notifications

9 years agoAdd description of -P option to man pages
Nikolai Kondrashov [Wed, 16 Jul 2014 16:59:03 +0000 (19:59 +0300)]
Add description of -P option to man pages

Add description of -P option to radtest and radclient man pages.

9 years agoClarify conditions of limit hit SNMP notifications
Nikolai Kondrashov [Wed, 16 Jul 2014 17:04:20 +0000 (20:04 +0300)]
Clarify conditions of limit hit SNMP notifications

Use "hit" instead of "reach" in the descriptions of serverMaxRequest and
serverMaxThreads SNMP notifications to make it clearer that they trigger
upon attempt to exceed the limit, not upon reaching the maximum allowed
value.

9 years agoSwitch .cnf files to sha256 message digest
Nikolai Kondrashov [Wed, 16 Jul 2014 17:22:40 +0000 (20:22 +0300)]
Switch .cnf files to sha256 message digest

Use sha256 as default_md (message digest) in all .cnf files as it is
more secure than the previous, now considered weak, sha1.