tests: Use cmd_execute() for iw connect command
authorJonathan Afek <jonathan@wizery.com>
Thu, 23 Jun 2016 17:16:29 +0000 (20:16 +0300)
committerJouni Malinen <j@w1.fi>
Mon, 27 Jun 2016 18:10:35 +0000 (21:10 +0300)
The hwsim tests used to execute shell commands in the tests using the
subprocess python module. Use the cmd_execute() general function for
executing "iw connect ..." commands so that this would also work on
remote setups.

Signed-off-by: Jonathan Afek <jonathanx.afek@intel.com>
tests/hwsim/test_ap_open.py

index fe52956..69d2564 100644 (file)
@@ -160,8 +160,8 @@ def test_ap_open_unexpected_assoc_event(dev, apdev):
     dev[0].wait_disconnected(timeout=15)
     dev[0].dump_monitor()
     # This will be accepted due to matching network
-    subprocess.call(['iw', 'dev', dev[0].ifname, 'connect', 'open', "2412",
-                     apdev[0]['bssid']])
+    dev[0].cmd_execute(['iw', 'dev', dev[0].ifname, 'connect', 'open', "2412",
+                        apdev[0]['bssid']])
     dev[0].wait_connected(timeout=15)
     dev[0].dump_monitor()
 
@@ -169,8 +169,8 @@ def test_ap_open_unexpected_assoc_event(dev, apdev):
     dev[0].wait_disconnected(timeout=5)
     dev[0].dump_monitor()
     # This will result in disconnection due to no matching network
-    subprocess.call(['iw', 'dev', dev[0].ifname, 'connect', 'open', "2412",
-                     apdev[0]['bssid']])
+    dev[0].cmd_execute(['iw', 'dev', dev[0].ifname, 'connect', 'open', "2412",
+                        apdev[0]['bssid']])
     dev[0].wait_disconnected(timeout=15)
 
 def test_ap_bss_load(dev, apdev):