summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
8e590f0)
If base64_encode() fails (e.g., due to memory allocation failure), the
return value needs to be checked against NULL before using the (not
really) returned length value. The error path here ended up reading
uninitialized variable.
Signed-off-by: Jouni Malinen <j@w1.fi>
return -1;
b64 = base64_encode(&icon->image[offset], size, &b64_size);
return -1;
b64 = base64_encode(&icon->image[offset], size, &b64_size);
- if (buf_len >= b64_size) {
+ if (b64 && buf_len >= b64_size) {
os_memcpy(reply, b64, b64_size);
reply_size = b64_size;
} else {
os_memcpy(reply, b64, b64_size);
reply_size = b64_size;
} else {