scan: Clean up code a bit - phase1 is used in all WPS cases
authorJouni Malinen <j@w1.fi>
Sun, 22 May 2016 14:44:28 +0000 (17:44 +0300)
committerJouni Malinen <j@w1.fi>
Sun, 22 May 2016 14:44:28 +0000 (17:44 +0300)
There is no need to have a separate if statement to skip the cases where
phase1 is not set. Just check it with the strstr comparison since this
case is not really used in practice.

Signed-off-by: Jouni Malinen <j@w1.fi>
wpa_supplicant/scan.c

index bfee756..9a3c4c9 100644 (file)
@@ -59,10 +59,7 @@ static int wpas_wps_in_use(struct wpa_supplicant *wpa_s,
 
                wps = 1;
                *req_type = wpas_wps_get_req_type(ssid);
-               if (!ssid->eap.phase1)
-                       continue;
-
-               if (os_strstr(ssid->eap.phase1, "pbc=1"))
+               if (ssid->eap.phase1 && os_strstr(ssid->eap.phase1, "pbc=1"))
                        return 2;
        }